Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1216520 > unrolled thread

[PATCH v2] reset: Add (devm_)reset_control_get stub functions

Started byAxel Lin <axel.lin@ingics.com>
First post2015-09-01 02:00 +0200
Last post2015-09-01 15:20 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v2] reset: Add (devm_)reset_control_get stub functions Axel Lin <axel.lin@ingics.com> - 2015-09-01 02:00 +0200
    Re: [PATCH v2] reset: Add (devm_)reset_control_get stub functions Philipp Zabel <p.zabel@pengutronix.de> - 2015-09-01 10:10 +0200
      Re: [PATCH v2] reset: Add (devm_)reset_control_get stub functions Mark Brown <broonie@kernel.org> - 2015-09-01 15:20 +0200
        Re: [PATCH v2] reset: Add (devm_)reset_control_get stub functions Takashi Iwai <tiwai@suse.de> - 2015-09-01 15:20 +0200

#1216520 — [PATCH v2] reset: Add (devm_)reset_control_get stub functions

FromAxel Lin <axel.lin@ingics.com>
Date2015-09-01 02:00 +0200
Subject[PATCH v2] reset: Add (devm_)reset_control_get stub functions
Message-ID<q3H9v-6a7-3@gated-at.bofh.it>
So the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
v2: Add __must_check and WARN_ON(1); And make it return ERR_PTR(-EINVAL).

 include/linux/reset.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/include/linux/reset.h b/include/linux/reset.h
index da5602b..7f65f9c 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -74,6 +74,20 @@ static inline int device_reset_optional(struct device *dev)
 	return -ENOSYS;
 }
 
+static inline struct reset_control *__must_check reset_control_get(
+					struct device *dev, const char *id)
+{
+	WARN_ON(1);
+	return ERR_PTR(-EINVAL);
+}
+
+static inline struct reset_control *__must_check devm_reset_control_get(
+					struct device *dev, const char *id)
+{
+	WARN_ON(1);
+	return ERR_PTR(-EINVAL);
+}
+
 static inline struct reset_control *reset_control_get_optional(
 					struct device *dev, const char *id)
 {
-- 
1.9.1



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1216658

FromPhilipp Zabel <p.zabel@pengutronix.de>
Date2015-09-01 10:10 +0200
Message-ID<q3ONH-Jq-1@gated-at.bofh.it>
In reply to#1216520
Am Dienstag, den 01.09.2015, 07:56 +0800 schrieb Axel Lin:
> So the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Applied, thanks.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1216835

FromMark Brown <broonie@kernel.org>
Date2015-09-01 15:20 +0200
Message-ID<q3TDH-7C5-3@gated-at.bofh.it>
In reply to#1216658

[Multipart message — attachments visible in raw view] — view raw

On Tue, Sep 01, 2015 at 10:04:36AM +0200, Philipp Zabel wrote:
> Am Dienstag, den 01.09.2015, 07:56 +0800 schrieb Axel Lin:
> > So the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled.

> > Signed-off-by: Axel Lin <axel.lin@ingics.com>

> Applied, thanks.

Takashi, this should be enough for the build error in ASoC to be fixed
by the time -rc1 comes out I expect.  Thanks Axel & Philipp.

[toc] | [prev] | [next] | [standalone]


#1216839

FromTakashi Iwai <tiwai@suse.de>
Date2015-09-01 15:20 +0200
Message-ID<q3TDI-7C5-21@gated-at.bofh.it>
In reply to#1216835
On Tue, 01 Sep 2015 15:13:09 +0200,
Mark Brown wrote:
> 
> On Tue, Sep 01, 2015 at 10:04:36AM +0200, Philipp Zabel wrote:
> > Am Dienstag, den 01.09.2015, 07:56 +0800 schrieb Axel Lin:
> > > So the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled.
> 
> > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> 
> > Applied, thanks.
> 
> Takashi, this should be enough for the build error in ASoC to be fixed
> by the time -rc1 comes out I expect.  Thanks Axel & Philipp.

Yep, I'm going to send a pull request tomorrow :)


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web