Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1216560 > unrolled thread
| Started by | Tan Jui Nee <jui.nee.tan@intel.com> |
|---|---|
| First post | 2015-09-01 04:30 +0200 |
| Last post | 2015-09-01 09:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] spi: spi-pxa2xx: Check status register to determine if SSSR_TINT is disabled Tan Jui Nee <jui.nee.tan@intel.com> - 2015-09-01 04:30 +0200
Re: [PATCH] spi: spi-pxa2xx: Check status register to determine if SSSR_TINT is disabled Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2015-09-01 09:50 +0200
| From | Tan Jui Nee <jui.nee.tan@intel.com> |
|---|---|
| Date | 2015-09-01 04:30 +0200 |
| Subject | [PATCH] spi: spi-pxa2xx: Check status register to determine if SSSR_TINT is disabled |
| Message-ID | <q3JuF-1tS-3@gated-at.bofh.it> |
From: "Tan, Jui Nee" <jui.nee.tan@intel.com> On Intel Baytrail, there is case when interrupt handler get called, no SPI message is captured. The RX FIFO is indeed empty when RX timeout pending interrupt (SSSR_TINT) happens. Use the BIOS version where both HSUART and SPI are on the same IRQ. Both drivers are using IRQF_SHARED when calling the request_irq function. When running two separate and independent SPI and HSUART application that generate data traffic on both components, user will see messages like below on the console: pxa2xx-spi pxa2xx-spi.0: bad message state in interrupt handler This commit will fix this by first checking Receiver Time-out Interrupt, if it is disabled, ignore the request and return without servicing. Signed-off-by: Tan, Jui Nee <jui.nee.tan@intel.com> --- drivers/spi/spi-pxa2xx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index fdd79197..a8ef38e 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -654,6 +654,10 @@ static irqreturn_t ssp_int(int irq, void *dev_id) if (!(sccr1_reg & SSCR1_TIE)) mask &= ~SSSR_TFS; + /* Ignore RX timeout interrupt if it is disabled */ + if (!(sccr1_reg & SSCR1_TINTE)) + mask &= ~SSSR_TINT; + if (!(status & mask)) return IRQ_NONE; -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jarkko Nikula <jarkko.nikula@linux.intel.com> |
|---|---|
| Date | 2015-09-01 09:50 +0200 |
| Subject | Re: [PATCH] spi: spi-pxa2xx: Check status register to determine if SSSR_TINT is disabled |
| Message-ID | <q3Oum-7o-11@gated-at.bofh.it> |
| In reply to | #1216560 |
On 09/01/2015 05:22 AM, Tan Jui Nee wrote: > From: "Tan, Jui Nee" <jui.nee.tan@intel.com> > > On Intel Baytrail, there is case when interrupt handler get called, no SPI > message is captured. The RX FIFO is indeed empty when RX timeout pending > interrupt (SSSR_TINT) happens. > > Use the BIOS version where both HSUART and SPI are on the same IRQ. Both > drivers are using IRQF_SHARED when calling the request_irq function. When > running two separate and independent SPI and HSUART application that > generate data traffic on both components, user will see messages like > below on the console: > > pxa2xx-spi pxa2xx-spi.0: bad message state in interrupt handler > > This commit will fix this by first checking Receiver Time-out Interrupt, > if it is disabled, ignore the request and return without servicing. > > Signed-off-by: Tan, Jui Nee <jui.nee.tan@intel.com> > --- > drivers/spi/spi-pxa2xx.c | 4 ++++ > 1 file changed, 4 insertions(+) > Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web