Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1215578 > unrolled thread

[PATCH] perf, tools: Make alias matching case-insensitive

Back to article view | Back to linux.kernel

Contents

  [PATCH] perf, tools: Make alias matching case-insensitive Andi Kleen <andi@firstfloor.org> - 2015-08-28 23:50 +0200
    Re: [PATCH] perf, tools: Make alias matching case-insensitive Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> - 2015-08-31 21:00 +0200

#1215578 — [PATCH] perf, tools: Make alias matching case-insensitive

From: Andi Kleen <ak@linux.intel.com>

Make alias matching the events parser case-insensitive. This is useful
with the JSON events. perf uses lower case events, but the CPU manuals
generally use upper case event names. The JSON files use lower
case by default too. But if we search case insensitively then
users can cut-n-paste the upper case event names.

So the following works:

% perf stat -e BR_INST_EXEC.TAKEN_INDIRECT_NEAR_CALL true

 Performance counter stats for 'true':

               305      BR_INST_EXEC.TAKEN_INDIRECT_NEAR_CALL

       0.000492799 seconds time elapsed

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 tools/perf/util/parse-events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index e14ceb6..2347840 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -981,7 +981,7 @@ comp_pmu(const void *p1, const void *p2)
 	struct perf_pmu_event_symbol *pmu1 = (struct perf_pmu_event_symbol *) p1;
 	struct perf_pmu_event_symbol *pmu2 = (struct perf_pmu_event_symbol *) p2;
 
-	return strcmp(pmu1->symbol, pmu2->symbol);
+	return strcasecmp(pmu1->symbol, pmu2->symbol);
 }
 
 static void perf_pmu__parse_cleanup(void)
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1216374

Andi Kleen [andi@firstfloor.org] wrote:
| From: Andi Kleen <ak@linux.intel.com>
| 
| Make alias matching the events parser case-insensitive. This is useful
| with the JSON events. perf uses lower case events, but the CPU manuals
| generally use upper case event names. The JSON files use lower
| case by default too. But if we search case insensitively then
| users can cut-n-paste the upper case event names.
| 
| So the following works:
| 
| % perf stat -e BR_INST_EXEC.TAKEN_INDIRECT_NEAR_CALL true
| 
|  Performance counter stats for 'true':
| 
|                305      BR_INST_EXEC.TAKEN_INDIRECT_NEAR_CALL
| 
|        0.000492799 seconds time elapsed
| 
| Signed-off-by: Andi Kleen <ak@linux.intel.com>
Tested-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>

I have also pushed this to 'json-v16' branch of my github tree:

	https://github.com/sukadev/linux

Sukadev

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web