Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216306 > unrolled thread

Re: [PATCH] Remove check for SAS expander when querying bay/enclosure IDs.

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] Remove check for SAS expander when querying bay/enclosure IDs. Jordan Hargrave <jharg93@gmail.com> - 2015-08-31 18:30 +0200

#1216306 — Re: [PATCH] Remove check for SAS expander when querying bay/enclosure IDs.

On Tue, Jul 14, 2015 at 6:23 AM, Hannes Reinecke <hare@suse.de> wrote:
> On 07/13/2015 04:27 PM, Jordan Hargrave wrote:
>> Dell Server backplanes can report bay/enclosure IDs without an
>> expander present.  This patch allows the bay/enclosure IDs to be
>> propagaged to sysfs.we
>>
>> Signed-off-by: Jordan Hargrave <jordan_hargrave@dell.com>
>> ---
>>  drivers/scsi/scsi_transport_sas.c | 10 ----------
>>  1 file changed, 10 deletions(-)
>>
>> diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c
>> index 9a05819..30d26e3 100644
>> --- a/drivers/scsi/scsi_transport_sas.c
>> +++ b/drivers/scsi/scsi_transport_sas.c
>> @@ -1222,13 +1222,6 @@ show_sas_rphy_enclosure_identifier(struct device *dev,
>>       u64 identifier;
>>       int error;
>>
>> -     /*
>> -      * Only devices behind an expander are supported, because the
>> -      * enclosure identifier is a SMP feature.
>> -      */
>> -     if (scsi_is_sas_phy_local(phy))
>> -             return -EINVAL;
>> -
>>       error = i->f->get_enclosure_identifier(rphy, &identifier);
>>       if (error)
>>               return error;
>> @@ -1248,9 +1241,6 @@ show_sas_rphy_bay_identifier(struct device *dev,
>>       struct sas_internal *i = to_sas_internal(shost->transportt);
>>       int val;
>>
>> -     if (scsi_is_sas_phy_local(phy))
>> -             return -EINVAL;
>> -
>>       val = i->f->get_bay_identifier(rphy);
>>       if (val < 0)
>>               return val;
>>
> Reviewed-by: Hannes Reinecke <hare@suse.com>
>
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke                            zSeries & Storage
> hare@suse.de                                   +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
> HRB 21284 (AG Nürnberg)

Any updates on getting this included?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web