Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1215514 > unrolled thread

[PATCH 0/2] Some phylib simplifications

Started bySergei Shtylyov <sergei.shtylyov@cogentembedded.com>
First post2015-08-28 20:40 +0200
Last post2015-08-28 23:20 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/2] Some phylib simplifications Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-08-28 20:40 +0200
    [PATCH 1/2] phylib: simplify bogus phy_device_create() result Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-08-28 20:40 +0200
    Re: [PATCH 0/2] Some phylib simplifications David Miller <davem@davemloft.net> - 2015-08-28 23:20 +0200

#1215514 — [PATCH 0/2] Some phylib simplifications

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2015-08-28 20:40 +0200
Subject[PATCH 0/2] Some phylib simplifications
Message-ID<q2wJb-30v-3@gated-at.bofh.it>
Hello.

   Here's 2 patches against DaveM's 'net-next.git' repo. We simplify a bogus
string of type casts in the 1st patch and make the code respect some coding
standards of the networking code in the 2nd one. I may follow with fixing of
checkpatch.pl's complaints. if I have time..

[1/2] phylib: simplify bogus phy_device_create() result
[2/2] phylib: simplify NULL checks

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1215515 — [PATCH 1/2] phylib: simplify bogus phy_device_create() result

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2015-08-28 20:40 +0200
Subject[PATCH 1/2] phylib: simplify bogus phy_device_create() result
Message-ID<q2wJc-30v-13@gated-at.bofh.it>
In reply to#1215514
Get rid of the bogus string of type casts where ERR_PTR() is enough.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 drivers/net/phy/phy_device.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: net-next/drivers/net/phy/phy_device.c
===================================================================
--- net-next.orig/drivers/net/phy/phy_device.c
+++ net-next/drivers/net/phy/phy_device.c
@@ -157,7 +157,7 @@ struct phy_device *phy_device_create(str
 	/* We allocate the device, and initialize the default values */
 	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
 	if (NULL == dev)
-		return (struct phy_device *)PTR_ERR((void *)-ENOMEM);
+		return ERR_PTR(-ENOMEM);
 
 	dev->dev.release = phy_device_release;
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1215565

FromDavid Miller <davem@davemloft.net>
Date2015-08-28 23:20 +0200
Message-ID<q2ze2-6CP-3@gated-at.bofh.it>
In reply to#1215514
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 28 Aug 2015 21:33:43 +0300

>    Here's 2 patches against DaveM's 'net-next.git' repo. We simplify a bogus
> string of type casts in the 1st patch and make the code respect some coding
> standards of the networking code in the 2nd one. I may follow with fixing of
> checkpatch.pl's complaints. if I have time..

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web