Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1210368 > unrolled thread
| Started by | David Vrabel <david.vrabel@citrix.com> |
|---|---|
| First post | 2015-08-20 12:00 +0200 |
| Last post | 2015-08-28 17:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [Xen-devel] [PATCH v3 11/20] tty/hvc: xen: Use xen page definition David Vrabel <david.vrabel@citrix.com> - 2015-08-20 12:00 +0200
Re: [Xen-devel] [PATCH v3 11/20] tty/hvc: xen: Use xen page definition Julien Grall <julien.grall@citrix.com> - 2015-08-28 17:10 +0200
| From | David Vrabel <david.vrabel@citrix.com> |
|---|---|
| Date | 2015-08-20 12:00 +0200 |
| Subject | Re: [Xen-devel] [PATCH v3 11/20] tty/hvc: xen: Use xen page definition |
| Message-ID | <pZuND-1gR-59@gated-at.bofh.it> |
On 07/08/15 17:46, Julien Grall wrote: > The console ring is always based on the page granularity of Xen. [...] > --- a/drivers/tty/hvc/hvc_xen.c > +++ b/drivers/tty/hvc/hvc_xen.c > @@ -230,7 +230,7 @@ static int xen_hvm_console_init(void) > if (r < 0 || v == 0) > goto err; > gfn = v; > - info->intf = xen_remap(gfn << PAGE_SHIFT, PAGE_SIZE); > + info->intf = xen_remap(gfn << XEN_PAGE_SHIFT, PAGE_SIZE); You need XEN_PAGE_SIZE here I think... > if (info->intf == NULL) > goto err; > info->vtermno = HVC_COOKIE; > @@ -472,7 +472,7 @@ static int xencons_resume(struct xenbus_device *dev) > struct xencons_info *info = dev_get_drvdata(&dev->dev); > > xencons_disconnect_backend(info); > - memset(info->intf, 0, PAGE_SIZE); > + memset(info->intf, 0, XEN_PAGE_SIZE); ...particularly since you use it here. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Julien Grall <julien.grall@citrix.com> |
|---|---|
| Date | 2015-08-28 17:10 +0200 |
| Message-ID | <q2trY-6Qn-13@gated-at.bofh.it> |
| In reply to | #1210368 |
Hi David, On 20/08/15 10:55, David Vrabel wrote: > On 07/08/15 17:46, Julien Grall wrote: >> The console ring is always based on the page granularity of Xen. > [...] >> --- a/drivers/tty/hvc/hvc_xen.c >> +++ b/drivers/tty/hvc/hvc_xen.c >> @@ -230,7 +230,7 @@ static int xen_hvm_console_init(void) >> if (r < 0 || v == 0) >> goto err; >> gfn = v; >> - info->intf = xen_remap(gfn << PAGE_SHIFT, PAGE_SIZE); >> + info->intf = xen_remap(gfn << XEN_PAGE_SHIFT, PAGE_SIZE); > > You need XEN_PAGE_SIZE here I think... Right, I did the mistake while rebase on my s/mfn/gfn/ series. I will fix it in the next version. Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web