Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1214606 > unrolled thread
| Started by | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| First post | 2015-08-27 16:30 +0200 |
| Last post | 2015-08-28 02:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v1 3/5] ARM: dts: Add arm,pl330-broken-no-flushp quirk for rk3288 platform Shawn Lin <shawn.lin@rock-chips.com> - 2015-08-27 16:30 +0200
Re: [PATCH v1 3/5] ARM: dts: Add arm, pl330-broken-no-flushp quirk for rk3288 platform Doug Anderson <dianders@chromium.org> - 2015-08-27 19:00 +0200
Re: [PATCH v1 3/5] ARM: dts: Add arm, pl330-broken-no-flushp quirk for rk3288 platform Shawn Lin <shawn.lin@rock-chips.com> - 2015-08-28 02:00 +0200
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2015-08-27 16:30 +0200 |
| Subject | [PATCH v1 3/5] ARM: dts: Add arm,pl330-broken-no-flushp quirk for rk3288 platform |
| Message-ID | <q26lI-72W-23@gated-at.bofh.it> |
From: Addy Ke <addy.ke@rock-chips.com>
Pl330 integrated in rk3288 platform doesn't support
DMAFLUSHP function. So we add broken-no-flushp quirk
for it.
Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
cc: Heiko Stuebner <heiko@sntech.de>
cc: Doug Anderson <dianders@chromium.org>
cc: Olof Johansson <olofj@google.com>
---
Changes in v1:
- rename broken-no-flushp to "arm,pl330-broken-no-flushp" suggested
by Krzysztof.
- remove Sunny's tag
arch/arm/boot/dts/rk3288.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 22316d0..106adf7 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -144,6 +144,7 @@
#dma-cells = <1>;
clocks = <&cru ACLK_DMAC2>;
clock-names = "apb_pclk";
+ arm,pl330-broken-no-flushp;
};
dmac_bus_ns: dma-controller@ff600000 {
@@ -155,6 +156,7 @@
clocks = <&cru ACLK_DMAC1>;
clock-names = "apb_pclk";
status = "disabled";
+ arm,pl330-broken-no-flushp;
};
dmac_bus_s: dma-controller@ffb20000 {
@@ -165,6 +167,7 @@
#dma-cells = <1>;
clocks = <&cru ACLK_DMAC1>;
clock-names = "apb_pclk";
+ arm,pl330-broken-no-flushp;
};
};
--
2.3.7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Doug Anderson <dianders@chromium.org> |
|---|---|
| Date | 2015-08-27 19:00 +0200 |
| Subject | Re: [PATCH v1 3/5] ARM: dts: Add arm, pl330-broken-no-flushp quirk for rk3288 platform |
| Message-ID | <q28GT-1SK-11@gated-at.bofh.it> |
| In reply to | #1214606 |
Hi,
On Thu, Aug 27, 2015 at 7:24 AM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> From: Addy Ke <addy.ke@rock-chips.com>
Looks like you just added the "From" here. I think that's fine, but
better to set the author so you get the right cover letter...
> Pl330 integrated in rk3288 platform doesn't support
> DMAFLUSHP function. So we add broken-no-flushp quirk
> for it.
>
> Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> cc: Heiko Stuebner <heiko@sntech.de>
> cc: Doug Anderson <dianders@chromium.org>
> cc: Olof Johansson <olofj@google.com>
>
> ---
>
> Changes in v1:
> - rename broken-no-flushp to "arm,pl330-broken-no-flushp" suggested
> by Krzysztof.
> - remove Sunny's tag
Note that typically for patches I see people go from "no v" to "v2". AKA:
* PATCH
* PATCH v2
* PATCH v3
> arch/arm/boot/dts/rk3288.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 22316d0..106adf7 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -144,6 +144,7 @@
> #dma-cells = <1>;
> clocks = <&cru ACLK_DMAC2>;
> clock-names = "apb_pclk";
> + arm,pl330-broken-no-flushp;
Note that you should add bindings _before_ the usage of them. So
patch #5 (Documentation) needs to come before this one.
> };
>
> dmac_bus_ns: dma-controller@ff600000 {
> @@ -155,6 +156,7 @@
> clocks = <&cru ACLK_DMAC1>;
> clock-names = "apb_pclk";
> status = "disabled";
> + arm,pl330-broken-no-flushp;
> };
>
> dmac_bus_s: dma-controller@ffb20000 {
> @@ -165,6 +167,7 @@
> #dma-cells = <1>;
> clocks = <&cru ACLK_DMAC1>;
> clock-names = "apb_pclk";
> + arm,pl330-broken-no-flushp;
> };
> };
Other than the small nits above, this looks fine to me.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2015-08-28 02:00 +0200 |
| Subject | Re: [PATCH v1 3/5] ARM: dts: Add arm, pl330-broken-no-flushp quirk for rk3288 platform |
| Message-ID | <q2ffk-2SO-13@gated-at.bofh.it> |
| In reply to | #1214703 |
On 2015/8/28 0:52, Doug Anderson wrote:
> Hi,
>
> On Thu, Aug 27, 2015 at 7:24 AM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
>> From: Addy Ke <addy.ke@rock-chips.com>
>
> Looks like you just added the "From" here. I think that's fine, but
> better to set the author so you get the right cover letter...
>
>
>> Pl330 integrated in rk3288 platform doesn't support
>> DMAFLUSHP function. So we add broken-no-flushp quirk
>> for it.
>>
>> Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>> cc: Heiko Stuebner <heiko@sntech.de>
>> cc: Doug Anderson <dianders@chromium.org>
>> cc: Olof Johansson <olofj@google.com>
>>
>> ---
>>
>> Changes in v1:
>> - rename broken-no-flushp to "arm,pl330-broken-no-flushp" suggested
>> by Krzysztof.
>> - remove Sunny's tag
>
> Note that typically for patches I see people go from "no v" to "v2". AKA:
> * PATCH
> * PATCH v2
> * PATCH v3
>
>
>> arch/arm/boot/dts/rk3288.dtsi | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
>> index 22316d0..106adf7 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -144,6 +144,7 @@
>> #dma-cells = <1>;
>> clocks = <&cru ACLK_DMAC2>;
>> clock-names = "apb_pclk";
>> + arm,pl330-broken-no-flushp;
>
> Note that you should add bindings _before_ the usage of them. So
> patch #5 (Documentation) needs to come before this one.
>
Cool! That makes sense.
Thanks, Doug.
>> };
>>
>> dmac_bus_ns: dma-controller@ff600000 {
>> @@ -155,6 +156,7 @@
>> clocks = <&cru ACLK_DMAC1>;
>> clock-names = "apb_pclk";
>> status = "disabled";
>> + arm,pl330-broken-no-flushp;
>> };
>>
>> dmac_bus_s: dma-controller@ffb20000 {
>> @@ -165,6 +167,7 @@
>> #dma-cells = <1>;
>> clocks = <&cru ACLK_DMAC1>;
>> clock-names = "apb_pclk";
>> + arm,pl330-broken-no-flushp;
>> };
>> };
>
> Other than the small nits above, this looks fine to me.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
>
>
--
Best Regards
Shawn Lin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web