Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1214601 > unrolled thread

[PATCH] mm, migrate: count pages failing all retries in vmstat and tracepoint

Back to article view | Back to linux.kernel

Contents

  [PATCH] mm, migrate: count pages failing all retries in vmstat and tracepoint Vlastimil Babka <vbabka@suse.cz> - 2015-08-27 16:30 +0200
    Re: [PATCH] mm, migrate: count pages failing all retries in vmstat  and tracepoint David Rientjes <rientjes@google.com> - 2015-08-27 23:10 +0200
      Re: [PATCH] mm, migrate: count pages failing all retries in vmstat  and tracepoint Vlastimil Babka <vbabka@suse.cz> - 2015-08-27 23:40 +0200

#1214601 — [PATCH] mm, migrate: count pages failing all retries in vmstat and tracepoint

Migration tries up to 10 times to migrate pages that return -EAGAIN until it
gives up. If some pages fail all retries, they are counted towards the number
of failed pages that migrate_pages() returns. They should also be counted in
the /proc/vmstat pgmigrate_fail and in the mm_migrate_pages tracepoint.

Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
---
 mm/migrate.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index eb42671..e705324 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1152,7 +1152,8 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
 			}
 		}
 	}
-	rc = nr_failed + retry;
+	nr_failed += retry;
+	rc = nr_failed;
 out:
 	if (nr_succeeded)
 		count_vm_events(PGMIGRATE_SUCCESS, nr_succeeded);
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1214829 — Re: [PATCH] mm, migrate: count pages failing all retries in vmstat and tracepoint

On Thu, 27 Aug 2015, Vlastimil Babka wrote:

> Migration tries up to 10 times to migrate pages that return -EAGAIN until it
> gives up. If some pages fail all retries, they are counted towards the number
> of failed pages that migrate_pages() returns. They should also be counted in
> the /proc/vmstat pgmigrate_fail and in the mm_migrate_pages tracepoint.
> 
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>

Acked-by: David Rientjes <rientjes@google.com>

I assume nothing else other than stats and tracepoints are affected by 
this and this isn't a critical bugfix :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1214835 — Re: [PATCH] mm, migrate: count pages failing all retries in vmstat and tracepoint

On 27.8.2015 23:02, David Rientjes wrote:
> On Thu, 27 Aug 2015, Vlastimil Babka wrote:
> 
>> Migration tries up to 10 times to migrate pages that return -EAGAIN until it
>> gives up. If some pages fail all retries, they are counted towards the number
>> of failed pages that migrate_pages() returns. They should also be counted in
>> the /proc/vmstat pgmigrate_fail and in the mm_migrate_pages tracepoint.
>>
>> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> 
> Acked-by: David Rientjes <rientjes@google.com>

Thanks.

> I assume nothing else other than stats and tracepoints are affected by 
> this and this isn't a critical bugfix :)

Yep, no stable needed :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web