Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1210391 > unrolled thread
| Started by | Adriana Reus <adriana.reus@intel.com> |
|---|---|
| First post | 2015-08-20 12:20 +0200 |
| Last post | 2015-08-31 17:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v6 0/2] Add support and documentation for UPISEMI us5182d als and proximity sensor Adriana Reus <adriana.reus@intel.com> - 2015-08-20 12:20 +0200
[PATCH v6 2/2] devicetree: Add documentation for UPISEMI us5182d ALS and Proximity sensor Adriana Reus <adriana.reus@intel.com> - 2015-08-20 12:20 +0200
Re: [PATCH v6 2/2] devicetree: Add documentation for UPISEMI us5182d ALS and Proximity sensor Jonathan Cameron <jic23@kernel.org> - 2015-08-27 22:30 +0200
Re: [PATCH v6 2/2] devicetree: Add documentation for UPISEMI us5182d ALS and Proximity sensor Rob Herring <robherring2@gmail.com> - 2015-08-31 17:40 +0200
| From | Adriana Reus <adriana.reus@intel.com> |
|---|---|
| Date | 2015-08-20 12:20 +0200 |
| Subject | [PATCH v6 0/2] Add support and documentation for UPISEMI us5182d als and proximity sensor |
| Message-ID | <pZv6V-1SU-3@gated-at.bofh.it> |
This series adds basic support for this als and proximity sensor
and devicetree docs.
Adriana Reus (2):
iio: light: Add support for UPISEMI uS5182d als and proximity sensor
devicetree: Add documentation for UPISEMI us5182d ALS and Proximity
sensor
.../devicetree/bindings/iio/light/us5182d.txt | 23 +
.../devicetree/bindings/vendor-prefixes.txt | 1 +
drivers/iio/light/Kconfig | 10 +
drivers/iio/light/Makefile | 1 +
drivers/iio/light/us5182d.c | 507 +++++++++++++++++++++
5 files changed, 542 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/us5182d.txt
create mode 100644 drivers/iio/light/us5182d.c
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Adriana Reus <adriana.reus@intel.com> |
|---|---|
| Date | 2015-08-20 12:20 +0200 |
| Subject | [PATCH v6 2/2] devicetree: Add documentation for UPISEMI us5182d ALS and Proximity sensor |
| Message-ID | <pZv6V-1SU-11@gated-at.bofh.it> |
| In reply to | #1210391 |
Added entries in i2c/vendor-prefixes for the us5182d als and proximity sensor.
Also added a documentation file for this sensor's properties.
Signed-off-by: Adriana Reus <adriana.reus@intel.com>
---
.../devicetree/bindings/iio/light/us5182d.txt | 23 ++++++++++++++++++++++
.../devicetree/bindings/vendor-prefixes.txt | 1 +
2 files changed, 24 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/us5182d.txt
diff --git a/Documentation/devicetree/bindings/iio/light/us5182d.txt b/Documentation/devicetree/bindings/iio/light/us5182d.txt
new file mode 100644
index 0000000..7785c56
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/us5182d.txt
@@ -0,0 +1,23 @@
+* UPISEMI us5182d I2C ALS and Proximity sensor
+
+Required properties:
+- compatible: must be "upisemi,usd5182"
+- reg: the I2C address of the device
+
+Optional properties:
+- upisemi,glass-coef: glass attenuation factor
+- upisemi,dark-ths: array of thresholds (adc counts) corresponding to every scale
+- upisemi,upper-dark-gain: tuning factor(4 int and 4 fractional bits - Q4.4) applied when light > threshold
+- upisemi,lower-dark-gain: tuning factor(4 int and 4 fractional bits - Q4.4) applied when light < threshold
+
+Example:
+
+ usd5182@39 {
+ compatible = "upisemi,usd5182";
+ reg = <0x39>;
+ upisemi,glass-coef = < 1000 >;
+ upisemi,dark-ths = /bits/ 16 <170 200 512 512 800 2000 4000 8000>;
+ upisemi,upper-dark-gain = /bits/ 8 <0x00>;
+ upisemi,lower-dark-gain = /bits/ 8 <0x16>;
+ };
+
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index d444757..5b40bab 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -211,6 +211,7 @@ toshiba Toshiba Corporation
toumaz Toumaz
tplink TP-LINK Technologies Co., Ltd.
truly Truly Semiconductors Limited
+upisemi uPI Semiconductor Corp.
usi Universal Scientific Industrial Co., Ltd.
v3 V3 Semiconductor
variscite Variscite Ltd.
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2015-08-27 22:30 +0200 |
| Subject | Re: [PATCH v6 2/2] devicetree: Add documentation for UPISEMI us5182d ALS and Proximity sensor |
| Message-ID | <q2bY7-6If-29@gated-at.bofh.it> |
| In reply to | #1210392 |
On 20/08/15 11:12, Adriana Reus wrote:
> Added entries in i2c/vendor-prefixes for the us5182d als and proximity sensor.
> Also added a documentation file for this sensor's properties.
>
> Signed-off-by: Adriana Reus <adriana.reus@intel.com>
This isn't that trivial so I'd like some device tree maintainer
input if possible.
For now I've backed out the driver from my tree (given timing we have
loads of time to sort this out!)
Anyhow, anyone device tree related able to take a look at this.
Adriana, btw these should be cc'd to the device tree maintainers in
the first place (now added).
Jonathan
> ---
> .../devicetree/bindings/iio/light/us5182d.txt | 23 ++++++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> 2 files changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/us5182d.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/light/us5182d.txt b/Documentation/devicetree/bindings/iio/light/us5182d.txt
> new file mode 100644
> index 0000000..7785c56
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/us5182d.txt
> @@ -0,0 +1,23 @@
> +* UPISEMI us5182d I2C ALS and Proximity sensor
> +
> +Required properties:
> +- compatible: must be "upisemi,usd5182"
> +- reg: the I2C address of the device
> +
> +Optional properties:
> +- upisemi,glass-coef: glass attenuation factor
> +- upisemi,dark-ths: array of thresholds (adc counts) corresponding to every scale
> +- upisemi,upper-dark-gain: tuning factor(4 int and 4 fractional bits - Q4.4) applied when light > threshold
> +- upisemi,lower-dark-gain: tuning factor(4 int and 4 fractional bits - Q4.4) applied when light < threshold
> +
> +Example:
> +
> + usd5182@39 {
> + compatible = "upisemi,usd5182";
> + reg = <0x39>;
> + upisemi,glass-coef = < 1000 >;
> + upisemi,dark-ths = /bits/ 16 <170 200 512 512 800 2000 4000 8000>;
> + upisemi,upper-dark-gain = /bits/ 8 <0x00>;
> + upisemi,lower-dark-gain = /bits/ 8 <0x16>;
> + };
> +
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index d444757..5b40bab 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -211,6 +211,7 @@ toshiba Toshiba Corporation
> toumaz Toumaz
> tplink TP-LINK Technologies Co., Ltd.
> truly Truly Semiconductors Limited
> +upisemi uPI Semiconductor Corp.
> usi Universal Scientific Industrial Co., Ltd.
> v3 V3 Semiconductor
> variscite Variscite Ltd.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robherring2@gmail.com> |
|---|---|
| Date | 2015-08-31 17:40 +0200 |
| Subject | Re: [PATCH v6 2/2] devicetree: Add documentation for UPISEMI us5182d ALS and Proximity sensor |
| Message-ID | <q3zlF-3rM-43@gated-at.bofh.it> |
| In reply to | #1214818 |
On Thu, Aug 27, 2015 at 3:23 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 20/08/15 11:12, Adriana Reus wrote:
>> Added entries in i2c/vendor-prefixes for the us5182d als and proximity sensor.
>> Also added a documentation file for this sensor's properties.
>>
>> Signed-off-by: Adriana Reus <adriana.reus@intel.com>
> This isn't that trivial so I'd like some device tree maintainer
> input if possible.
It seems fairly reasonable to me. Would other ALS or proximity sensors
need similar properties?
> For now I've backed out the driver from my tree (given timing we have
> loads of time to sort this out!)
>
> Anyhow, anyone device tree related able to take a look at this.
>
> Adriana, btw these should be cc'd to the device tree maintainers in
> the first place (now added).
>
> Jonathan
>> ---
>> .../devicetree/bindings/iio/light/us5182d.txt | 23 ++++++++++++++++++++++
>> .../devicetree/bindings/vendor-prefixes.txt | 1 +
>> 2 files changed, 24 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/iio/light/us5182d.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/us5182d.txt b/Documentation/devicetree/bindings/iio/light/us5182d.txt
>> new file mode 100644
>> index 0000000..7785c56
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/light/us5182d.txt
>> @@ -0,0 +1,23 @@
>> +* UPISEMI us5182d I2C ALS and Proximity sensor
>> +
>> +Required properties:
>> +- compatible: must be "upisemi,usd5182"
>> +- reg: the I2C address of the device
>> +
>> +Optional properties:
Do you expect certain defaults if not present? Some description of how
all these values are determined would be useful.
>> +- upisemi,glass-coef: glass attenuation factor
>> +- upisemi,dark-ths: array of thresholds (adc counts) corresponding to every scale
What is the size of the array and valid range of values?
Be specific this is 16-bit property.
>> +- upisemi,upper-dark-gain: tuning factor(4 int and 4 fractional bits - Q4.4) applied when light > threshold
>> +- upisemi,lower-dark-gain: tuning factor(4 int and 4 fractional bits - Q4.4) applied when light < threshold
Be specific this is an 8-bit property.
>> +
>> +Example:
>> +
>> + usd5182@39 {
>> + compatible = "upisemi,usd5182";
>> + reg = <0x39>;
>> + upisemi,glass-coef = < 1000 >;
>> + upisemi,dark-ths = /bits/ 16 <170 200 512 512 800 2000 4000 8000>;
>> + upisemi,upper-dark-gain = /bits/ 8 <0x00>;
>> + upisemi,lower-dark-gain = /bits/ 8 <0x16>;
>> + };
>> +
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> index d444757..5b40bab 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> @@ -211,6 +211,7 @@ toshiba Toshiba Corporation
>> toumaz Toumaz
>> tplink TP-LINK Technologies Co., Ltd.
>> truly Truly Semiconductors Limited
>> +upisemi uPI Semiconductor Corp.
>> usi Universal Scientific Industrial Co., Ltd.
>> v3 V3 Semiconductor
>> variscite Variscite Ltd.
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web