Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1215637 > unrolled thread

[PATCH] nfit: Fix undefined mmio_flush_range on x86_32

Back to article view | Back to linux.kernel

Contents

  [PATCH] nfit: Fix undefined mmio_flush_range on x86_32 Toshi Kani <toshi.kani@hp.com> - 2015-08-29 03:30 +0200
    Re: [PATCH] nfit: Fix undefined mmio_flush_range on x86_32 Dan Williams <dan.j.williams@intel.com> - 2015-08-29 05:40 +0200

#1215637 — [PATCH] nfit: Fix undefined mmio_flush_range on x86_32

The following compile error was observed on x86_32 since nfit.c
relies on <asm/pmem.h> to include <asm/cacheflush.h>, which only
works when CONFIG_ARCH_HAS_PMEM_API is set on x86_64.

  drivers/acpi/nfit.c:1085:5: error: implicit declaration of
  function 'mmio_flush_range' [-Werror=implicit-function-declaration]

Change nfit.c to include <asm/cacheflush.h> directly for now.

Signed-off-by: Toshi Kani <toshi.kani@hp.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
---
Apply on top of libnvdimm-for-next of the nvdimm tree.
This is a temporary fix and please feel free to replace it with
a better solution.
---
 drivers/acpi/nfit.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
index 82d07e8..f61e69f 100644
--- a/drivers/acpi/nfit.c
+++ b/drivers/acpi/nfit.c
@@ -20,6 +20,7 @@
 #include <linux/sort.h>
 #include <linux/pmem.h>
 #include <linux/io.h>
+#include <asm/cacheflush.h>
 #include "nfit.h"
 
 /*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1215668

On Fri, Aug 28, 2015 at 6:18 PM, Toshi Kani <toshi.kani@hp.com> wrote:
> The following compile error was observed on x86_32 since nfit.c
> relies on <asm/pmem.h> to include <asm/cacheflush.h>, which only
> works when CONFIG_ARCH_HAS_PMEM_API is set on x86_64.
>
>   drivers/acpi/nfit.c:1085:5: error: implicit declaration of
>   function 'mmio_flush_range' [-Werror=implicit-function-declaration]
>
> Change nfit.c to include <asm/cacheflush.h> directly for now.
>
> Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
> Apply on top of libnvdimm-for-next of the nvdimm tree.
> This is a temporary fix and please feel free to replace it with
> a better solution.

This looks correct to me, I'm going to fold it in to where the breakage occurs.

Thanks Toshi!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web