Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1214745 > unrolled thread
| Started by | Bjorn Andersson <bjorn.andersson@sonymobile.com> |
|---|---|
| First post | 2015-08-27 19:50 +0200 |
| Last post | 2015-08-28 01:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] backlight: lp855x: Make sure props struct is zeroed Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-08-27 19:50 +0200
Re: [PATCH] backlight: lp855x: Make sure props struct is zeroed "Kim, Milo" <milo.kim@ti.com> - 2015-08-28 00:50 +0200
RE: [PATCH] backlight: lp855x: Make sure props struct is zeroed "Johansson, Werner" <Werner.Johansson@sonymobile.com> - 2015-08-28 01:00 +0200
| From | Bjorn Andersson <bjorn.andersson@sonymobile.com> |
|---|---|
| Date | 2015-08-27 19:50 +0200 |
| Subject | [PATCH] backlight: lp855x: Make sure props struct is zeroed |
| Message-ID | <q29tg-330-9@gated-at.bofh.it> |
From: Werner Johansson <werner.johansson@sonymobile.com> The driver occasionally got stuck in suspend mode or other strange states as those parts of the props struct were never initialized. Signed-off-by: Werner Johansson <werner.johansson@sonymobile.com> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> --- drivers/video/backlight/lp855x_bl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c index 88116b493f3b..0a7f88ce1ab0 100644 --- a/drivers/video/backlight/lp855x_bl.c +++ b/drivers/video/backlight/lp855x_bl.c @@ -282,6 +282,7 @@ static int lp855x_backlight_register(struct lp855x *lp) struct lp855x_platform_data *pdata = lp->pdata; const char *name = pdata->name ? : DEFAULT_BL_NAME; + memset(&props, 0, sizeof(props)); props.type = BACKLIGHT_PLATFORM; props.max_brightness = MAX_BRIGHTNESS; -- 1.8.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Kim, Milo" <milo.kim@ti.com> |
|---|---|
| Date | 2015-08-28 00:50 +0200 |
| Message-ID | <q2e9C-1mE-69@gated-at.bofh.it> |
| In reply to | #1214745 |
On 8/28/2015 2:41 AM, Bjorn Andersson wrote: > From: Werner Johansson <werner.johansson@sonymobile.com> > > The driver occasionally got stuck in suspend mode or other strange > states as those parts of the props struct were never initialized. Acked-by: Milo Kim <milo.kim@ti.com> Thanks for catching this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Johansson, Werner" <Werner.Johansson@sonymobile.com> |
|---|---|
| Date | 2015-08-28 01:00 +0200 |
| Message-ID | <q2ejf-1y1-15@gated-at.bofh.it> |
| In reply to | #1214976 |
> > From: Werner Johansson <werner.johansson@sonymobile.com> > > > > The driver occasionally got stuck in suspend mode or other strange > > states as those parts of the props struct were never initialized. > > Acked-by: Milo Kim <milo.kim@ti.com> > > Thanks for catching this. You're most welcome! These issues can be difficult to track down, the stack is unpredictable.. /wj -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web