Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1214579 > unrolled thread

[PATCH] tools lib traceeveent: Allow for negative numbers in print format

Back to article view | Back to linux.kernel

Contents

  [PATCH] tools lib traceeveent: Allow for negative numbers in print  format Steven Rostedt <rostedt@goodmis.org> - 2015-08-27 15:50 +0200
    Re: [PATCH] tools lib traceeveent: Allow for negative numbers in  print format Vlastimil Babka <vbabka@suse.cz> - 2015-08-27 16:00 +0200
      Re: [PATCH] tools lib traceeveent: Allow for negative numbers in  print format Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-27 16:20 +0200
    [tip:perf/core] tools lib traceeveent:   Allow for negative numbers in print format tip-bot for Steven Rostedt <tipbot@zytor.com> - 2015-08-31 10:40 +0200

#1214579 — [PATCH] tools lib traceeveent: Allow for negative numbers in print format

It was reported that "%-8s" does not parse well when used in the printk
format. The '-' is what is throwing it off. Allow that to be included.

Reported-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 tools/lib/traceevent/event-parse.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index cc25f059ab3d..3b01ae137d95 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -4754,6 +4754,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
 			case 'z':
 			case 'Z':
 			case '0' ... '9':
+			case '-':
 				goto cont_process;
 			case 'p':
 				if (pevent->long_size == 4)
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1214582 — Re: [PATCH] tools lib traceeveent: Allow for negative numbers in print format

On 08/27/2015 03:46 PM, Steven Rostedt wrote:
>
> It was reported that "%-8s" does not parse well when used in the printk
> format. The '-' is what is throwing it off. Allow that to be included.
>
> Reported-by: Vlastimil Babka <vbabka@suse.cz>

Reported-and-tested-by: Vlastimil Babka <vbabka@suse.cz>

Example before:
transhuge-stres-10730 [004]  5897.713989: mm_compaction_finished: node=0 
zone=>-<8s order=-2119871790 ret=

Example after:
transhuge-stres-4235  [000]   453.149280: mm_compaction_finished: node=0 
zone=ffffffff81815d7a order=9 ret=

(I will send patches to fix the string handling in the tracepoints so 
it's on par with in-kernel printing via trace_pipe:)

transhuge-stres-10921 [007] ...1  6307.140205: mm_compaction_finished: 
node=0 zone=Normal   order=9 ret=partial

> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> ---
>   tools/lib/traceevent/event-parse.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index cc25f059ab3d..3b01ae137d95 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -4754,6 +4754,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
>   			case 'z':
>   			case 'Z':
>   			case '0' ... '9':
> +			case '-':
>   				goto cont_process;
>   			case 'p':
>   				if (pevent->long_size == 4)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1214599 — Re: [PATCH] tools lib traceeveent: Allow for negative numbers in print format

Em Thu, Aug 27, 2015 at 03:55:56PM +0200, Vlastimil Babka escreveu:
> On 08/27/2015 03:46 PM, Steven Rostedt wrote:
> >
> >It was reported that "%-8s" does not parse well when used in the printk
> >format. The '-' is what is throwing it off. Allow that to be included.
> >
> >Reported-by: Vlastimil Babka <vbabka@suse.cz>
> 
> Reported-and-tested-by: Vlastimil Babka <vbabka@suse.cz>
> 
> Example before:
> transhuge-stres-10730 [004]  5897.713989: mm_compaction_finished: node=0
> zone=>-<8s order=-2119871790 ret=
> 
> Example after:
> transhuge-stres-4235  [000]   453.149280: mm_compaction_finished: node=0
> zone=ffffffff81815d7a order=9 ret=
> 
> (I will send patches to fix the string handling in the tracepoints so it's
> on par with in-kernel printing via trace_pipe:)
> 
> transhuge-stres-10921 [007] ...1  6307.140205: mm_compaction_finished:
> node=0 zone=Normal   order=9 ret=partial

Thanks, applied and added the before/after reporter notes. It is now in
my perf/core branch.

- Arnaldo
 
> >Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> >---
> >  tools/lib/traceevent/event-parse.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> >diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> >index cc25f059ab3d..3b01ae137d95 100644
> >--- a/tools/lib/traceevent/event-parse.c
> >+++ b/tools/lib/traceevent/event-parse.c
> >@@ -4754,6 +4754,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
> >  			case 'z':
> >  			case 'Z':
> >  			case '0' ... '9':
> >+			case '-':
> >  				goto cont_process;
> >  			case 'p':
> >  				if (pevent->long_size == 4)
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1216098 — [tip:perf/core] tools lib traceeveent: Allow for negative numbers in print format

Commit-ID:  1d945012d1381f0232ea2d66e32b06182eedb476
Gitweb:     http://git.kernel.org/tip/1d945012d1381f0232ea2d66e32b06182eedb476
Author:     Steven Rostedt <rostedt@goodmis.org>
AuthorDate: Thu, 27 Aug 2015 09:46:01 -0400
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 28 Aug 2015 11:47:40 -0300

tools lib traceeveent: Allow for negative numbers in print format

It was reported that "%-8s" does not parse well when used in the printk
format. The '-' is what is throwing it off. Allow that to be included.

Reporter note:

Example before:

  transhuge-stres-10730 [004]  5897.713989: mm_compaction_finished: node=0
  zone=>-<8s order=-2119871790 ret=

Example after:

  transhuge-stres-4235  [000]   453.149280: mm_compaction_finished: node=0
  zone=ffffffff81815d7a order=9 ret=

(I will send patches to fix the string handling in the tracepoints so
it's on par with in-kernel printing via trace_pipe:)

  transhuge-stres-10921 [007] ...1  6307.140205: mm_compaction_finished: node=0
  zone=Normal   order=9 ret=partial

Reported-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Tested-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/20150827094601.46518bcc@gandalf.local.home
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/lib/traceevent/event-parse.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 5c1867a..4d88593 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -4828,6 +4828,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
 			case 'z':
 			case 'Z':
 			case '0' ... '9':
+			case '-':
 				goto cont_process;
 			case 'p':
 				if (pevent->long_size == 4)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web