Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1210236 > unrolled thread

Re: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus driver Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-20 09:40 +0200
    RE: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus driver Jose Rivera <German.Rivera@freescale.com> - 2015-08-25 21:10 +0200

#1210236 — Re: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus driver

On Wed, Aug 19, 2015 at 11:52:40AM -0500, J. German Rivera wrote:
> Since signatures of flib functions have changed, we had to
> change all the corresponding calls in the MC bus driver
> 

What does upgrade mean here?  I feel like this is the kind of patch we
reject without reading the patch because the description is too vague
and you can tell from the diff stats that it is going to be too huge to
review.

I looked at the first few lines and we are making a ball of changes.
Copyright notices, adding function parameters, renaming functions.  This
needs to be explained a lot better and probably split into multiple
patches.

Btw, the trees are closed for the next 3-4 weeks until after 4.3-rc2 is
released.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1213253

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Thursday, August 20, 2015 2:35 AM
> To: Rivera Jose-B46482
> Cc: gregkh@linuxfoundation.org; arnd@arndb.de;
> devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Yoder Stuart-
> B08248; katz Itai-RM05202; Wood Scott-B07421; agraf@suse.de; Hamciuc
> Bogdan-BHAMCIU1; Marginean Alexandru-R89243; Sharma Bhupesh-B45370; Erez
> Nir-RM30794; Schmitt Richard-B43082
> Subject: Re: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus
> driver
> 
> On Wed, Aug 19, 2015 at 11:52:40AM -0500, J. German Rivera wrote:
> > Since signatures of flib functions have changed, we had to change all
> > the corresponding calls in the MC bus driver
> >
> 
> What does upgrade mean here?  I feel like this is the kind of patch we
> reject without reading the patch because the description is too vague and
> you can tell from the diff stats that it is going to be too huge to
> review.
We will do some refactoring to make this easier to review.

Thanks,

german
> 
> I looked at the first few lines and we are making a ball of changes.
> Copyright notices, adding function parameters, renaming functions.  This
> needs to be explained a lot better and probably split into multiple
> patches.
> 
> Btw, the trees are closed for the next 3-4 weeks until after 4.3-rc2 is
> released.
> 
> regards,
> dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web