Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1212802 > unrolled thread

Re: [PATCH v3 3/10] x86/asm: Fix pud/pmd interfaces to handle large PAT bit

Started byThomas Gleixner <tglx@linutronix.de>
First post2015-08-25 10:20 +0200
Last post2015-08-25 16:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v3 3/10] x86/asm: Fix pud/pmd interfaces to handle large  PAT bit Thomas Gleixner <tglx@linutronix.de> - 2015-08-25 10:20 +0200
    Re: [PATCH v3 3/10] x86/asm: Fix pud/pmd interfaces to handle large  PAT bit Toshi Kani <toshi.kani@hp.com> - 2015-08-25 16:20 +0200

#1212802 — Re: [PATCH v3 3/10] x86/asm: Fix pud/pmd interfaces to handle large PAT bit

FromThomas Gleixner <tglx@linutronix.de>
Date2015-08-25 10:20 +0200
SubjectRe: [PATCH v3 3/10] x86/asm: Fix pud/pmd interfaces to handle large PAT bit
Message-ID<q1hCz-P0-43@gated-at.bofh.it>
On Wed, 5 Aug 2015, Toshi Kani wrote:

> The PAT bit gets relocated to bit 12 when PUD and PMD mappings are
> used.  This bit 12, however, is not covered by PTE_FLAGS_MASK, which
> is corrently used for masking pfn and flags for all cases.
> 
> Fix pud/pmd interfaces to handle pfn and flags properly by using
> P?D_PAGE_MASK when PUD/PMD mappings are used, i.e. PSE bit is set.

Can you please split that into a patch introducing and describing the
new mask helper functions and a second one making use of it?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1213064

FromToshi Kani <toshi.kani@hp.com>
Date2015-08-25 16:20 +0200
Message-ID<q1neW-rx-21@gated-at.bofh.it>
In reply to#1212802
On Tue, 2015-08-25 at 10:16 +0200, Thomas Gleixner wrote:
> On Wed, 5 Aug 2015, Toshi Kani wrote:
> 
> > The PAT bit gets relocated to bit 12 when PUD and PMD mappings are
> > used.  This bit 12, however, is not covered by PTE_FLAGS_MASK, which
> > is corrently used for masking pfn and flags for all cases.
> > 
> > Fix pud/pmd interfaces to handle pfn and flags properly by using
> > P?D_PAGE_MASK when PUD/PMD mappings are used, i.e. PSE bit is set.
> 
> Can you please split that into a patch introducing and describing the
> new mask helper functions and a second one making use of it?

Will do.  I will send out v4 patchset today with this update (and the patch
01 update). 

Thanks,
-Toshi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web