Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1212643 > unrolled thread

Re: [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver

Started byPi-Cheng Chen <pi-cheng.chen@linaro.org>
First post2015-08-25 04:20 +0200
Last post2015-09-02 19:30 +0200
Articles 8 — 5 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver Pi-Cheng Chen <pi-cheng.chen@linaro.org> - 2015-08-25 04:20 +0200
    Re: [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-08-26 00:40 +0200
      Re: [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver Pi-Cheng Chen <pi-cheng.chen@linaro.org> - 2015-08-26 03:30 +0200
        Re: [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-26 04:20 +0200
          Re: [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver Pi-Cheng Chen <pi-cheng.chen@linaro.org> - 2015-08-26 09:00 +0200
            Re: [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-08-28 15:40 +0200
              Re: [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver Daniel Kurtz <djkurtz@chromium.org> - 2015-09-02 08:50 +0200
                Re: [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver Matthias Brugger <matthias.bgg@gmail.com> - 2015-09-02 19:30 +0200

#1212643 — Re: [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver

FromPi-Cheng Chen <pi-cheng.chen@linaro.org>
Date2015-08-25 04:20 +0200
SubjectRe: [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver
Message-ID<q1c09-1i6-9@gated-at.bofh.it>
On Mon, Aug 17, 2015 at 5:24 PM, Pi-Cheng Chen <pi-cheng.chen@linaro.org> wrote:
> MT8173 is a ARMv8 based SoC with 2 clusters. All CPUs in a single cluster
> share the same power and clock domain. This series tries to add cpufreq support
> for MT8173 SoC. The v6 of this series is resent with Acks added.

Hi Rafael,

Not sure if I has missed the merge window.
Do I have chance to have this series merged for 4.3?
Would you please take [1,2] of this series?
Thanks.

Best Regards,
Pi-Cheng

>
> changes in v6:
> - Move clock and regulator consumer properties document to the device tree
>   bindings documents of MT8173 CPU DVFS clock driver
> - Add change log to describe what is implemented in the MT8173 cpufreq driver
> - Add missed rcu_read_unlock() in the error path
> - Move of_init_opp_table() call to make sure all required hardware resources
>   are already there before it is called
> - Add comments to describe why both platform driver and deivce registration
>   codes are put in the initcall function
> - Use the term "voltage tracking" instead of "voltage trace" according to an
>   internal SoC document
>
> changes in v5:
> - Move resource allocation code from init() into probe() and remove some unused
>   functions due to this change
> - Fix descriptions for device tree binding document
> - Address review comments for last version
> - Register CPU cooling device
>
> Changes in v4:
> - Add bindings for MT8173 cpufreq driver
> - Move OPP table back into device tree
> - Address comments for last version
>
> Changes in v3:
> - Implement MT8173 specific standalone cpufreq driver instead of using
>   cpufreq-dt driver
> - Define OPP table in the driver source code until new OPP binding is ready
>
> Changes in v2:
> - Add intermediate frequency support in cpufreq-dt driver
> - Use voltage scaling code of cpufreq-dt for little cluster instead of
>   implementaion in notifier of mtk-cpufreq driver
> - Code refinement for mtk-cpufreq driver
>
> Pi-Cheng Chen (3):
>   dt-bindings: mediatek: Add MT8173 CPU DVFS clock bindings
>   cpufreq: mediatek: Add MT8173 cpufreq driver
>   arm64: dts: mt8173: Add mt8173 cpufreq driver support
>
>  .../devicetree/bindings/clock/mt8173-cpu-dvfs.txt  |  83 ++++
>  arch/arm64/boot/dts/mediatek/mt8173-evb.dts        |  18 +
>  arch/arm64/boot/dts/mediatek/mt8173.dtsi           |  64 +++
>  drivers/cpufreq/Kconfig.arm                        |   7 +
>  drivers/cpufreq/Makefile                           |   1 +
>  drivers/cpufreq/mt8173-cpufreq.c                   | 524 +++++++++++++++++++++
>  6 files changed, 697 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/mt8173-cpu-dvfs.txt
>  create mode 100644 drivers/cpufreq/mt8173-cpufreq.c
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1213411

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2015-08-26 00:40 +0200
Message-ID<q1v2O-3BX-7@gated-at.bofh.it>
In reply to#1212643
On Tuesday, August 25, 2015 10:10:44 AM Pi-Cheng Chen wrote:
> On Mon, Aug 17, 2015 at 5:24 PM, Pi-Cheng Chen <pi-cheng.chen@linaro.org> wrote:
> > MT8173 is a ARMv8 based SoC with 2 clusters. All CPUs in a single cluster
> > share the same power and clock domain. This series tries to add cpufreq support
> > for MT8173 SoC. The v6 of this series is resent with Acks added.
> 
> Hi Rafael,
> 
> Not sure if I has missed the merge window.
> Do I have chance to have this series merged for 4.3?

Yes, it should make it.

> Would you please take [1,2] of this series?

I'm not sure what you mean.  Are you withdrawing the [3/3]?

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1213472

FromPi-Cheng Chen <pi-cheng.chen@linaro.org>
Date2015-08-26 03:30 +0200
Message-ID<q1xHj-7wd-3@gated-at.bofh.it>
In reply to#1213411
Hi Rafael,

On Wed, Aug 26, 2015 at 7:01 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Tuesday, August 25, 2015 10:10:44 AM Pi-Cheng Chen wrote:
>> On Mon, Aug 17, 2015 at 5:24 PM, Pi-Cheng Chen <pi-cheng.chen@linaro.org> wrote:
>> > MT8173 is a ARMv8 based SoC with 2 clusters. All CPUs in a single cluster
>> > share the same power and clock domain. This series tries to add cpufreq support
>> > for MT8173 SoC. The v6 of this series is resent with Acks added.
>>
>> Hi Rafael,
>>
>> Not sure if I has missed the merge window.
>> Do I have chance to have this series merged for 4.3?
>
> Yes, it should make it.
>
>> Would you please take [1,2] of this series?

Thanks.

>
> I'm not sure what you mean.  Are you withdrawing the [3/3]?

The [3/3] is based on Mediatek SoC maintainer tree[1] and the patch which
introduce a new clock type[2] consumed by MT8173 cpufreq driver. So it will
cause some conflicts if it goes through your tree. I am not sure how this
should be handled, but should it be merged through Mediatek SoC maintainer
tree?

@Matthias?

Thanks

Best Regards,
Pi-Cheng

[1] https://github.com/mbgg/linux-mediatek.git v4.2-next/arm64
[2] http://article.gmane.org/gmane.linux.kernel/2021379

>
> Thanks,
> Rafael
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1213499

FromViresh Kumar <viresh.kumar@linaro.org>
Date2015-08-26 04:20 +0200
Message-ID<q1ytI-pJ-3@gated-at.bofh.it>
In reply to#1213472
On 26-08-15, 09:25, Pi-Cheng Chen wrote:
> The [3/3] is based on Mediatek SoC maintainer tree[1] and the patch which
> introduce a new clock type[2] consumed by MT8173 cpufreq driver. So it will
> cause some conflicts if it goes through your tree. I am not sure how this
> should be handled, but should it be merged through Mediatek SoC maintainer
> tree?

Just get that applied to MTK tree, it doesn't have any dependency on
rest of the patches for build/boot. The only thing is that cpufreq
wouldn't work and it will work as soon as Rafael's and MTK's trees are
merged by Linus.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1213584

FromPi-Cheng Chen <pi-cheng.chen@linaro.org>
Date2015-08-26 09:00 +0200
Message-ID<q1CQG-6AJ-1@gated-at.bofh.it>
In reply to#1213499
On Wed, Aug 26, 2015 at 10:16 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 26-08-15, 09:25, Pi-Cheng Chen wrote:
>> The [3/3] is based on Mediatek SoC maintainer tree[1] and the patch which
>> introduce a new clock type[2] consumed by MT8173 cpufreq driver. So it will
>> cause some conflicts if it goes through your tree. I am not sure how this
>> should be handled, but should it be merged through Mediatek SoC maintainer
>> tree?
>
> Just get that applied to MTK tree, it doesn't have any dependency on
> rest of the patches for build/boot. The only thing is that cpufreq
> wouldn't work and it will work as soon as Rafael's and MTK's trees are
> merged by Linus.

Thanks for your explanation.

@Rafael, Would you please apply [1,2] to your tree?

@Matthias, Would you please apply [3/3] of this series?

Thanks.

Best Regards,
Pi-Cheng

>
> --
> viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1215340

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2015-08-28 15:40 +0200
Message-ID<q2s2U-4H9-37@gated-at.bofh.it>
In reply to#1213584
On Wednesday, August 26, 2015 02:53:39 PM Pi-Cheng Chen wrote:
> On Wed, Aug 26, 2015 at 10:16 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On 26-08-15, 09:25, Pi-Cheng Chen wrote:
> >> The [3/3] is based on Mediatek SoC maintainer tree[1] and the patch which
> >> introduce a new clock type[2] consumed by MT8173 cpufreq driver. So it will
> >> cause some conflicts if it goes through your tree. I am not sure how this
> >> should be handled, but should it be merged through Mediatek SoC maintainer
> >> tree?
> >
> > Just get that applied to MTK tree, it doesn't have any dependency on
> > rest of the patches for build/boot. The only thing is that cpufreq
> > wouldn't work and it will work as soon as Rafael's and MTK's trees are
> > merged by Linus.
> 
> Thanks for your explanation.
> 
> @Rafael, Would you please apply [1,2] to your tree?

Applied, thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1217351

FromDaniel Kurtz <djkurtz@chromium.org>
Date2015-09-02 08:50 +0200
Message-ID<q4a1Q-5IM-7@gated-at.bofh.it>
In reply to#1215340
Matthias,

On Fri, Aug 28, 2015 at 10:06 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Wednesday, August 26, 2015 02:53:39 PM Pi-Cheng Chen wrote:
>> On Wed, Aug 26, 2015 at 10:16 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> > On 26-08-15, 09:25, Pi-Cheng Chen wrote:
>> >> The [3/3] is based on Mediatek SoC maintainer tree[1] and the patch which
>> >> introduce a new clock type[2] consumed by MT8173 cpufreq driver. So it will
>> >> cause some conflicts if it goes through your tree. I am not sure how this
>> >> should be handled, but should it be merged through Mediatek SoC maintainer
>> >> tree?
>> >
>> > Just get that applied to MTK tree, it doesn't have any dependency on
>> > rest of the patches for build/boot. The only thing is that cpufreq
>> > wouldn't work and it will work as soon as Rafael's and MTK's trees are
>> > merged by Linus.
>>
>> Thanks for your explanation.
>>
>> @Rafael, Would you please apply [1,2] to your tree?
>
> Applied, thanks!

Can you please apply [3] from this set to your dts tree?

> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1217769

FromMatthias Brugger <matthias.bgg@gmail.com>
Date2015-09-02 19:30 +0200
Message-ID<q4k1c-3eF-19@gated-at.bofh.it>
In reply to#1217351

On 02/09/15 08:45, Daniel Kurtz wrote:
> Matthias,
>
> On Fri, Aug 28, 2015 at 10:06 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>> On Wednesday, August 26, 2015 02:53:39 PM Pi-Cheng Chen wrote:
>>> On Wed, Aug 26, 2015 at 10:16 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>>>> On 26-08-15, 09:25, Pi-Cheng Chen wrote:
>>>>> The [3/3] is based on Mediatek SoC maintainer tree[1] and the patch which
>>>>> introduce a new clock type[2] consumed by MT8173 cpufreq driver. So it will
>>>>> cause some conflicts if it goes through your tree. I am not sure how this
>>>>> should be handled, but should it be merged through Mediatek SoC maintainer
>>>>> tree?
>>>>
>>>> Just get that applied to MTK tree, it doesn't have any dependency on
>>>> rest of the patches for build/boot. The only thing is that cpufreq
>>>> wouldn't work and it will work as soon as Rafael's and MTK's trees are
>>>> merged by Linus.
>>>
>>> Thanks for your explanation.
>>>
>>> @Rafael, Would you please apply [1,2] to your tree?
>>
>> Applied, thanks!
>
> Can you please apply [3] from this set to your dts tree?
>

I will as soon as v4.3-rc1 shows up.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web