Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1213704 > unrolled thread

Re: [PATCH 1/3] serial: 8250: move rx_running out of the bitfield

Started bySekhar Nori <nsekhar@ti.com>
First post2015-08-26 11:40 +0200
Last post2015-08-26 15:00 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 1/3] serial: 8250: move rx_running out of the bitfield Sekhar Nori <nsekhar@ti.com> - 2015-08-26 11:40 +0200
    Re: [PATCH 1/3] serial: 8250: move rx_running out of the bitfield Peter Hurley <peter@hurleysoftware.com> - 2015-08-26 14:50 +0200
      Re: [PATCH 1/3] serial: 8250: move rx_running out of the bitfield Sekhar Nori <nsekhar@ti.com> - 2015-08-26 15:00 +0200

#1213704 — Re: [PATCH 1/3] serial: 8250: move rx_running out of the bitfield

FromSekhar Nori <nsekhar@ti.com>
Date2015-08-26 11:40 +0200
SubjectRe: [PATCH 1/3] serial: 8250: move rx_running out of the bitfield
Message-ID<q1Flw-1N4-19@gated-at.bofh.it>
On Friday 14 August 2015 09:31 PM, Sebastian Andrzej Siewior wrote:
> From: John Ogness <john.ogness@linutronix.de>
> 
> That bitfield is modified by read + or + write operation. If someone
> sets any of the other two bits it might render the lock useless.
> 
> While at it, remove other bitfields as well to avoid more such
> errors.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Tested with wilink BT module on TI's DRA7 EVM.

Tested-by: Sekhar Nori <nsekhar@ti.com>

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1213820

FromPeter Hurley <peter@hurleysoftware.com>
Date2015-08-26 14:50 +0200
Message-ID<q1Ijo-602-17@gated-at.bofh.it>
In reply to#1213704
On 08/26/2015 05:37 AM, Sekhar Nori wrote:
> On Friday 14 August 2015 09:31 PM, Sebastian Andrzej Siewior wrote:
>> From: John Ogness <john.ogness@linutronix.de>
>>
>> That bitfield is modified by read + or + write operation. If someone
>> sets any of the other two bits it might render the lock useless.
>>
>> While at it, remove other bitfields as well to avoid more such
>> errors.
>>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Signed-off-by: John Ogness <john.ogness@linutronix.de>
>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> 
> Tested with wilink BT module on TI's DRA7 EVM.
> 
> Tested-by: Sekhar Nori <nsekhar@ti.com>

Already in Greg's tty-next tree (and 4.3-rc1 pull request), Sekhar.

Regards,
Peter Hurley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1213832

FromSekhar Nori <nsekhar@ti.com>
Date2015-08-26 15:00 +0200
Message-ID<q1It4-6bl-9@gated-at.bofh.it>
In reply to#1213820
On Wednesday 26 August 2015 06:13 PM, Peter Hurley wrote:
> On 08/26/2015 05:37 AM, Sekhar Nori wrote:
>> On Friday 14 August 2015 09:31 PM, Sebastian Andrzej Siewior wrote:
>>> From: John Ogness <john.ogness@linutronix.de>
>>>
>>> That bitfield is modified by read + or + write operation. If someone
>>> sets any of the other two bits it might render the lock useless.
>>>
>>> While at it, remove other bitfields as well to avoid more such
>>> errors.
>>>
>>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> Signed-off-by: John Ogness <john.ogness@linutronix.de>
>>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>>
>> Tested with wilink BT module on TI's DRA7 EVM.
>>
>> Tested-by: Sekhar Nori <nsekhar@ti.com>
> 
> Already in Greg's tty-next tree (and 4.3-rc1 pull request), Sekhar.

Oops, no problem. Did not notice that.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web