Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1212336 > unrolled thread

Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks]

Started byLaura Abbott <labbott@redhat.com>
First post2015-08-24 18:30 +0200
Last post2015-08-25 04:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA  leaks] Laura Abbott <labbott@redhat.com> - 2015-08-24 18:30 +0200
    RE: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA  leaks] Chen Bough <Haibo.Chen@freescale.com> - 2015-08-25 04:00 +0200

#1212336 — Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks]

FromLaura Abbott <labbott@redhat.com>
Date2015-08-24 18:30 +0200
SubjectRe: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands) DMA leaks]
Message-ID<q12Nc-4yM-21@gated-at.bofh.it>
On 08/06/2015 02:17 AM, Chen Bough wrote:
> I will format a patch based on your diff file firstly. I will test this on my side,
> If any issue, like dma issue or performance issue, I will add some modification.
> Then I will send the patch for review, and you can test the patch on your platform.
>
> Best Regards
> Haibo Chen
>

Did I miss the follow up patch or is this still pending? If it's still pending,
would you mind Ccing me when it's available for testing?

Thanks,
Laura
  
>
>> -----Original Message-----
>> From: Jiri Slaby [mailto:jslaby@suse.cz]
>> Sent: Thursday, August 06, 2015 5:07 PM
>> To: Chen Haibo-B51421; Ulf Hansson
>> Cc: linux-mmc@vger.kernel.org; Linux kernel mailing list
>> Subject: Re: [RFC] sdhci: fix DMA leaks [was: [SHDCI] Heavy (thousands)
>> DMA leaks]
>>
>> On 08/06/2015, 09:42 AM, Chen Bough wrote:
>>> I read your attached log and patch, yes, dma memory leak will happen
>>> when more than one pre_request execute. The method of ++next->cookie
>>> is not good, your patch seems good, but I still need some time to test
>>> the patch, because you unmap the dma in sdhci_finish_data rather than
>> the sdhci_post_req.
>>
>> Hi,
>>
>> yes, this is not correct. We can perhaps differentiate according to the
>> COOKIE value. Should I fix it or are you going to prepare a patch based
>> on my RFC?
>>
>> thanks,
>> --
>> js
>> suse labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1212636

FromChen Bough <Haibo.Chen@freescale.com>
Date2015-08-25 04:00 +0200
Message-ID<q1bGO-zW-11@gated-at.bofh.it>
In reply to#1212336
SGkgTGF1cmEsDQoNCllvdSBjYW4gZmluZCB0aGUgcGF0Y2ggaGVyZToNCmh0dHA6Ly9wYXRjaHdv
cmsua2VybmVybC54eXovcGF0Y2gvNjk2NzE2MS8NCg0KSSB3aWxsIHNlbmQgdGhpcyBwYXRjaCBh
Z2FpbiBhbmQgY2MgdG8geW91Lg0KDQoNCkJlc3QgcmVnYXJkcw0KDQpIYWlibw0KDQoNCg0KPiAt
LS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBMYXVyYSBBYmJvdHQgW21haWx0bzps
YWJib3R0QHJlZGhhdC5jb21dDQo+IFNlbnQ6IFR1ZXNkYXksIEF1Z3VzdCAyNSwgMjAxNSAxMjoy
NyBBTQ0KPiBUbzogQ2hlbiBIYWliby1CNTE0MjE7IEppcmkgU2xhYnk7IFVsZiBIYW5zc29uDQo+
IENjOiBsaW51eC1tbWNAdmdlci5rZXJuZWwub3JnOyBMaW51eCBrZXJuZWwgbWFpbGluZyBsaXN0
DQo+IFN1YmplY3Q6IFJlOiBbUkZDXSBzZGhjaTogZml4IERNQSBsZWFrcyBbd2FzOiBbU0hEQ0ld
IEhlYXZ5ICh0aG91c2FuZHMpDQo+IERNQSBsZWFrc10NCj4gDQo+IE9uIDA4LzA2LzIwMTUgMDI6
MTcgQU0sIENoZW4gQm91Z2ggd3JvdGU6DQo+ID4gSSB3aWxsIGZvcm1hdCBhIHBhdGNoIGJhc2Vk
IG9uIHlvdXIgZGlmZiBmaWxlIGZpcnN0bHkuIEkgd2lsbCB0ZXN0DQo+ID4gdGhpcyBvbiBteSBz
aWRlLCBJZiBhbnkgaXNzdWUsIGxpa2UgZG1hIGlzc3VlIG9yIHBlcmZvcm1hbmNlIGlzc3VlLCBJ
DQo+IHdpbGwgYWRkIHNvbWUgbW9kaWZpY2F0aW9uLg0KPiA+IFRoZW4gSSB3aWxsIHNlbmQgdGhl
IHBhdGNoIGZvciByZXZpZXcsIGFuZCB5b3UgY2FuIHRlc3QgdGhlIHBhdGNoIG9uDQo+IHlvdXIg
cGxhdGZvcm0uDQo+ID4NCj4gPiBCZXN0IFJlZ2FyZHMNCj4gPiBIYWlibyBDaGVuDQo+ID4NCj4g
DQo+IERpZCBJIG1pc3MgdGhlIGZvbGxvdyB1cCBwYXRjaCBvciBpcyB0aGlzIHN0aWxsIHBlbmRp
bmc/IElmIGl0J3Mgc3RpbGwNCj4gcGVuZGluZywgd291bGQgeW91IG1pbmQgQ2NpbmcgbWUgd2hl
biBpdCdzIGF2YWlsYWJsZSBmb3IgdGVzdGluZz8NCj4gDQo+IFRoYW5rcywNCj4gTGF1cmENCj4g
DQo+ID4NCj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogSmlyaSBT
bGFieSBbbWFpbHRvOmpzbGFieUBzdXNlLmN6XQ0KPiA+PiBTZW50OiBUaHVyc2RheSwgQXVndXN0
IDA2LCAyMDE1IDU6MDcgUE0NCj4gPj4gVG86IENoZW4gSGFpYm8tQjUxNDIxOyBVbGYgSGFuc3Nv
bg0KPiA+PiBDYzogbGludXgtbW1jQHZnZXIua2VybmVsLm9yZzsgTGludXgga2VybmVsIG1haWxp
bmcgbGlzdA0KPiA+PiBTdWJqZWN0OiBSZTogW1JGQ10gc2RoY2k6IGZpeCBETUEgbGVha3MgW3dh
czogW1NIRENJXSBIZWF2eQ0KPiA+PiAodGhvdXNhbmRzKSBETUEgbGVha3NdDQo+ID4+DQo+ID4+
IE9uIDA4LzA2LzIwMTUsIDA5OjQyIEFNLCBDaGVuIEJvdWdoIHdyb3RlOg0KPiA+Pj4gSSByZWFk
IHlvdXIgYXR0YWNoZWQgbG9nIGFuZCBwYXRjaCwgeWVzLCBkbWEgbWVtb3J5IGxlYWsgd2lsbCBo
YXBwZW4NCj4gPj4+IHdoZW4gbW9yZSB0aGFuIG9uZSBwcmVfcmVxdWVzdCBleGVjdXRlLiBUaGUg
bWV0aG9kIG9mICsrbmV4dC0+Y29va2llDQo+ID4+PiBpcyBub3QgZ29vZCwgeW91ciBwYXRjaCBz
ZWVtcyBnb29kLCBidXQgSSBzdGlsbCBuZWVkIHNvbWUgdGltZSB0bw0KPiA+Pj4gdGVzdCB0aGUg
cGF0Y2gsIGJlY2F1c2UgeW91IHVubWFwIHRoZSBkbWEgaW4gc2RoY2lfZmluaXNoX2RhdGENCj4g
Pj4+IHJhdGhlciB0aGFuDQo+ID4+IHRoZSBzZGhjaV9wb3N0X3JlcS4NCj4gPj4NCj4gPj4gSGks
DQo+ID4+DQo+ID4+IHllcywgdGhpcyBpcyBub3QgY29ycmVjdC4gV2UgY2FuIHBlcmhhcHMgZGlm
ZmVyZW50aWF0ZSBhY2NvcmRpbmcgdG8NCj4gPj4gdGhlIENPT0tJRSB2YWx1ZS4gU2hvdWxkIEkg
Zml4IGl0IG9yIGFyZSB5b3UgZ29pbmcgdG8gcHJlcGFyZSBhIHBhdGNoDQo+ID4+IGJhc2VkIG9u
IG15IFJGQz8NCj4gPj4NCj4gPj4gdGhhbmtzLA0KPiA+PiAtLQ0KPiA+PiBqcw0KPiA+PiBzdXNl
IGxhYnMNCg0K
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web