Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1212297 > unrolled thread

Re: [PATCHv3 1/5] mm: drop page->slab_page

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCHv3 1/5] mm: drop page->slab_page Vlastimil Babka <vbabka@suse.cz> - 2015-08-24 17:10 +0200
    Re: [PATCHv3 1/5] mm: drop page->slab_page "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-08-25 19:30 +0200

#1212297 — Re: [PATCHv3 1/5] mm: drop page->slab_page

On 08/19/2015 11:21 AM, Kirill A. Shutemov wrote:
> Since 8456a648cf44 ("slab: use struct page for slab management") nobody
> uses slab_page field in struct page.
>
> Let's drop it.

Ah, how about dropping this comment in mm/slab.c:slab_destroy() as well?

                 /*
                  * RCU free overloads the RCU head over the LRU.
                  * slab_page has been overloeaded over the LRU,
                  * however it is not used from now on so that
                  * we can use it safely.
                  */


> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Acked-by: Christoph Lameter <cl@linux.com>
> Acked-by: David Rientjes <rientjes@google.com>
> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Cc: Andi Kleen <ak@linux.intel.com>
> ---
>   include/linux/mm_types.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> index 0038ac7466fd..58620ac7f15c 100644
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -140,7 +140,6 @@ struct page {
>   #endif
>   		};
>
> -		struct slab *slab_page; /* slab fields */
>   		struct rcu_head rcu_head;	/* Used by SLAB
>   						 * when destroying via RCU
>   						 */
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1213198

On Mon, Aug 24, 2015 at 05:02:16PM +0200, Vlastimil Babka wrote:
> On 08/19/2015 11:21 AM, Kirill A. Shutemov wrote:
> >Since 8456a648cf44 ("slab: use struct page for slab management") nobody
> >uses slab_page field in struct page.
> >
> >Let's drop it.
> 
> Ah, how about dropping this comment in mm/slab.c:slab_destroy() as well?
> 
>                 /*
>                  * RCU free overloads the RCU head over the LRU.
>                  * slab_page has been overloeaded over the LRU,
>                  * however it is not used from now on so that
>                  * we can use it safely.
>                  */

Actually, whole block can be replaced by

	call_rcu(&page->rcu_head, kmem_rcu_free);

Thanks.

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web