Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1210095 > unrolled thread

Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() Julien Grall <julien.grall@citrix.com> - 2015-08-20 02:30 +0200
    Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page() Murilo Opsfelder Araújo <mopsfelder@gmail.com> - 2015-08-22 17:00 +0200

#1210095 — Re: [PATCH] xen/tmem: Pass page instead of pfn to xen_tmem_get_page()

Hi,

On 19/08/2015 06:25, Murilo Opsfelder Araujo wrote:
> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
> xen_tmem_get_page() receiving pfn instead of page.
>
> This change also fixes the following build warning:
>
> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
> drivers/xen/tmem.c:194:47: warning: passing argument 4 of ‘xen_tmem_get_page’ makes pointer from integer without a cast
>    ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
>                                                 ^
> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is of type ‘long unsigned int’
>   static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
>              ^
>
> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>

Sorry for the breakage, I haven't spot it because CONFIG_CLEANCACHE is 
not enabled on my config.

Reviewed-by: Julien Grall <julien.grall@citrix.com>

Regards,

-- 
Julien Grall
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1211477

On Wed, Aug 19, 2015 at 9:23 PM, Julien Grall <julien.grall@citrix.com> wrote:
> Hi,
>
> On 19/08/2015 06:25, Murilo Opsfelder Araujo wrote:
>>
>> The commit 091208a676dfdabb2b8fe86ee155c6fc80081b69 "xen/tmem: Use
>> xen_page_to_gfn rather than pfn_to_gfn" left behind a call to
>> xen_tmem_get_page() receiving pfn instead of page.
>>
>> This change also fixes the following build warning:
>>
>> drivers/xen/tmem.c: In function ‘tmem_cleancache_get_page’:
>> drivers/xen/tmem.c:194:47: warning: passing argument 4 of
>> ‘xen_tmem_get_page’ makes pointer from integer without a cast
>>    ret = xen_tmem_get_page((u32)pool, oid, ind, pfn);
>>                                                 ^
>> drivers/xen/tmem.c:138:12: note: expected ‘struct page *’ but argument is
>> of type ‘long unsigned int’
>>   static int xen_tmem_get_page(u32 pool_id, struct tmem_oid oid,
>>              ^
>>
>> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
>
>
> Sorry for the breakage, I haven't spot it because CONFIG_CLEANCACHE is not
> enabled on my config.
>
> Reviewed-by: Julien Grall <julien.grall@citrix.com>
>
> Regards,
>
> --
> Julien Grall

Hi, Julien.

No need to apologize, and thanks for reviewing that.

-- 
Murilo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web