Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1211424 > unrolled thread

[PATCH 1/3] mm/page_alloc: fix a terrible misleading comment

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/3] mm/page_alloc: fix a terrible misleading comment Yaowei Bai <bywxiaobai@163.com> - 2015-08-22 10:00 +0200
    Re: [PATCH 1/3] mm/page_alloc: fix a terrible misleading comment Michal Hocko <mhocko@kernel.org> - 2015-08-24 12:50 +0200

#1211424 — [PATCH 1/3] mm/page_alloc: fix a terrible misleading comment

The comment says that the per-cpu batchsize and zone watermarks
are determined by present_pages which is definitely wrong, they
are both calculated from managed_pages. Fix it.

Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 5b5240b..c22b133 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6003,7 +6003,7 @@ void __init mem_init_print_info(const char *str)
  * set_dma_reserve - set the specified number of pages reserved in the first zone
  * @new_dma_reserve: The number of pages to mark reserved
  *
- * The per-cpu batchsize and zone watermarks are determined by present_pages.
+ * The per-cpu batchsize and zone watermarks are determined by managed_pages.
  * In the DMA zone, a significant percentage may be consumed by kernel image
  * and other unfreeable allocations which can skew the watermarks badly. This
  * function may optionally be used to account for unfreeable pages in the
-- 
1.9.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1212069

On Sat 22-08-15 15:40:10, Yaowei Bai wrote:
> The comment says that the per-cpu batchsize and zone watermarks
> are determined by present_pages which is definitely wrong, they
> are both calculated from managed_pages. Fix it.

This seems to be missed in b40da04946aa ("mm: use zone->present_pages
instead of zone->managed_pages where appropriate")
> 
> Signed-off-by: Yaowei Bai <bywxiaobai@163.com>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
>  mm/page_alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 5b5240b..c22b133 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6003,7 +6003,7 @@ void __init mem_init_print_info(const char *str)
>   * set_dma_reserve - set the specified number of pages reserved in the first zone
>   * @new_dma_reserve: The number of pages to mark reserved
>   *
> - * The per-cpu batchsize and zone watermarks are determined by present_pages.
> + * The per-cpu batchsize and zone watermarks are determined by managed_pages.
>   * In the DMA zone, a significant percentage may be consumed by kernel image
>   * and other unfreeable allocations which can skew the watermarks badly. This
>   * function may optionally be used to account for unfreeable pages in the
> -- 
> 1.9.1
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web