Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1212134 > unrolled thread
| Started by | Vaibhav Hiremath <vaibhav.hiremath@linaro.org> |
|---|---|
| First post | 2015-08-24 14:50 +0200 |
| Last post | 2015-08-27 20:50 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH-v3 0/2] regulator: 88pm800: Add dual phase mode support on BUCK1 Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-24 14:50 +0200
[PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-24 14:50 +0200
Re: [PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable Lee Jones <lee.jones@linaro.org> - 2015-08-24 15:10 +0200
Re: [PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-24 17:00 +0200
Re: [PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable Mark Brown <broonie@kernel.org> - 2015-08-27 20:50 +0200
| From | Vaibhav Hiremath <vaibhav.hiremath@linaro.org> |
|---|---|
| Date | 2015-08-24 14:50 +0200 |
| Subject | [PATCH-v3 0/2] regulator: 88pm800: Add dual phase mode support on BUCK1 |
| Message-ID | <q0Zmi-7YS-9@gated-at.bofh.it> |
88PM860 device supports dual phase mode on BUCK1 output.
In normal usecase, BUCK1A and BUCK1B operates independently with 3A
capacity. And they both can work as a dual phase providing 6A capacity.
This patch series is subset of earlier patch-series
Link to earlier series - https://lkml.org/lkml/2015/7/16/722
Except PATCH[5/5], all other patches in the series are accepted and
queued up for next merge window.
And based on discussion on the list, creating DT property to enable
dual-phase mode on BUCK1.
Testing:
- Tested on 88PM860 based platform
- Boot tested
- Tested with & without DT property being set
- Read register value before and after probe to make sure that
value has been set.
V2 => V3:
========
- Based on discussion on earlier patch-series,
(comments from Krzysztof Kozlowski)
Dynamically controlled current capacity and registration of BUCK1B,
in case of BUCK1 dual phase mode enabled.
Now, if BUCK1 dual phase is enabled, current capacity is set to 6A,
and, BUCK1B will not be registered to regulator framework.
V1 => V2:
========
- This is new patch-series, where, all accepted patches dropped.
Upgraded Patch version, to ease review.
- Based on Mark Brown's comment, we should use DT property of its own.
using set_current_limit() is not right way here.
So, created DT property for Dual phase mode enable.
- Updated binding for new DT property
Vaibhav Hiremath (2):
mfd: devicetree: bindings: 88pm800: Add DT property for dual phase
enable
regulator: 88pm800: Add support for configuration of dual phase on
BUCK1
Documentation/devicetree/bindings/mfd/88pm800.txt | 6 ++++
drivers/regulator/88pm800.c | 40 +++++++++++++++++++++++
include/linux/mfd/88pm80x.h | 3 ++
3 files changed, 49 insertions(+)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Vaibhav Hiremath <vaibhav.hiremath@linaro.org> |
|---|---|
| Date | 2015-08-24 14:50 +0200 |
| Subject | [PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable |
| Message-ID | <q0Zmj-7YS-13@gated-at.bofh.it> |
| In reply to | #1212134 |
88PM860 family of device supports dual phase mode on BUCK1 supply providing total 6A capacity. Note that by default they operate independently with 3A capacity. This patch updates the devicetree binding with DT property to enable dual-phase mode on BUCK1. Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> --- Documentation/devicetree/bindings/mfd/88pm800.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt index dec842f..2c82fcb 100644 --- a/Documentation/devicetree/bindings/mfd/88pm800.txt +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt @@ -9,6 +9,12 @@ Required parent device properties: - #interrupt-cells : should be 1. The cell is the 88pm80x local IRQ number +Optional properties : +- marvell,88pm860-buck1-dualphase-en : If set, enable dual phase on BUCK1, + providing 6A capacity. + Without this both BUCK1A and BUCK1B operates independently with 3A capacity. + (This property is only applicable to 88PM860) + 88pm80x family of devices consists of varied group of sub-devices: Device Supply Names Description -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-08-24 15:10 +0200 |
| Subject | Re: [PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable |
| Message-ID | <q0ZFD-9c-17@gated-at.bofh.it> |
| In reply to | #1212136 |
On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: > 88PM860 family of device supports dual phase mode on BUCK1 supply > providing total 6A capacity. > Note that by default they operate independently with 3A capacity. > > This patch updates the devicetree binding with DT property > to enable dual-phase mode on BUCK1. > > Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> > --- > Documentation/devicetree/bindings/mfd/88pm800.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt > index dec842f..2c82fcb 100644 > --- a/Documentation/devicetree/bindings/mfd/88pm800.txt > +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt > @@ -9,6 +9,12 @@ Required parent device properties: > - #interrupt-cells : should be 1. > The cell is the 88pm80x local IRQ number > > +Optional properties : > +- marvell,88pm860-buck1-dualphase-en : If set, enable dual phase on BUCK1, > + providing 6A capacity. > + Without this both BUCK1A and BUCK1B operates independently with 3A capacity. > + (This property is only applicable to 88PM860) This will require a Regulator Ack. My suggestion would be to remove the 'buck' number, as the same property could be used on any Buck, and remove the '-en' part, as this is implied. > 88pm80x family of devices consists of varied group of sub-devices: > > Device Supply Names Description -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Vaibhav Hiremath <vaibhav.hiremath@linaro.org> |
|---|---|
| Date | 2015-08-24 17:00 +0200 |
| Subject | Re: [PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable |
| Message-ID | <q11o6-2qx-23@gated-at.bofh.it> |
| In reply to | #1212161 |
On Monday 24 August 2015 06:32 PM, Lee Jones wrote: > On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: > >> 88PM860 family of device supports dual phase mode on BUCK1 supply >> providing total 6A capacity. >> Note that by default they operate independently with 3A capacity. >> >> This patch updates the devicetree binding with DT property >> to enable dual-phase mode on BUCK1. >> >> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> >> --- >> Documentation/devicetree/bindings/mfd/88pm800.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt >> index dec842f..2c82fcb 100644 >> --- a/Documentation/devicetree/bindings/mfd/88pm800.txt >> +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt >> @@ -9,6 +9,12 @@ Required parent device properties: >> - #interrupt-cells : should be 1. >> The cell is the 88pm80x local IRQ number >> >> +Optional properties : >> +- marvell,88pm860-buck1-dualphase-en : If set, enable dual phase on BUCK1, >> + providing 6A capacity. >> + Without this both BUCK1A and BUCK1B operates independently with 3A capacity. >> + (This property is only applicable to 88PM860) > > This will require a Regulator Ack. > > My suggestion would be to remove the 'buck' number, as the same > property could be used on any Buck, and remove the '-en' part, as > this is implied. > Ok, Will do it in next version. Mark, Any comments here before I spin V4. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2015-08-27 20:50 +0200 |
| Subject | Re: [PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable |
| Message-ID | <q2apk-4ol-13@gated-at.bofh.it> |
| In reply to | #1212284 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, Aug 24, 2015 at 08:24:10PM +0530, Vaibhav Hiremath wrote: > Mark, > Any comments here before I spin V4. Please just resubmit things, seeing that a change was requested is usually a good indication that a new version is incoming.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web