Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1211837 > unrolled thread

Re: linux-next: build failure after merge of the slave-dma tree

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: linux-next: build failure after merge of the slave-dma tree Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-08-24 09:00 +0200
    Re: linux-next: build failure after merge of the slave-dma tree Vinod Koul <vinod.koul@intel.com> - 2015-08-24 10:10 +0200
      Re: linux-next: build failure after merge of the slave-dma tree Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-08-24 11:30 +0200

#1211837 — Re: linux-next: build failure after merge of the slave-dma tree

[Multipart message — attachments visible in raw view] — view raw

Hi Vinod,

On Thu, Aug 06, 2015 at 08:30:27AM +0530, Vinod Koul wrote:
> On Thu, Aug 06, 2015 at 12:22:03PM +1000, Stephen Rothwell wrote:
> > Hi Vinod,
> > 
> > After merging the slave-dma tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> > 
> > drivers/dma/at_hdmac.c: In function 'atc_prep_dma_memset':
> > drivers/dma/at_hdmac.c:960:6: error: 'struct at_desc' has no member named 'tx_width'
> >   desc->tx_width = 2;
> >       ^
> > 
> > Caused by commit
> > 
> >   25fed8c2fff1 ("dmaengine: hdmac: Add memset capabilities")
> > 
> > interacting with commit
> > 
> >   93dce3a6434f ("dmaengine: at_hdmac: fix residue computation")
> Thanks Stephen,
> 
> I am dropping this commit now, it need to be fixed to take into account
> Cyrille work on remove tx_width and this patch should be updated to reflect
> that

I'll send an updated version today, is there some time left for this
to be part of 4.3?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [next] | [standalone]

#1211895

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 24, 2015 at 08:53:59AM +0200, Maxime Ripard wrote:
> > I am dropping this commit now, it need to be fixed to take into account
> > Cyrille work on remove tx_width and this patch should be updated to reflect
> > that
> 
> I'll send an updated version today, is there some time left for this
> to be part of 4.3?

Fortunately for you, Linus released rc8, so yes if you are quick we can still
merge this

-- 
~Vinod

[toc] | [prev] | [next] | [standalone]

#1211982

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 24, 2015 at 01:41:43PM +0530, Vinod Koul wrote:
> On Mon, Aug 24, 2015 at 08:53:59AM +0200, Maxime Ripard wrote:
> > > I am dropping this commit now, it need to be fixed to take into account
> > > Cyrille work on remove tx_width and this patch should be updated to reflect
> > > that
> > 
> > I'll send an updated version today, is there some time left for this
> > to be part of 4.3?
> 
> Fortunately for you, Linus released rc8, so yes if you are quick we can still
> merge this

I just fixed the issue, tested it, and sent a new version.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web