Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1211183 > unrolled thread

Re: drm/layerscape: Add Freescale DCU DRM driver

Started byAndreas Ruprecht <andreas.ruprecht@fau.de>
First post2015-08-21 15:50 +0200
Last post2015-08-24 06:20 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  Re: drm/layerscape: Add Freescale DCU DRM driver Andreas Ruprecht <andreas.ruprecht@fau.de> - 2015-08-21 15:50 +0200
    Re: drm/layerscape: Add Freescale DCU DRM driver Jianwei Wang <jianwei.wang.chn@gmail.com> - 2015-08-24 06:10 +0200
    Re: drm/layerscape: Add Freescale DCU DRM driver Jianwei Wang <jianwei.wang.chn@gmail.com> - 2015-08-24 06:20 +0200

#1211183 — Re: drm/layerscape: Add Freescale DCU DRM driver

FromAndreas Ruprecht <andreas.ruprecht@fau.de>
Date2015-08-21 15:50 +0200
SubjectRe: drm/layerscape: Add Freescale DCU DRM driver
Message-ID<pZURH-5fy-9@gated-at.bofh.it>
Hi Jianwei,

your commit 109eee2f2a18 ("drm/layerscape: Add Freescale DCU DRM
driver") showed up in linux-next today (i.e., next-20150821). I noticed
it because we are running a daily analysis on the newest linux-next tree
as part of our research.

In the source code of fsl_dcu_drm_drv.c, there is the following #ifdef:
 #ifdef CONFIG_COMPAT
        .compat_ioctl   = drm_compat_ioctl,
 #endif

The Kconfig option for the driver, however, states that the driver can
only be built with CONFIG_ARM enabled:

config DRM_FSL_DCU
       tristate "DRM Support for Freescale DCU"
       depends on DRM && OF && ARM
       [...]

Inside arch/arm/, however, there is no definition of CONFIG_COMPAT (note
that there is one in arch/arm64/, but the driver explicitely needs
CONFIG_ARM), so the #ifdef block above can never be compiled in the
current state. Is this intended?

Regards,

Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1211762

FromJianwei Wang <jianwei.wang.chn@gmail.com>
Date2015-08-24 06:10 +0200
Message-ID<q0Rf4-4VY-9@gated-at.bofh.it>
In reply to#1211183
On Fri, Aug 21, 2015 at 9:41 PM, Andreas Ruprecht
<andreas.ruprecht@fau.de> wrote:
> Hi Jianwei,
>
> your commit 109eee2f2a18 ("drm/layerscape: Add Freescale DCU DRM
> driver") showed up in linux-next today (i.e., next-20150821). I noticed
> it because we are running a daily analysis on the newest linux-next tree
> as part of our research.
>
> In the source code of fsl_dcu_drm_drv.c, there is the following #ifdef:
>  #ifdef CONFIG_COMPAT
>         .compat_ioctl   = drm_compat_ioctl,
>  #endif
>
> The Kconfig option for the driver, however, states that the driver can
> only be built with CONFIG_ARM enabled:
>
> config DRM_FSL_DCU
>        tristate "DRM Support for Freescale DCU"
>        depends on DRM && OF && ARM
>        [...]
>
> Inside arch/arm/, however, there is no definition of CONFIG_COMPAT (note
> that there is one in arch/arm64/, but the driver explicitely needs
> CONFIG_ARM), so the #ifdef block above can never be compiled in the
> current state. Is this intended?
>
> Regards,
>
> Andreas


Hi Andreas,

Sorry for the late reply. Yes, this driver should also work on the
arm64 SOCs using DCU in the future. So I did some prepare for adapting
arm64 SOCs. But for now, It only support 32bit arm SOCs.

Regards,

Jianwei.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1211763

FromJianwei Wang <jianwei.wang.chn@gmail.com>
Date2015-08-24 06:20 +0200
Message-ID<q0RoJ-575-1@gated-at.bofh.it>
In reply to#1211183
Hi Andreas,

Sorry for the late reply. Yes, this driver should also work on the
arm64 SOCs using DCU in the future. So I did some prepare for adapting
arm64 SOCs. But for now, It only support 32bit arm SOCs.

Regards,

Jianwei.

On Fri, Aug 21, 2015 at 9:41 PM, Andreas Ruprecht
<andreas.ruprecht@fau.de> wrote:
> Hi Jianwei,
>
> your commit 109eee2f2a18 ("drm/layerscape: Add Freescale DCU DRM
> driver") showed up in linux-next today (i.e., next-20150821). I noticed
> it because we are running a daily analysis on the newest linux-next tree
> as part of our research.
>
> In the source code of fsl_dcu_drm_drv.c, there is the following #ifdef:
>  #ifdef CONFIG_COMPAT
>         .compat_ioctl   = drm_compat_ioctl,
>  #endif
>
> The Kconfig option for the driver, however, states that the driver can
> only be built with CONFIG_ARM enabled:
>
> config DRM_FSL_DCU
>        tristate "DRM Support for Freescale DCU"
>        depends on DRM && OF && ARM
>        [...]
>
> Inside arch/arm/, however, there is no definition of CONFIG_COMPAT (note
> that there is one in arch/arm64/, but the driver explicitely needs
> CONFIG_ARM), so the #ifdef block above can never be compiled in the
> current state. Is this intended?
>
> Regards,
>
> Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web