Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1160729 > unrolled thread
| Started by | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| First post | 2015-06-08 21:40 +0200 |
| Last post | 2015-06-08 22:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 1/7] staging:lustre: move tcpip abstraction Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-06-08 21:40 +0200
Re: [PATCH v4 1/7] staging:lustre: move tcpip abstraction Joe Perches <joe@perches.com> - 2015-06-08 22:00 +0200
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-06-08 21:40 +0200 |
| Subject | Re: [PATCH v4 1/7] staging:lustre: move tcpip abstraction |
| Message-ID | <pzb3P-8tx-3@gated-at.bofh.it> |
On Wed, Jun 03, 2015 at 03:57:07PM -0400, James Simmons wrote: > Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c > > Signed-off-by: James Simmons <jsimmons@infradead.org> > --- > drivers/staging/lustre/lnet/lnet/Makefile | 7 +- > drivers/staging/lustre/lnet/lnet/lib-socket.c | 624 ++++++++++++++++++++ > drivers/staging/lustre/lustre/libcfs/Makefile | 1 - > .../lustre/lustre/libcfs/linux/linux-tcpip.c | 623 ------------------- > 4 files changed, 628 insertions(+), 627 deletions(-) > create mode 100644 drivers/staging/lustre/lnet/lnet/lib-socket.c > delete mode 100644 drivers/staging/lustre/lustre/libcfs/linux/linux-tcpip.c Please generate patches in -M format, so I can see the rename properly, as it is, this is too messy for me to review. Please fix up and resend. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2015-06-08 22:00 +0200 |
| Message-ID | <pzbnc-pK-27@gated-at.bofh.it> |
| In reply to | #1160729 |
On Mon, 2015-06-08 at 12:33 -0700, Greg Kroah-Hartman wrote: > Please generate patches in -M format, so I can see the rename properly, > as it is, this is too messy for me to review. Adding this to the .gitconfig works too [diff] renames = true That should probably be mentioned in SubmittingPatches. Something like: --- Documentation/SubmittingPatches | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 27e7e5e..d86cf89 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -715,6 +715,13 @@ the top of the kernel source tree and don't use too much horizontal space (easily fit in 80 columns, maybe with some indentation). (git generates appropriate diffstats by default.) +Another good thing is to generate shorter patches whenever a file rename +has been done. Using "git format-patch -M" does this appropriately. +Adding a [diff] section as below to .gitconfig can also do this: + + [diff] + renames = true + See more details on the proper patch format in the following references. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web