Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1161888 > unrolled thread

Re: [PATCH] USB: uvc: add support for the Microsoft Surface Pro 3 Cameras

Started byDennis Chen <barracks510@gmail.com>
First post2015-06-10 03:10 +0200
Last post2015-06-10 03:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] USB: uvc: add support for the Microsoft Surface Pro 3  Cameras Dennis Chen <barracks510@gmail.com> - 2015-06-10 03:10 +0200
    Re: [PATCH] USB: uvc: add support for the Microsoft Surface Pro 3 Cameras Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2015-06-10 03:20 +0200
      Re: [PATCH] USB: uvc: add support for the Microsoft Surface Pro 3  Cameras Dennis Chen <barracks510@gmail.com> - 2015-06-10 03:50 +0200

#1161888 — Re: [PATCH] USB: uvc: add support for the Microsoft Surface Pro 3 Cameras

FromDennis Chen <barracks510@gmail.com>
Date2015-06-10 03:10 +0200
SubjectRe: [PATCH] USB: uvc: add support for the Microsoft Surface Pro 3 Cameras
Message-ID<pzCGJ-7eW-3@gated-at.bofh.it>
Add support for the Microsoft Surface Pro 3 Cameras.

Signed-off-by: Dennis Chen <barracks510@gmail.com>
---
 drivers/media/usb/uvc/uvc_driver.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 5970dd6..ec5a407 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2538,6 +2538,22 @@ static struct usb_device_id uvc_ids[] = {
          .bInterfaceSubClass   = 1,
          .bInterfaceProtocol   = 0,
          .driver_info          = UVC_QUIRK_FORCE_Y8 },
+       /*Microsoft Surface Pro 3 Front Camera*/
+       { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
+                               | USB_DEVICE_ID_MATCH_INT_INFO,
+         .idVendor             = 0x045e,
+         .idProduct            = 0x07be,
+         .bInterfaceClass      = USB_CLASS_VIDEO,
+         .bInterfaceSubClass   = 1,
+         .bInterfaceProtocol   = 1 },
+       /* Microsoft Surface Pro 3 Rear */
+       { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
+                               | USB_DEVICE_ID_MATCH_INT_INFO,
+         .idVendor             = 0x045e,
+         .idProduct            = 0x07bf,
+         .bInterfaceClass      = USB_CLASS_VIDEO,
+         .bInterfaceSubClass   = 1,
+         .bInterfaceProtocol   = 1 },
        /* Generic USB Video Class */
        { USB_INTERFACE_INFO(USB_CLASS_VIDEO, 1, 0) },
        {}
-- 
2.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1161892 — Re: [PATCH] USB: uvc: add support for the Microsoft Surface Pro 3 Cameras

FromLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Date2015-06-10 03:20 +0200
SubjectRe: [PATCH] USB: uvc: add support for the Microsoft Surface Pro 3 Cameras
Message-ID<pzCQp-7qt-9@gated-at.bofh.it>
In reply to#1161888
Hi Dennis,

Thank you for the patch.

On Tuesday 09 June 2015 18:09:06 Dennis Chen wrote:
> Add support for the Microsoft Surface Pro 3 Cameras.

Is this needed ? Looking at the patch your cameras are UVC-compliant and 
should thus be picked by the uvcvideo driver without any change to the code.

> Signed-off-by: Dennis Chen <barracks510@gmail.com>
> ---
>  drivers/media/usb/uvc/uvc_driver.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c
> b/drivers/media/usb/uvc/uvc_driver.c index 5970dd6..ec5a407 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2538,6 +2538,22 @@ static struct usb_device_id uvc_ids[] = {
>           .bInterfaceSubClass   = 1,
>           .bInterfaceProtocol   = 0,
>           .driver_info          = UVC_QUIRK_FORCE_Y8 },
> +       /*Microsoft Surface Pro 3 Front Camera*/
> +       { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
> +                               | USB_DEVICE_ID_MATCH_INT_INFO,
> +         .idVendor             = 0x045e,
> +         .idProduct            = 0x07be,
> +         .bInterfaceClass      = USB_CLASS_VIDEO,
> +         .bInterfaceSubClass   = 1,
> +         .bInterfaceProtocol   = 1 },
> +       /* Microsoft Surface Pro 3 Rear */
> +       { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
> +                               | USB_DEVICE_ID_MATCH_INT_INFO,
> +         .idVendor             = 0x045e,
> +         .idProduct            = 0x07bf,
> +         .bInterfaceClass      = USB_CLASS_VIDEO,
> +         .bInterfaceSubClass   = 1,
> +         .bInterfaceProtocol   = 1 },
>         /* Generic USB Video Class */
>         { USB_INTERFACE_INFO(USB_CLASS_VIDEO, 1, 0) },
>         {}

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1161898

FromDennis Chen <barracks510@gmail.com>
Date2015-06-10 03:50 +0200
Message-ID<pzDjt-7Zy-7@gated-at.bofh.it>
In reply to#1161892
> Is this needed ? Looking at the patch your cameras are UVC-compliant 
> and 
> should thus be picked by the uvcvideo driver without any change to 
> the code.

The cameras are UVC-compliant but are not recognized by the uvc driver.
The patch forces the uvc driver to pick up the camera if present.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web