Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1160411 > unrolled thread

Re: [RFT v2 11/48] ipu: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RFT v2 11/48] ipu: Use irq_desc_get_xxx() to avoid redundant  lookup of irq_desc Vinod Koul <vinod.koul@intel.com> - 2015-06-08 13:20 +0200
    Re: [RFT v2 11/48] ipu: Use irq_desc_get_xxx() to avoid redundant  lookup of irq_desc Jiang Liu <jiang.liu@linux.intel.com> - 2015-06-08 13:40 +0200

#1160411 — Re: [RFT v2 11/48] ipu: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc

On Thu, Jun 04, 2015 at 12:13:21PM +0800, Jiang Liu wrote:
> Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc while we
> already have a pointer to corresponding irq_desc.
> 
> Do the same thing to avoid pattern "irq_get_chip_data(data->irq)".

And I am missing the context, it is a bad practice to send some part of the
series without giving context. Is this dependent on something else...?

-- 
~Vinod
> 
> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> ---
>  drivers/dma/ipu/ipu_irq.c       |    2 +-
>  drivers/gpu/ipu-v3/ipu-common.c |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/ipu/ipu_irq.c b/drivers/dma/ipu/ipu_irq.c
> index 2e284a4438bc..0e12af37fe2f 100644
> --- a/drivers/dma/ipu/ipu_irq.c
> +++ b/drivers/dma/ipu/ipu_irq.c
> @@ -268,7 +268,7 @@ int ipu_irq_unmap(unsigned int source)
>  /* Chained IRQ handler for IPU error interrupt */
>  static void ipu_irq_err(unsigned int irq, struct irq_desc *desc)
>  {
> -	struct ipu *ipu = irq_get_handler_data(irq);
> +	struct ipu *ipu = irq_desc_get_handler_data(desc);
>  	u32 status;
>  	int i, line;
>  
> diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
> index 67bab5c36056..7022825b7a2c 100644
> --- a/drivers/gpu/ipu-v3/ipu-common.c
> +++ b/drivers/gpu/ipu-v3/ipu-common.c
> @@ -915,8 +915,8 @@ static void ipu_irq_handle(struct ipu_soc *ipu, const int *regs, int num_regs)
>  static void ipu_irq_handler(unsigned int irq, struct irq_desc *desc)
>  {
>  	struct ipu_soc *ipu = irq_desc_get_handler_data(desc);
> +	struct irq_chip *chip = irq_desc_get_chip(desc);
>  	const int int_reg[] = { 0, 1, 2, 3, 10, 11, 12, 13, 14};
> -	struct irq_chip *chip = irq_get_chip(irq);
>  
>  	chained_irq_enter(chip, desc);
>  
> @@ -928,8 +928,8 @@ static void ipu_irq_handler(unsigned int irq, struct irq_desc *desc)
>  static void ipu_err_irq_handler(unsigned int irq, struct irq_desc *desc)
>  {
>  	struct ipu_soc *ipu = irq_desc_get_handler_data(desc);
> +	struct irq_chip *chip = irq_desc_get_chip(desc);
>  	const int int_reg[] = { 4, 5, 8, 9};
> -	struct irq_chip *chip = irq_get_chip(irq);
>  
>  	chained_irq_enter(chip, desc);
>  
> -- 
> 1.7.10.4
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1160416

On 2015/6/8 19:16, Vinod Koul wrote:
> On Thu, Jun 04, 2015 at 12:13:21PM +0800, Jiang Liu wrote:
>> Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc while we
>> already have a pointer to corresponding irq_desc.
>>
>> Do the same thing to avoid pattern "irq_get_chip_data(data->irq)".
> 
> And I am missing the context, it is a bad practice to send some part of the
> series without giving context. Is this dependent on something else...?
This patch set touches too many files, so I didn't send the cover letter
to all maintainers. The whole patch set is to simplify core irq
interfaces by killing the 'irq' parameter. Please refer to
lkml.org/lkml/2015/6/4/113

And it may depends on preceding patches in tip/x86/apic branch, so it
would be safer to handle the patch set altogether.
Thanks!
Gerry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web