Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1160383 > unrolled thread
| Started by | Antony Pavlov <antonynpavlov@gmail.com> |
|---|---|
| First post | 2015-06-08 12:20 +0200 |
| Last post | 2015-06-15 09:40 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 12/12] MIPS: Add basic support for the TL-WR1043ND version 1 Antony Pavlov <antonynpavlov@gmail.com> - 2015-06-08 12:20 +0200
Re: [PATCH v4 12/12] MIPS: Add basic support for the TL-WR1043ND version 1 Alban <albeu@free.fr> - 2015-06-11 00:00 +0200
Re: [PATCH v4 12/12] MIPS: Add basic support for the TL-WR1043ND version 1 Antony Pavlov <antonynpavlov@gmail.com> - 2015-06-15 09:40 +0200
| From | Antony Pavlov <antonynpavlov@gmail.com> |
|---|---|
| Date | 2015-06-08 12:20 +0200 |
| Subject | Re: [PATCH v4 12/12] MIPS: Add basic support for the TL-WR1043ND version 1 |
| Message-ID | <pz2jT-3X6-3@gated-at.bofh.it> |
On Sun, 31 May 2015 02:18:26 +0200
Alban Bedel <albeu@free.fr> wrote:
> Add a DTS for TL-WR1043ND version 1 and allow to have it built in the
> kernel to circumvent the broken u-boot found on these boards.
> Currently only the UART, LEDs and buttons are supported.
>
> Signed-off-by: Alban Bedel <albeu@free.fr>
> --- /dev/null
> +++ b/arch/mips/boot/dts/qca/ar9132.dtsi
> +++ b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> @@ -0,0 +1,112 @@
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +
> +#include "ar9132.dtsi"
> +
> +/ {
> + compatible = "tplink,tl-wr1043nd-v1", "qca,ar9132";
> + model = "TP-Link TL-WR1043ND Version 1";
> +
> + alias {
> + serial0 = "/ahb/apb/uart@18020000";
> + };
> +
> + memory@0 {
> + device_type = "memory";
> + reg = <0x0 0x2000000>;
> + };
> +
> + extosc: oscillator {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <40000000>;
> + };
> +
> + ahb {
> + apb {
> + uart@18020000 {
> + status = "okay";
> + };
> +
> + pll-controller@18050000 {
> + clocks = <&extosc>;
IMHO AR9132 SoC can't work without external oscilator.
Can we just move basic extosc declaration to SoC dt file (ar9132.dtsi)?
So board dt file ar9132_tl_wr1043nd_v1.dts will contain only oscilator
clock frequency value.
E.g.
ar9132.dtsi:
============
extosc: oscillator {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <40000000>;
};
...
ahb {
apb {
...
pll-controller@18050000 {
...
clocks = <&extosc>;
...
ar9132_tl_wr1043nd_v1.dts:
==========================
...
&extosc {
clock-frequency = <40000000>;
};
--
Best regards,
Antony Pavlov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Alban <albeu@free.fr> |
|---|---|
| Date | 2015-06-11 00:00 +0200 |
| Message-ID | <pzWcq-2gs-11@gated-at.bofh.it> |
| In reply to | #1160383 |
On Mon, 8 Jun 2015 13:17:58 +0300 Antony Pavlov <antonynpavlov@gmail.com> wrote: > IMHO AR9132 SoC can't work without external oscilator. > > Can we just move basic extosc declaration to SoC dt file > (ar9132.dtsi)? So board dt file ar9132_tl_wr1043nd_v1.dts will > contain only oscilator clock frequency value. I would prefer to keep the split between the files in sync with the hardware. I understand that most simple board designs use a fixed oscillator, but that might not always be the case. Alban -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Antony Pavlov <antonynpavlov@gmail.com> |
|---|---|
| Date | 2015-06-15 09:40 +0200 |
| Message-ID | <pBx9T-59C-9@gated-at.bofh.it> |
| In reply to | #1162911 |
On Wed, 10 Jun 2015 23:58:11 +0200
Alban <albeu@free.fr> wrote:
> On Mon, 8 Jun 2015 13:17:58 +0300
> Antony Pavlov <antonynpavlov@gmail.com> wrote:
>
> > IMHO AR9132 SoC can't work without external oscilator.
> >
> > Can we just move basic extosc declaration to SoC dt file
> > (ar9132.dtsi)? So board dt file ar9132_tl_wr1043nd_v1.dts will
> > contain only oscilator clock frequency value.
>
> I would prefer to keep the split between the files in sync with the
> hardware. I understand that most simple board designs use a fixed
> oscillator, but that might not always be the case.
>
The AR9132 SoC __always__ use one external oscilator. So it's reasonable
to have the first mention of extosc in ar9132.dtsi not in a board file.
This description style is always sync with hardware.
On the other hand pll-controller is always part of the SoC
not a part of a board. So pll-controller on extosc dependency
have to go to SoC dts file not to a board file. In your dts description
pll-controller is a part of a dts board file.
It looks like my previous device tree structure proposal contains a small error
(extra clock-frequency field in ar9132.dtsi). I have fixed it. Please comment it.
ar9132.dtsi:
============
extosc: oscillator {
compatible = "fixed-clock";
#clock-cells = <0>;
};
...
ahb {
apb {
...
pll-controller@18050000 {
...
clocks = <&extosc>;
...
ar9132_tl_wr1043nd_v1.dts:
==========================
...
&extosc {
clock-frequency = <40000000>;
};
--
--
Best regards,
Antony Pavlov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web