Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1158886 > unrolled thread
| Started by | Vikas Shivappa <vikas.shivappa@linux.intel.com> |
|---|---|
| First post | 2015-06-05 02:10 +0200 |
| Last post | 2015-06-06 02:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 03/10] x86/intel_rapl: Modify hot cpu notification handling for RAPL Vikas Shivappa <vikas.shivappa@linux.intel.com> - 2015-06-05 02:10 +0200
Re: [PATCH 03/10] x86/intel_rapl: Modify hot cpu notification handling for RAPL Vikas Shivappa <vikas.shivappa@intel.com> - 2015-06-06 02:50 +0200
| From | Vikas Shivappa <vikas.shivappa@linux.intel.com> |
|---|---|
| Date | 2015-06-05 02:10 +0200 |
| Subject | [PATCH 03/10] x86/intel_rapl: Modify hot cpu notification handling for RAPL |
| Message-ID | <pxNmV-8sC-9@gated-at.bofh.it> |
This patch modifies the hot cpu notification handling in
Intel Running Average Power Limit(RAPL) driver.
- to add a cpu reader to the rapl_cpumask(which has one cpu per package
set) it uses the existing package<->core map instead of looping
through all cpus in rapl_cpumask.
- to search for the next online sibling during hot cpu exit, it uses
the cpumask_any_online_but instead of looping all online cpus. In
large systems with large number of cpus the time taken to loop may be
expensive and also the time increase linearly.
Signed-off-by: Vikas Shivappa <vikas.shivappa@linux.intel.com>
---
arch/x86/kernel/cpu/perf_event_intel_rapl.c | 27 ++++++++++-----------------
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_rapl.c b/arch/x86/kernel/cpu/perf_event_intel_rapl.c
index 358c54a..987383e 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_rapl.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_rapl.c
@@ -524,18 +524,14 @@ static struct pmu rapl_pmu_class = {
static void rapl_cpu_exit(int cpu)
{
struct rapl_pmu *pmu = per_cpu(rapl_pmu, cpu);
- int i, phys_id = topology_physical_package_id(cpu);
int target = -1;
+ int i;
/* find a new cpu on same package */
- for_each_online_cpu(i) {
- if (i == cpu)
- continue;
- if (phys_id == topology_physical_package_id(i)) {
- target = i;
- break;
- }
- }
+ i = cpumask_any_online_but(topology_core_cpumask(cpu), cpu);
+ if (i < nr_cpu_ids)
+ target = i;
+
/*
* clear cpu from cpumask
* if was set in cpumask and still some cpu on package,
@@ -557,15 +553,12 @@ static void rapl_cpu_exit(int cpu)
static void rapl_cpu_init(int cpu)
{
- int i, phys_id = topology_physical_package_id(cpu);
+ struct cpumask tmp;
- /* check if phys_is is already covered */
- for_each_cpu(i, &rapl_cpu_mask) {
- if (phys_id == topology_physical_package_id(i))
- return;
- }
- /* was not found, so add it */
- cpumask_set_cpu(cpu, &rapl_cpu_mask);
+ /* check if cpu's package is already covered.If not, add it.*/
+ cpumask_and(&tmp, &rapl_cpu_mask, topology_core_cpumask(cpu));
+ if (cpumask_empty(&tmp))
+ cpumask_set_cpu(cpu, &rapl_cpu_mask);
}
static __init void rapl_hsw_server_quirk(void)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Vikas Shivappa <vikas.shivappa@intel.com> |
|---|---|
| Date | 2015-06-06 02:50 +0200 |
| Subject | Re: [PATCH 03/10] x86/intel_rapl: Modify hot cpu notification handling for RAPL |
| Message-ID | <pyatc-vK-1@gated-at.bofh.it> |
| In reply to | #1158886 |
+ Andi, Stephan, Boris and Jacob for RAPL patch
On Thu, 4 Jun 2015, Vikas Shivappa wrote:
> This patch modifies the hot cpu notification handling in
> Intel Running Average Power Limit(RAPL) driver.
>
> - to add a cpu reader to the rapl_cpumask(which has one cpu per package
> set) it uses the existing package<->core map instead of looping
> through all cpus in rapl_cpumask.
> - to search for the next online sibling during hot cpu exit, it uses
> the cpumask_any_online_but instead of looping all online cpus. In
> large systems with large number of cpus the time taken to loop may be
> expensive and also the time increase linearly.
>
> Signed-off-by: Vikas Shivappa <vikas.shivappa@linux.intel.com>
> ---
> arch/x86/kernel/cpu/perf_event_intel_rapl.c | 27 ++++++++++-----------------
> 1 file changed, 10 insertions(+), 17 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_rapl.c b/arch/x86/kernel/cpu/perf_event_intel_rapl.c
> index 358c54a..987383e 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel_rapl.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_rapl.c
> @@ -524,18 +524,14 @@ static struct pmu rapl_pmu_class = {
> static void rapl_cpu_exit(int cpu)
> {
> struct rapl_pmu *pmu = per_cpu(rapl_pmu, cpu);
> - int i, phys_id = topology_physical_package_id(cpu);
> int target = -1;
> + int i;
>
> /* find a new cpu on same package */
> - for_each_online_cpu(i) {
> - if (i == cpu)
> - continue;
> - if (phys_id == topology_physical_package_id(i)) {
> - target = i;
> - break;
> - }
> - }
> + i = cpumask_any_online_but(topology_core_cpumask(cpu), cpu);
> + if (i < nr_cpu_ids)
> + target = i;
> +
> /*
> * clear cpu from cpumask
> * if was set in cpumask and still some cpu on package,
> @@ -557,15 +553,12 @@ static void rapl_cpu_exit(int cpu)
>
> static void rapl_cpu_init(int cpu)
> {
> - int i, phys_id = topology_physical_package_id(cpu);
> + struct cpumask tmp;
>
> - /* check if phys_is is already covered */
> - for_each_cpu(i, &rapl_cpu_mask) {
> - if (phys_id == topology_physical_package_id(i))
> - return;
> - }
> - /* was not found, so add it */
> - cpumask_set_cpu(cpu, &rapl_cpu_mask);
> + /* check if cpu's package is already covered.If not, add it.*/
> + cpumask_and(&tmp, &rapl_cpu_mask, topology_core_cpumask(cpu));
> + if (cpumask_empty(&tmp))
> + cpumask_set_cpu(cpu, &rapl_cpu_mask);
> }
>
> static __init void rapl_hsw_server_quirk(void)
> --
> 1.9.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web