Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1156986 > unrolled thread

Re: [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that resume in ARM state

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that  resume in ARM state Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-06-03 01:50 +0200
    Re: [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that  resume in ARM state Stephen Boyd <sboyd@codeaurora.org> - 2015-06-03 02:20 +0200

#1156986 — Re: [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that resume in ARM state

On Tue, Jun 02, 2015 at 12:12:57PM -0700, Stephen Boyd wrote:
> Some platforms always enter the kernel in the ARM state even if
> the kernel is compiled for THUMB2. Add a small wrapper on top of
> cpu_resume() that switches into THUMB2 state.
> 
> This fixes a problem reported by Kevin Hilman on next-20150601
> where the ifc6410 fails to boot a THUMB2 kernel because the
> platform's firmware always enters the kernel in ARM mode from
> deep idle states.

I think this bit of the commit message isn't quite correct: this will
only resolve the boot problem with a T2 kernel when the failing platform
is converted to use the cpu_resume_arm() entry point.

Apart from that, the patch looks good to me, thanks.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1156995

On 06/03, Russell King - ARM Linux wrote:
> On Tue, Jun 02, 2015 at 12:12:57PM -0700, Stephen Boyd wrote:
> > Some platforms always enter the kernel in the ARM state even if
> > the kernel is compiled for THUMB2. Add a small wrapper on top of
> > cpu_resume() that switches into THUMB2 state.
> > 
> > This fixes a problem reported by Kevin Hilman on next-20150601
> > where the ifc6410 fails to boot a THUMB2 kernel because the
> > platform's firmware always enters the kernel in ARM mode from
> > deep idle states.
> 
> I think this bit of the commit message isn't quite correct: this will
> only resolve the boot problem with a T2 kernel when the failing platform
> is converted to use the cpu_resume_arm() entry point.
> 
> Apart from that, the patch looks good to me, thanks.

Sure, it could say "This provides the functionality to fix a problem
reported by..."

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web