Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1210440 > unrolled thread
| Started by | Ales Novak <alnovak@suse.cz> |
|---|---|
| First post | 2015-08-20 13:40 +0200 |
| Last post | 2015-08-26 15:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] fix: lpfc_send_rscn_event sends bigger buffer size Ales Novak <alnovak@suse.cz> - 2015-08-20 13:40 +0200
Re: [PATCH] fix: lpfc_send_rscn_event sends bigger buffer size Hannes Reinecke <hare@suse.de> - 2015-08-26 15:00 +0200
| From | Ales Novak <alnovak@suse.cz> |
|---|---|
| Date | 2015-08-20 13:40 +0200 |
| Subject | [PATCH] fix: lpfc_send_rscn_event sends bigger buffer size |
| Message-ID | <pZwml-3AQ-15@gated-at.bofh.it> |
lpfc_send_rscn_event() allocates data for sizeof(struct lpfc_rscn_event_header) + payload_len, but claims that the data has size of sizeof(struct lpfc_els_event_header) + payload_len. That leads to buffer overruns. Signed-off-by: Ales Novak <alnovak@suse.cz> --- drivers/scsi/lpfc/lpfc_els.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 36bf58b..136928e 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -5444,7 +5444,7 @@ lpfc_send_rscn_event(struct lpfc_vport *vport, fc_host_post_vendor_event(shost, fc_get_event_number(), - sizeof(struct lpfc_els_event_header) + payload_len, + sizeof(struct lpfc_rscn_event_header) + payload_len, (char *)rscn_event_data, LPFC_NL_VENDOR_ID); -- 2.4.1.168.g1ea28e1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Hannes Reinecke <hare@suse.de> |
|---|---|
| Date | 2015-08-26 15:00 +0200 |
| Message-ID | <q1It5-6bl-25@gated-at.bofh.it> |
| In reply to | #1210440 |
On 08/20/2015 01:35 PM, Ales Novak wrote: > lpfc_send_rscn_event() allocates data for sizeof(struct > lpfc_rscn_event_header) + payload_len, but claims that the data has size > of sizeof(struct lpfc_els_event_header) + payload_len. That leads to > buffer overruns. > > Signed-off-by: Ales Novak <alnovak@suse.cz> > --- > drivers/scsi/lpfc/lpfc_els.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c > index 36bf58b..136928e 100644 > --- a/drivers/scsi/lpfc/lpfc_els.c > +++ b/drivers/scsi/lpfc/lpfc_els.c > @@ -5444,7 +5444,7 @@ lpfc_send_rscn_event(struct lpfc_vport *vport, > > fc_host_post_vendor_event(shost, > fc_get_event_number(), > - sizeof(struct lpfc_els_event_header) + payload_len, > + sizeof(struct lpfc_rscn_event_header) + payload_len, > (char *)rscn_event_data, > LPFC_NL_VENDOR_ID); > > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web