Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1210423 > unrolled thread
| Started by | byungchul.park@lge.com |
|---|---|
| First post | 2015-08-20 13:30 +0200 |
| Last post | 2015-08-20 13:30 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v4 3/5] sched: sync a se with prev cfs_rq when changing cgroup byungchul.park@lge.com - 2015-08-20 13:30 +0200
| From | byungchul.park@lge.com |
|---|---|
| Date | 2015-08-20 13:30 +0200 |
| Subject | [PATCH v4 3/5] sched: sync a se with prev cfs_rq when changing cgroup |
| Message-ID | <pZwcF-3pE-1@gated-at.bofh.it> |
From: Byungchul Park <byungchul.park@lge.com> current code is wrong with cfs_rq's average load when changing a task's cfs_rq to another. i tested with "echo pid > cgroup" and found that e.g. cfs_rq->avg.load_avg became larger and larger whenever changing cgroup to another again and again. we have to sync se's average load with both *prev* cfs_rq and next cfs_rq when changing its cgroup. Signed-off-by: Byungchul Park <byungchul.park@lge.com> --- kernel/sched/fair.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 9f93c8b..d58e9aa 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8037,8 +8037,12 @@ static void task_move_group_fair(struct task_struct *p, int queued) if (!queued && (!se->sum_exec_runtime || p->state == TASK_WAKING)) queued = 1; + cfs_rq = cfs_rq_of(se); if (!queued) - se->vruntime -= cfs_rq_of(se)->min_vruntime; + se->vruntime -= cfs_rq->min_vruntime; + + /* Synchronize task with its prev cfs_rq */ + detach_entity_load_avg(cfs_rq, se); set_task_rq(p, task_cpu(p)); se->depth = se->parent ? se->parent->depth + 1 : 0; cfs_rq = cfs_rq_of(se); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to top | Article view | linux.kernel
csiph-web