Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1210403 > unrolled thread
| Started by | Matt Redfearn <matt.redfearn@imgtec.com> |
|---|---|
| First post | 2015-08-20 12:40 +0200 |
| Last post | 2015-08-24 16:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mfd: jz4740-adc: Init mask cache in generic IRQ chip Matt Redfearn <matt.redfearn@imgtec.com> - 2015-08-20 12:40 +0200
Re: [PATCH] mfd: jz4740-adc: Init mask cache in generic IRQ chip Lee Jones <lee.jones@linaro.org> - 2015-08-24 16:10 +0200
| From | Matt Redfearn <matt.redfearn@imgtec.com> |
|---|---|
| Date | 2015-08-20 12:40 +0200 |
| Subject | [PATCH] mfd: jz4740-adc: Init mask cache in generic IRQ chip |
| Message-ID | <pZvqi-2fu-17@gated-at.bofh.it> |
The mask cache must be initialised in the generic IRQ chip, otherwise enabling one channel will actually enable all channels when the empty mask cache is written. Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com> --- drivers/mfd/jz4740-adc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c index ae2ad8ad0e2f..e8699c0cdae6 100644 --- a/drivers/mfd/jz4740-adc.c +++ b/drivers/mfd/jz4740-adc.c @@ -276,7 +276,8 @@ static int jz4740_adc_probe(struct platform_device *pdev) ct->chip.irq_unmask = irq_gc_mask_clr_bit; ct->chip.irq_ack = irq_gc_ack_set_bit; - irq_setup_generic_chip(gc, IRQ_MSK(5), 0, 0, IRQ_NOPROBE | IRQ_LEVEL); + irq_setup_generic_chip(gc, IRQ_MSK(5), IRQ_GC_INIT_MASK_CACHE, 0, + IRQ_NOPROBE | IRQ_LEVEL); adc->gc = gc; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-08-24 16:10 +0200 |
| Message-ID | <q10BI-1vm-3@gated-at.bofh.it> |
| In reply to | #1210403 |
On Thu, 20 Aug 2015, Matt Redfearn wrote: > The mask cache must be initialised in the generic IRQ chip, > otherwise enabling one channel will actually enable all > channels when the empty mask cache is written. > > Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com> > --- > drivers/mfd/jz4740-adc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c > index ae2ad8ad0e2f..e8699c0cdae6 100644 > --- a/drivers/mfd/jz4740-adc.c > +++ b/drivers/mfd/jz4740-adc.c > @@ -276,7 +276,8 @@ static int jz4740_adc_probe(struct platform_device *pdev) > ct->chip.irq_unmask = irq_gc_mask_clr_bit; > ct->chip.irq_ack = irq_gc_ack_set_bit; > > - irq_setup_generic_chip(gc, IRQ_MSK(5), 0, 0, IRQ_NOPROBE | IRQ_LEVEL); > + irq_setup_generic_chip(gc, IRQ_MSK(5), IRQ_GC_INIT_MASK_CACHE, 0, > + IRQ_NOPROBE | IRQ_LEVEL); > > adc->gc = gc; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web