Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200610 > unrolled thread

Re: [PATCH 4.2-rc5] workqueue: Make flush_workqueue() available again to non GPL modules

Back to article view | Back to linux.kernel

Contents

  Re: [PATCH 4.2-rc5] workqueue: Make flush_workqueue() available  again to non GPL modules David Laight <David.Laight@ACULAB.COM> - 2015-08-05 12:00 +0200
    RE: Re: [PATCH 4.2-rc5] workqueue: Make flush_workqueue() available  again to non GPL modules David Laight <David.Laight@ACULAB.COM> - 2015-08-20 12:20 +0200

#1200610 — Re: [PATCH 4.2-rc5] workqueue: Make flush_workqueue() available again to non GPL modules

> From:       Tejun Heo 
> Date:       2015-08-04 18:05:20
> On Tue, Aug 04, 2015 at 11:26:04AM -0600, tim.gardner@canonical.com wrote:
> > From: Tim Gardner <tim.gardner@canonical.com>
> >
> > Commit 37b1ef31a568fc02e53587620226e5f3c66454c8 ("workqueue: move
> > flush_scheduled_work() to workqueue.h") moved the exported non GPL
> > flush_scheduled_work() from a function to an inline wrapper.
> > Unfortunately, it directly calls flush_workqueue() which is a GPL function.
> > This has the effect of changing the licensing requirement for this function
> > and makes it unavailable to non GPL modules.
> >
> > See commit ad7b1f841f8a54c6d61ff181451f55b68175e15a ("workqueue: Make
> > schedule_work() available again to non GPL modules") for precedent.
> >
> > Cc: Tejun Heo <tj@kernel.org>
> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
>
> Applied to wq/for-4.3.

I hit this yesterday afternoon as well!

Can we get the fix into 4.2 itself ?

	David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1210395

From: David Laight
> Sent: 05 August 2015 10:52
> To: linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 4.2-rc5] workqueue: Make flush_workqueue() available again to non GPL modules
> 
> > From:       Tejun Heo
> > Date:       2015-08-04 18:05:20
> > On Tue, Aug 04, 2015 at 11:26:04AM -0600, tim.gardner@canonical.com wrote:
> > > From: Tim Gardner <tim.gardner@canonical.com>
> > >
> > > Commit 37b1ef31a568fc02e53587620226e5f3c66454c8 ("workqueue: move
> > > flush_scheduled_work() to workqueue.h") moved the exported non GPL
> > > flush_scheduled_work() from a function to an inline wrapper.
> > > Unfortunately, it directly calls flush_workqueue() which is a GPL function.
> > > This has the effect of changing the licensing requirement for this function
> > > and makes it unavailable to non GPL modules.
> > >
> > > See commit ad7b1f841f8a54c6d61ff181451f55b68175e15a ("workqueue: Make
> > > schedule_work() available again to non GPL modules") for precedent.
> > >
> > > Cc: Tejun Heo <tj@kernel.org>
> > > Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> >
> > Applied to wq/for-4.3.
> 
> I hit this yesterday afternoon as well!
> 
> Can we get the fix into 4.2 itself ?

This doesn't seem to be in 4.2 yet.
It is an interface regression that will cause grief.

	David
(I'm not subscribed to linux-kernel, so copy me in any responses.)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web