Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1210064 > unrolled thread
| Started by | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| First post | 2015-08-20 01:00 +0200 |
| Last post | 2015-08-24 01:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH net-next] net: dsa: mv88e6xxx: set 802.1Q mode to Fallback Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-08-20 01:00 +0200
Re: [PATCH net-next] net: dsa: mv88e6xxx: set 802.1Q mode to Fallback David Miller <davem@davemloft.net> - 2015-08-24 01:00 +0200
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2015-08-20 01:00 +0200 |
| Subject | [PATCH net-next] net: dsa: mv88e6xxx: set 802.1Q mode to Fallback |
| Message-ID | <pZkuR-33G-9@gated-at.bofh.it> |
The current Secure port mode requires the port-based VLANs to also be
valid in the 802.1Q VLAN Table Unit. The current hardware bridging
support only configures the port-based VLANs, thus is broken.
A new patchset is required to adapt the hardware bridging code to fully
support the Secure port mode.
In the meantime, change the 802.1Q mode of every ports to Fallback,
which filtering is more permissive, and doesn't add this restriction to
handle port-based and tagged-based VLANs.
Fixes: 8efdda4a1b60 ("net: dsa: mv88e6xxx: use port 802.1Q mode Secure")
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
drivers/net/dsa/mv88e6xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index dee71fa..91d7e0a 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -2091,7 +2091,7 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int port)
reg |= PORT_CONTROL_2_FORWARD_UNKNOWN;
}
- reg |= PORT_CONTROL_2_8021Q_SECURE;
+ reg |= PORT_CONTROL_2_8021Q_FALLBACK;
if (reg) {
ret = _mv88e6xxx_reg_write(ds, REG_PORT(port),
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2015-08-24 01:00 +0200 |
| Subject | Re: [PATCH net-next] net: dsa: mv88e6xxx: set 802.1Q mode to Fallback |
| Message-ID | <q0Mp4-6dN-5@gated-at.bofh.it> |
| In reply to | #1210064 |
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Wed, 19 Aug 2015 18:54:55 -0400
> The current Secure port mode requires the port-based VLANs to also be
> valid in the 802.1Q VLAN Table Unit. The current hardware bridging
> support only configures the port-based VLANs, thus is broken.
>
> A new patchset is required to adapt the hardware bridging code to fully
> support the Secure port mode.
>
> In the meantime, change the 802.1Q mode of every ports to Fallback,
> which filtering is more permissive, and doesn't add this restriction to
> handle port-based and tagged-based VLANs.
>
> Fixes: 8efdda4a1b60 ("net: dsa: mv88e6xxx: use port 802.1Q mode Secure")
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web