Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1210830 > unrolled thread
| Started by | Olof Johansson <olof@lixom.net> |
|---|---|
| First post | 2015-08-21 04:10 +0200 |
| Last post | 2015-08-21 04:10 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] ARM: multi_v7_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver Olof Johansson <olof@lixom.net> - 2015-08-21 04:10 +0200
| From | Olof Johansson <olof@lixom.net> |
|---|---|
| Date | 2015-08-21 04:10 +0200 |
| Subject | Re: [PATCH] ARM: multi_v7_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver |
| Message-ID | <pZJWh-6wA-5@gated-at.bofh.it> |
On Wed, Aug 19, 2015 at 12:28:37AM +0200, Javier Martinez Canillas wrote: > Hello Olof, > > On 08/18/2015 11:46 PM, Olof Johansson wrote: > > On Tue, Aug 18, 2015 at 09:10:27AM +0200, Javier Martinez Canillas wrote: > >> The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config > >> symbol because the driver uses some communication helper functions in > >> drivers/platform/chrome/cros_ec_proto.c but other drivers depends on > >> CROS_EC_PROTO instead. Mixing select and depends can lead to circular > >> Kconfig dependencies so the MFD_CROS_EC select should be changed to a > >> depends on CROS_EC_PROTO instead. > >> > >> But doing so will break git bisect-ability since MFD_CROS_EC will not > >> be enabled anymore unless the default configs first explicitly enable > >> the CROS_EC_PROTO dependency. > >> > >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > > > Applied to cros/ec-config in arm-soc, which will stay stable in case others > > need to bring in as a prereq. > > > > Thanks but Bartolomiej's feedback [0] on my patch that made CROS_EC_PROTO > a user selectable option was to leave it as a non-visible option and instead > change the other Kconfig symbols to select CROS_EC_PROTO consistently. > > So tomorrow I'll post a new patch series along those lines that will make > this patch obsolete since no defconfig changes will be needed. > > IOW, please drop this patch and sorry for the inconvenience. Done. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to top | Article view | linux.kernel
csiph-web