Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1210676 > unrolled thread
| Started by | Mark Brown <broonie@kernel.org> |
|---|---|
| First post | 2015-08-20 20:50 +0200 |
| Last post | 2015-08-20 23:30 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/9] spi: sunxi: fix transfer timeout Mark Brown <broonie@kernel.org> - 2015-08-20 20:50 +0200
Re: [PATCH 1/9] spi: sunxi: fix transfer timeout Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-08-20 21:40 +0200
Re: [PATCH 1/9] spi: sunxi: fix transfer timeout Mark Brown <broonie@kernel.org> - 2015-08-20 23:10 +0200
Re: [PATCH 1/9] spi: sunxi: fix transfer timeout Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-08-20 23:20 +0200
Re: [PATCH 1/9] spi: sunxi: fix transfer timeout Mark Brown <broonie@kernel.org> - 2015-08-20 23:30 +0200
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2015-08-20 20:50 +0200 |
| Subject | Re: [PATCH 1/9] spi: sunxi: fix transfer timeout |
| Message-ID | <pZD4t-4OQ-9@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Aug 20, 2015 at 02:19:45PM -0000, Michal Suchanek wrote: > drivers/spi/spi-sun4i.c | 10 +++++++++- > drivers/spi/spi-sun6i.c | 10 +++++++++- Are we *sure* we can't work on merging these drivers :(
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2015-08-20 21:40 +0200 |
| Message-ID | <pZDQR-5Z9-13@gated-at.bofh.it> |
| In reply to | #1210676 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Aug 20, 2015 at 11:41:32AM -0700, Mark Brown wrote: > On Thu, Aug 20, 2015 at 02:19:45PM -0000, Michal Suchanek wrote: > > > drivers/spi/spi-sun4i.c | 10 +++++++++- > > drivers/spi/spi-sun6i.c | 10 +++++++++- > > Are we *sure* we can't work on merging these drivers :( Those are two different IPs, that don't really share anything but their author... Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2015-08-20 23:10 +0200 |
| Message-ID | <pZFfY-8cw-9@gated-at.bofh.it> |
| In reply to | #1210695 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Aug 20, 2015 at 09:34:33PM +0200, Maxime Ripard wrote: > On Thu, Aug 20, 2015 at 11:41:32AM -0700, Mark Brown wrote: > > On Thu, Aug 20, 2015 at 02:19:45PM -0000, Michal Suchanek wrote: > > > drivers/spi/spi-sun4i.c | 10 +++++++++- > > > drivers/spi/spi-sun6i.c | 10 +++++++++- > > Are we *sure* we can't work on merging these drivers :( > Those are two different IPs, that don't really share anything but > their author... I seem to be seeing a number of changes like this one which make apparently very similar modifications to both. Perhaps there is more core usage that should be happening instead?
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2015-08-20 23:20 +0200 |
| Message-ID | <pZFpD-8nP-3@gated-at.bofh.it> |
| In reply to | #1210731 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Aug 20, 2015 at 02:08:30PM -0700, Mark Brown wrote: > On Thu, Aug 20, 2015 at 09:34:33PM +0200, Maxime Ripard wrote: > > On Thu, Aug 20, 2015 at 11:41:32AM -0700, Mark Brown wrote: > > > On Thu, Aug 20, 2015 at 02:19:45PM -0000, Michal Suchanek wrote: > > > > > drivers/spi/spi-sun4i.c | 10 +++++++++- > > > > drivers/spi/spi-sun6i.c | 10 +++++++++- > > > > Are we *sure* we can't work on merging these drivers :( > > > Those are two different IPs, that don't really share anything but > > their author... > > I seem to be seeing a number of changes like this one which make > apparently very similar modifications to both. Perhaps there is more > core usage that should be happening instead? Yeah, because I wrote the two at the same time, and they share the same flaws. But that doesn't really mean that you can share anything at the driver level. And I'm not really sure that we can do much more at the framework level either, except maybe handling the timeout directly (but then the drivers would have to handle the recovering after a timeout too). Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2015-08-20 23:30 +0200 |
| Message-ID | <pZFzk-7l-7@gated-at.bofh.it> |
| In reply to | #1210737 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Aug 20, 2015 at 11:18:50PM +0200, Maxime Ripard wrote: > at the driver level. And I'm not really sure that we can do much more > at the framework level either, except maybe handling the timeout > directly (but then the drivers would have to handle the recovering > after a timeout too). We have handle_err() for that sort of cleanup.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web