Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1209784 > unrolled thread

[PATCH 2/6] Revert "platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM"

Started byJavier Martinez Canillas <javier@osg.samsung.com>
First post2015-08-19 13:30 +0200
Last post2015-08-21 19:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 2/6] Revert "platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM" Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-19 13:30 +0200
    Re: [PATCH 2/6] Revert "platform/chrome: Don't make CHROME_PLATFORMS  depends on X86 || ARM" Olof Johansson <olof@lixom.net> - 2015-08-21 19:20 +0200

#1209784 — [PATCH 2/6] Revert "platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM"

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2015-08-19 13:30 +0200
Subject[PATCH 2/6] Revert "platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM"
Message-ID<pZ9J7-4sk-1@gated-at.bofh.it>
This reverts commit d12bbcd3ea44 ("platform/chrome: Don't make
CHROME_PLATFORMS depends on X86 || ARM") since it was found to
not be the correct fix for the MFD_CROS_EC config unmet direct
dependencies warning.

The correct solution was to add the needed dependencies to the
MFD_CROS_EC symbol. Besides the revert, this patch extends the
CHROME_PLATFORMS symbol dependencies and adds || COMPILE_TEST
to allow drivers to have build coverage on other architectures.

Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/platform/chrome/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
index 3271cd1abe7c..21f4ea6c6c21 100644
--- a/drivers/platform/chrome/Kconfig
+++ b/drivers/platform/chrome/Kconfig
@@ -4,6 +4,7 @@
 
 menuconfig CHROME_PLATFORMS
 	bool "Platform support for Chrome hardware"
+	depends on X86 || ARM || COMPILE_TEST
 	---help---
 	  Say Y here to get to see options for platform support for
 	  various Chromebooks and Chromeboxes. This option alone does
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1211263 — Re: [PATCH 2/6] Revert "platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM"

FromOlof Johansson <olof@lixom.net>
Date2015-08-21 19:20 +0200
SubjectRe: [PATCH 2/6] Revert "platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM"
Message-ID<pZY8W-1FW-15@gated-at.bofh.it>
In reply to#1209784
On Wed, Aug 19, 2015 at 01:19:54PM +0200, Javier Martinez Canillas wrote:
> This reverts commit d12bbcd3ea44 ("platform/chrome: Don't make
> CHROME_PLATFORMS depends on X86 || ARM") since it was found to
> not be the correct fix for the MFD_CROS_EC config unmet direct
> dependencies warning.
> 
> The correct solution was to add the needed dependencies to the
> MFD_CROS_EC symbol. Besides the revert, this patch extends the
> CHROME_PLATFORMS symbol dependencies and adds || COMPILE_TEST
> to allow drivers to have build coverage on other architectures.
> 
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---

Applied, thanks.


-Olof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web