Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1208689 > unrolled thread
| Started by | Bjorn Andersson <bjorn.andersson@sonymobile.com> |
|---|---|
| First post | 2015-08-17 18:20 +0200 |
| Last post | 2015-08-17 18:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] watchdog: at91rm9200: Correct check for syscon_node_to_regmap() errors Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-08-17 18:20 +0200
Re: [PATCH] watchdog: at91rm9200: Correct check for syscon_node_to_regmap() errors Guenter Roeck <linux@roeck-us.net> - 2015-08-17 18:40 +0200
| From | Bjorn Andersson <bjorn.andersson@sonymobile.com> |
|---|---|
| Date | 2015-08-17 18:20 +0200 |
| Subject | [PATCH] watchdog: at91rm9200: Correct check for syscon_node_to_regmap() errors |
| Message-ID | <pYviG-402-5@gated-at.bofh.it> |
syscon_node_to_regmap() returns a regmap or an ERR_PTR(). Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> --- drivers/watchdog/at91rm9200_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/at91rm9200_wdt.c b/drivers/watchdog/at91rm9200_wdt.c index 9ba1153465ae..e12a797cb820 100644 --- a/drivers/watchdog/at91rm9200_wdt.c +++ b/drivers/watchdog/at91rm9200_wdt.c @@ -244,7 +244,7 @@ static int at91wdt_probe(struct platform_device *pdev) } regmap_st = syscon_node_to_regmap(parent->of_node); - if (!regmap_st) + if (IS_ERR(regmap_st)) return -ENODEV; res = misc_register(&at91wdt_miscdev); -- 1.8.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2015-08-17 18:40 +0200 |
| Subject | Re: [PATCH] watchdog: at91rm9200: Correct check for syscon_node_to_regmap() errors |
| Message-ID | <pYvC3-4n3-33@gated-at.bofh.it> |
| In reply to | #1208689 |
On 08/17/2015 09:19 AM, Bjorn Andersson wrote: > syscon_node_to_regmap() returns a regmap or an ERR_PTR(). > > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> Acked-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/at91rm9200_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/at91rm9200_wdt.c b/drivers/watchdog/at91rm9200_wdt.c > index 9ba1153465ae..e12a797cb820 100644 > --- a/drivers/watchdog/at91rm9200_wdt.c > +++ b/drivers/watchdog/at91rm9200_wdt.c > @@ -244,7 +244,7 @@ static int at91wdt_probe(struct platform_device *pdev) > } > > regmap_st = syscon_node_to_regmap(parent->of_node); > - if (!regmap_st) > + if (IS_ERR(regmap_st)) > return -ENODEV; > > res = misc_register(&at91wdt_miscdev); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web