Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208657 > unrolled thread

[RFT PATCH] ia64: generic_defconfig: convert to use libata PATA drivers

Started byBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
First post2015-08-17 17:50 +0200
Last post2015-08-17 19:30 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA drivers Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-08-17 17:50 +0200
    Re: [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA  drivers Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-08-17 18:20 +0200
      Re: [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA  drivers Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-08-17 18:40 +0200
        Re: [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA  drivers Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-08-17 19:30 +0200

#1208657 — [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA drivers

FromBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Date2015-08-17 17:50 +0200
Subject[RFT PATCH] ia64: generic_defconfig: convert to use libata PATA drivers
Message-ID<pYuPD-3cv-11@gated-at.bofh.it>
IDE subsystem has been deprecated since 2009 and the majority
(if not all) of Linux distributions have switched to use
libata for ATA support exclusively.  However there are still
some users (mostly old or/and embedded non-x86 systems) that
have not converted from using IDE subsystem to libata PATA
drivers.  This doesn't seem to be good thing in the long-term
for Linux as while there is less and less PATA systems left
in use:

* testing efforts are divided between two subsystems

* having duplicate drivers for same hardware confuses users

This patch converts generic_defconfig to use libata PATA
drivers (sgiioc4 IDE host driver has no corresponding libata
driver yet so it is not converted).

Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
Build tested only.
If you have affected hardware please test.  Thank you.

 arch/ia64/configs/generic_defconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/ia64/configs/generic_defconfig b/arch/ia64/configs/generic_defconfig
index 81f686d..f55be82 100644
--- a/arch/ia64/configs/generic_defconfig
+++ b/arch/ia64/configs/generic_defconfig
@@ -48,13 +48,10 @@ CONFIG_SGI_IOC4=y
 CONFIG_SGI_XP=m
 CONFIG_IDE=y
 CONFIG_BLK_DEV_IDECD=y
-CONFIG_BLK_DEV_GENERIC=y
-CONFIG_BLK_DEV_CMD64X=y
-CONFIG_BLK_DEV_PIIX=y
 CONFIG_BLK_DEV_SGIIOC4=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_CHR_DEV_ST=m
-CONFIG_BLK_DEV_SR=m
+CONFIG_BLK_DEV_SR=y
 CONFIG_CHR_DEV_SG=m
 CONFIG_SCSI_FC_ATTRS=y
 CONFIG_SCSI_SYM53C8XX_2=y
@@ -62,6 +59,9 @@ CONFIG_SCSI_QLOGIC_1280=y
 CONFIG_ATA=y
 CONFIG_ATA_PIIX=y
 CONFIG_SATA_VITESSE=y
+CONFIG_PATA_CMD64X=y
+CONFIG_PATA_MPIIX=y
+CONFIG_ATA_GENERIC=y
 CONFIG_MD=y
 CONFIG_BLK_DEV_MD=m
 CONFIG_MD_LINEAR=m
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1208697 — Re: [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA drivers

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2015-08-17 18:20 +0200
SubjectRe: [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA drivers
Message-ID<pYviH-402-35@gated-at.bofh.it>
In reply to#1208657
Hello.

On 08/17/2015 06:46 PM, Bartlomiej Zolnierkiewicz wrote:

> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively.  However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers.  This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts generic_defconfig to use libata PATA
> drivers (sgiioc4 IDE host driver has no corresponding libata
> driver yet so it is not converted).
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> Build tested only.
> If you have affected hardware please test.  Thank you.
>
>   arch/ia64/configs/generic_defconfig | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/ia64/configs/generic_defconfig b/arch/ia64/configs/generic_defconfig
> index 81f686d..f55be82 100644
> --- a/arch/ia64/configs/generic_defconfig
> +++ b/arch/ia64/configs/generic_defconfig
[...]
> @@ -62,6 +59,9 @@ CONFIG_SCSI_QLOGIC_1280=y
>   CONFIG_ATA=y
>   CONFIG_ATA_PIIX=y
>   CONFIG_SATA_VITESSE=y
> +CONFIG_PATA_CMD64X=y
> +CONFIG_PATA_MPIIX=y

    If you're enabling the MPIIX support (which I doubt is necessary), why not 
enable the "old" PIIX support?

> +CONFIG_ATA_GENERIC=y

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1208713 — Re: [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA drivers

FromBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Date2015-08-17 18:40 +0200
SubjectRe: [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA drivers
Message-ID<pYvC3-4n3-31@gated-at.bofh.it>
In reply to#1208697
Hi,

On Monday, August 17, 2015 07:19:06 PM Sergei Shtylyov wrote:
> Hello.
> 
> On 08/17/2015 06:46 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> > IDE subsystem has been deprecated since 2009 and the majority
> > (if not all) of Linux distributions have switched to use
> > libata for ATA support exclusively.  However there are still
> > some users (mostly old or/and embedded non-x86 systems) that
> > have not converted from using IDE subsystem to libata PATA
> > drivers.  This doesn't seem to be good thing in the long-term
> > for Linux as while there is less and less PATA systems left
> > in use:
> >
> > * testing efforts are divided between two subsystems
> >
> > * having duplicate drivers for same hardware confuses users
> >
> > This patch converts generic_defconfig to use libata PATA
> > drivers (sgiioc4 IDE host driver has no corresponding libata
> > driver yet so it is not converted).
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > ---
> > Build tested only.
> > If you have affected hardware please test.  Thank you.
> >
> >   arch/ia64/configs/generic_defconfig | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/ia64/configs/generic_defconfig b/arch/ia64/configs/generic_defconfig
> > index 81f686d..f55be82 100644
> > --- a/arch/ia64/configs/generic_defconfig
> > +++ b/arch/ia64/configs/generic_defconfig
> [...]
> > @@ -62,6 +59,9 @@ CONFIG_SCSI_QLOGIC_1280=y
> >   CONFIG_ATA=y
> >   CONFIG_ATA_PIIX=y
> >   CONFIG_SATA_VITESSE=y
> > +CONFIG_PATA_CMD64X=y
> > +CONFIG_PATA_MPIIX=y
> 
>     If you're enabling the MPIIX support (which I doubt is necessary), why not 

I also doubt that it is necessary but IDE's piix host driver
includes support for it (so after conversion MPIIX is also
enabled).

> enable the "old" PIIX support?

Oversight on my side, will fix.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1208746 — Re: [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA drivers

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2015-08-17 19:30 +0200
SubjectRe: [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA drivers
Message-ID<pYwoq-5xk-27@gated-at.bofh.it>
In reply to#1208713
On 08/17/2015 07:31 PM, Bartlomiej Zolnierkiewicz wrote:

>>> IDE subsystem has been deprecated since 2009 and the majority
>>> (if not all) of Linux distributions have switched to use
>>> libata for ATA support exclusively.  However there are still
>>> some users (mostly old or/and embedded non-x86 systems) that
>>> have not converted from using IDE subsystem to libata PATA
>>> drivers.  This doesn't seem to be good thing in the long-term
>>> for Linux as while there is less and less PATA systems left
>>> in use:
>>>
>>> * testing efforts are divided between two subsystems
>>>
>>> * having duplicate drivers for same hardware confuses users
>>>
>>> This patch converts generic_defconfig to use libata PATA
>>> drivers (sgiioc4 IDE host driver has no corresponding libata
>>> driver yet so it is not converted).
>>>
>>> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
[...]

>>> diff --git a/arch/ia64/configs/generic_defconfig b/arch/ia64/configs/generic_defconfig
>>> index 81f686d..f55be82 100644
>>> --- a/arch/ia64/configs/generic_defconfig
>>> +++ b/arch/ia64/configs/generic_defconfig
>> [...]
>>> @@ -62,6 +59,9 @@ CONFIG_SCSI_QLOGIC_1280=y
>>>    CONFIG_ATA=y
>>>    CONFIG_ATA_PIIX=y
>>>    CONFIG_SATA_VITESSE=y
>>> +CONFIG_PATA_CMD64X=y
>>> +CONFIG_PATA_MPIIX=y

>>      If you're enabling the MPIIX support (which I doubt is necessary), why not

> I also doubt that it is necessary but IDE's piix host driver
> includes support for it

    Borked. :-)

> (so after conversion MPIIX is also enabled).

    MPIIX was for laptops only, IIUC.

>> enable the "old" PIIX support?

> Oversight on my side, will fix.

> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web