Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208264 > unrolled thread

[PATCH 0/5] staging: fbtft: some checpatch.pl cleanups

Started byMike Rapoport <mike.rapoport@gmail.com>
First post2015-08-16 22:40 +0200
Last post2015-08-16 22:40 +0200
Articles 5 — 1 participant

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/5] staging: fbtft: some checpatch.pl cleanups  Mike Rapoport <mike.rapoport@gmail.com> - 2015-08-16 22:40 +0200
    [PATCH 5/5] staging: fbtft: fb_watterott: define backlight_ops statically Mike Rapoport <mike.rapoport@gmail.com> - 2015-08-16 22:40 +0200
    [PATCH 1/5] staging: fbtft: remove unused bl_ops from fbtft_unregister_backlight Mike Rapoport <mike.rapoport@gmail.com> - 2015-08-16 22:40 +0200
    [PATCH 4/5] staging: fbtft: fb_ssd1351: define backlight_ops statically Mike Rapoport <mike.rapoport@gmail.com> - 2015-08-16 22:40 +0200
    [PATCH 2/5] staging: fbtft: fbtft-core: define backlight_ops statically Mike Rapoport <mike.rapoport@gmail.com> - 2015-08-16 22:40 +0200

#1208264 — [PATCH 0/5] staging: fbtft: some checpatch.pl cleanups

FromMike Rapoport <mike.rapoport@gmail.com>
Date2015-08-16 22:40 +0200
Subject[PATCH 0/5] staging: fbtft: some checpatch.pl cleanups
Message-ID<pYcSJ-2zI-3@gated-at.bofh.it>
Hi,

These patches slightly refactor the code to reduce amount of checkpath.pl warnings

Mike Rapoport (5):
  staging: fbtft: remove unused bl_ops from fbtft_unregister_backlight
  staging: fbtft: fbtft-core: define backlight_ops statically
  staging: fbtft: fbtft_request_gpios: reduce nesting
  staging: fbtft: fb_ssd1351: define backlight_ops statically
  staging: fbtft: fb_watterott: define backlight_ops statically

 drivers/staging/fbtft/fb_ssd1351.c   | 13 +++----
 drivers/staging/fbtft/fb_watterott.c | 17 +++------
 drivers/staging/fbtft/fbtft-core.c   | 69 +++++++++++++++++-------------------
 3 files changed, 42 insertions(+), 57 deletions(-)

-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1208266 — [PATCH 5/5] staging: fbtft: fb_watterott: define backlight_ops statically

FromMike Rapoport <mike.rapoport@gmail.com>
Date2015-08-16 22:40 +0200
Subject[PATCH 5/5] staging: fbtft: fb_watterott: define backlight_ops statically
Message-ID<pYcSK-2zI-31@gated-at.bofh.it>
In reply to#1208264
instead of devm_kzalloc'ing them

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
---
 drivers/staging/fbtft/fb_watterott.c | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/fbtft/fb_watterott.c b/drivers/staging/fbtft/fb_watterott.c
index 88fb2c0..e8ebe2e 100644
--- a/drivers/staging/fbtft/fb_watterott.c
+++ b/drivers/staging/fbtft/fb_watterott.c
@@ -257,31 +257,24 @@ static int backlight_chip_update_status(struct backlight_device *bd)
 	return 0;
 }
 
+static const struct backlight_ops bl_ops = {
+	.update_status = backlight_chip_update_status,
+};
+
 static void register_chip_backlight(struct fbtft_par *par)
 {
 	struct backlight_device *bd;
 	struct backlight_properties bl_props = { 0, };
-	struct backlight_ops *bl_ops;
 
 	fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s()\n", __func__);
 
-	bl_ops = devm_kzalloc(par->info->device, sizeof(struct backlight_ops),
-				GFP_KERNEL);
-	if (!bl_ops) {
-		dev_err(par->info->device,
-			"%s: could not allocate memory for backlight operations.\n",
-			__func__);
-		return;
-	}
-
-	bl_ops->update_status = backlight_chip_update_status;
 	bl_props.type = BACKLIGHT_RAW;
 	bl_props.power = FB_BLANK_POWERDOWN;
 	bl_props.max_brightness = 100;
 	bl_props.brightness = DEFAULT_BRIGHTNESS;
 
 	bd = backlight_device_register(dev_driver_string(par->info->device),
-				par->info->device, par, bl_ops, &bl_props);
+				par->info->device, par, &bl_ops, &bl_props);
 	if (IS_ERR(bd)) {
 		dev_err(par->info->device,
 			"cannot register backlight device (%ld)\n",
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1208267 — [PATCH 1/5] staging: fbtft: remove unused bl_ops from fbtft_unregister_backlight

FromMike Rapoport <mike.rapoport@gmail.com>
Date2015-08-16 22:40 +0200
Subject[PATCH 1/5] staging: fbtft: remove unused bl_ops from fbtft_unregister_backlight
Message-ID<pYcSL-2zI-39@gated-at.bofh.it>
In reply to#1208264
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
---
 drivers/staging/fbtft/fbtft-core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 23392eb..bbc394a 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -270,14 +270,11 @@ static int fbtft_backlight_get_brightness(struct backlight_device *bd)
 
 void fbtft_unregister_backlight(struct fbtft_par *par)
 {
-	const struct backlight_ops *bl_ops;
-
 	fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s()\n", __func__);
 
 	if (par->info->bl_dev) {
 		par->info->bl_dev->props.power = FB_BLANK_POWERDOWN;
 		backlight_update_status(par->info->bl_dev);
-		bl_ops = par->info->bl_dev->ops;
 		backlight_device_unregister(par->info->bl_dev);
 		par->info->bl_dev = NULL;
 	}
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1208268 — [PATCH 4/5] staging: fbtft: fb_ssd1351: define backlight_ops statically

FromMike Rapoport <mike.rapoport@gmail.com>
Date2015-08-16 22:40 +0200
Subject[PATCH 4/5] staging: fbtft: fb_ssd1351: define backlight_ops statically
Message-ID<pYcSL-2zI-35@gated-at.bofh.it>
In reply to#1208264
instead of devm_kzalloc'ing them

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
---
 drivers/staging/fbtft/fb_ssd1351.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c
index 9bcd7a0..dff5809 100644
--- a/drivers/staging/fbtft/fb_ssd1351.c
+++ b/drivers/staging/fbtft/fb_ssd1351.c
@@ -208,25 +208,22 @@ static int update_onboard_backlight(struct backlight_device *bd)
 	return 0;
 }
 
+static const struct backlight_ops bl_ops = {
+	.update_status = update_onboard_backlight,
+};
+
 static void register_onboard_backlight(struct fbtft_par *par)
 {
 	struct backlight_device *bd;
 	struct backlight_properties bl_props = { 0, };
-	struct backlight_ops *bl_ops;
 
 	fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s()\n", __func__);
 
-	bl_ops = devm_kzalloc(par->info->device, sizeof(struct backlight_ops),
-				GFP_KERNEL);
-	if (!bl_ops)
-		return;
-
-	bl_ops->update_status = update_onboard_backlight;
 	bl_props.type = BACKLIGHT_RAW;
 	bl_props.power = FB_BLANK_POWERDOWN;
 
 	bd = backlight_device_register(dev_driver_string(par->info->device),
-				par->info->device, par, bl_ops, &bl_props);
+				par->info->device, par, &bl_ops, &bl_props);
 	if (IS_ERR(bd)) {
 		dev_err(par->info->device,
 			"cannot register backlight device (%ld)\n",
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1208269 — [PATCH 2/5] staging: fbtft: fbtft-core: define backlight_ops statically

FromMike Rapoport <mike.rapoport@gmail.com>
Date2015-08-16 22:40 +0200
Subject[PATCH 2/5] staging: fbtft: fbtft-core: define backlight_ops statically
Message-ID<pYcSL-2zI-37@gated-at.bofh.it>
In reply to#1208264
instead of devm_kzalloc'ing them

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
---
 drivers/staging/fbtft/fbtft-core.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index bbc394a..81ba416 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -280,11 +280,15 @@ void fbtft_unregister_backlight(struct fbtft_par *par)
 	}
 }
 
+static const struct backlight_ops fbtft_bl_ops = {
+	.get_brightness	= fbtft_backlight_get_brightness,
+	.update_status	= fbtft_backlight_update_status,
+};
+
 void fbtft_register_backlight(struct fbtft_par *par)
 {
 	struct backlight_device *bd;
 	struct backlight_properties bl_props = { 0, };
-	struct backlight_ops *bl_ops;
 
 	fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s()\n", __func__);
 
@@ -294,13 +298,6 @@ void fbtft_register_backlight(struct fbtft_par *par)
 		return;
 	}
 
-	bl_ops = devm_kzalloc(par->info->device, sizeof(struct backlight_ops),
-				GFP_KERNEL);
-	if (!bl_ops)
-		return;
-
-	bl_ops->get_brightness = fbtft_backlight_get_brightness;
-	bl_ops->update_status = fbtft_backlight_update_status;
 	bl_props.type = BACKLIGHT_RAW;
 	/* Assume backlight is off, get polarity from current state of pin */
 	bl_props.power = FB_BLANK_POWERDOWN;
@@ -308,7 +305,7 @@ void fbtft_register_backlight(struct fbtft_par *par)
 		bl_props.state |= BL_CORE_DRIVER1;
 
 	bd = backlight_device_register(dev_driver_string(par->info->device),
-				par->info->device, par, bl_ops, &bl_props);
+				par->info->device, par, &fbtft_bl_ops, &bl_props);
 	if (IS_ERR(bd)) {
 		dev_err(par->info->device,
 			"cannot register backlight device (%ld)\n",
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web