Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208155 > unrolled thread

Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg Wolfram Sang <wsa@the-dreams.de> - 2015-08-15 22:30 +0200
    Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg Wolfram Sang <wsa@the-dreams.de> - 2015-08-18 18:50 +0200

#1208155 — Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg

On Tue, Jun 16, 2015 at 10:28:12AM -0700, York Sun wrote:
> Based on i2c-mux-gpio driver, similarly the register based mux
> switch from one bus to another by setting a single register.
> The register can be on PCIe bus, local bus, or any memory-mapped
> address.
> 
> Signed-off-by: York Sun <yorksun@freescale.com>
> CC: Wolfram Sang <wsa@the-dreams.de>
> CC: Peter Korsgaard <peter.korsgaard@barco.com>

Mostly good.

> +static int i2c_mux_reg_probe(struct platform_device *pdev)
> +{
> +	struct regmux *mux;
> +	struct i2c_adapter *parent;
> +	struct resource *res;
> +	int (*deselect)(struct i2c_adapter *, void *, u32);
> +	unsigned int initial_state, class;

gcc says:

drivers/i2c/muxes/i2c-mux-reg.c:182:15: warning: variable 'initial_state' set but not used [-Wunused-but-set-variable]

It seens you prepared for setting the initial state but don't do the
actual set?

> +static struct platform_driver i2c_mux_reg_driver = {
> +	.probe	= i2c_mux_reg_probe,
> +	.remove	= i2c_mux_reg_remove,
> +	.driver	= {
> +		.owner	= THIS_MODULE,

coccicheck says:

drivers/i2c/muxes/i2c-mux-reg.c:288:3-8: No need to set .owner here. The core will do it.

> +		.name	= "i2c-mux-reg",
> +	},
> +};

Thanks,

   Wolfram

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1209350

[Multipart message — attachments visible in raw view] — view raw

> unused-but-set-variable by default. How did you enable this warning without
> being flooded by the warnings? (I tried W=1)

I use W=1. To prevent flooding, I used to replace all -I with -isystem
in the Kernel Makefile, but sadly this doesn't work anymore. And I had
no time to investigate why.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web