Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1205391 > unrolled thread
| Started by | Murali Karicheri <m-karicheri2@ti.com> |
|---|---|
| First post | 2015-08-11 21:20 +0200 |
| Last post | 2015-08-17 16:20 +0200 |
| Articles | 2 on this page of 22 — 7 participants |
Back to article view | Back to linux.kernel
[PATCH] ARM: keystone: add a work around to handle asynchronous external abort Murali Karicheri <m-karicheri2@ti.com> - 2015-08-11 21:20 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-14 16:10 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Lucas Stach <l.stach@pengutronix.de> - 2015-08-14 16:30 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Murali Karicheri <m-karicheri2@ti.com> - 2015-08-15 00:00 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-15 00:00 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Murali Karicheri <m-karicheri2@ti.com> - 2015-08-17 16:20 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-08-14 17:20 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-15 00:00 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Murali Karicheri <m-karicheri2@ti.com> - 2015-08-18 00:20 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-18 00:50 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> - 2015-08-18 05:20 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-18 10:20 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Lucas Stach <l.stach@pengutronix.de> - 2015-08-18 10:30 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Afzal Mohammed <afzal.mohd.ma@gmail.com> - 2015-08-18 14:10 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Jisheng Zhang <jszhang@marvell.com> - 2015-08-18 10:40 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Murali Karicheri <m-karicheri2@ti.com> - 2015-08-18 17:00 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Murali Karicheri <m-karicheri2@ti.com> - 2015-08-18 22:30 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Murali Karicheri <m-karicheri2@ti.com> - 2015-08-15 00:00 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> - 2015-08-15 02:10 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Murali Karicheri <m-karicheri2@ti.com> - 2015-08-14 16:10 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Lucas Stach <l.stach@pengutronix.de> - 2015-08-14 16:20 +0200
Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort Murali Karicheri <m-karicheri2@ti.com> - 2015-08-17 16:20 +0200
Page 2 of 2 — ← Prev page 1 [2]
| From | Lucas Stach <l.stach@pengutronix.de> |
|---|---|
| Date | 2015-08-14 16:20 +0200 |
| Subject | Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort |
| Message-ID | <pXnZU-4sx-5@gated-at.bofh.it> |
| In reply to | #1207557 |
Am Freitag, den 14.08.2015, 10:04 -0400 schrieb Murali Karicheri:
> On 08/11/2015 03:13 PM, Murali Karicheri wrote:
> > Currently on some devices, an asynchronous external abort exception
> > happens during boot up when exception handlers are enabled in kernel
> > before switching to user space. This patch adds a workaround to handle
> > this once during boot. Many customers are already using this
> > with out any issues and is required to workaround the above issue.
> >
> > Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> > ---
> > arch/arm/mach-keystone/keystone.c | 26 ++++++++++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> >
> > diff --git a/arch/arm/mach-keystone/keystone.c b/arch/arm/mach-keystone/keystone.c
> > index e2880105..c1d0fe5 100644
> > --- a/arch/arm/mach-keystone/keystone.c
> > +++ b/arch/arm/mach-keystone/keystone.c
> > @@ -15,6 +15,7 @@
> > #include <linux/of_platform.h>
> > #include <linux/of_address.h>
> > #include <linux/memblock.h>
> > +#include <linux/signal.h>
> >
> > #include <asm/setup.h>
> > #include <asm/mach/map.h>
> > @@ -52,6 +53,24 @@ static struct notifier_block platform_nb = {
> > .notifier_call = keystone_platform_notifier,
> > };
> >
> > +static bool ignore_first = true;
> > +static int keystone_async_ext_abort_fault(unsigned long addr, unsigned int fsr,
> > + struct pt_regs *regs)
> > +{
> > + /*
> > + * if first time, ignore this as this is a asynchronous external abort
> > + * happening only some devices that couldn't be root caused and we add
> > + * this work around to handle this first time.
> > + */
> > + if (ignore_first) {
> > + ignore_first = false;
> > + return 0;
> > + }
> > +
> > + /* Subsequent ones should be handled as fault */
> > + return 1;
> > +}
> > +
> > static void __init keystone_init(void)
> > {
> > if (PHYS_OFFSET >= KEYSTONE_HIGH_PHYS_START) {
> > @@ -61,6 +80,13 @@ static void __init keystone_init(void)
> > }
> > keystone_pm_runtime_init();
> > of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> > +
> > + /*
> > + * Add a one time exception handler to catch asynchronous external
> > + * abort
> > + */
> > + hook_fault_code(17, keystone_async_ext_abort_fault, SIGBUS, 0,
> > + "async external abort handler");
> > }
> >
> > static phys_addr_t keystone_virt_to_idmap(unsigned long x)
> >
> Can this be applied if it looks good?
>
The keystone PCIe host driver already hooks the same fault code. Those
hooks are no chain, but a simple pointer, so one of those handlers is
going to loose out.
This likely isn't what you intended.
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Murali Karicheri <m-karicheri2@ti.com> |
|---|---|
| Date | 2015-08-17 16:20 +0200 |
| Subject | Re: [PATCH] ARM: keystone: add a work around to handle asynchronous external abort |
| Message-ID | <pYtqx-1im-9@gated-at.bofh.it> |
| In reply to | #1207559 |
On 08/14/2015 10:11 AM, Lucas Stach wrote:
> Am Freitag, den 14.08.2015, 10:04 -0400 schrieb Murali Karicheri:
>> On 08/11/2015 03:13 PM, Murali Karicheri wrote:
>>> Currently on some devices, an asynchronous external abort exception
>>> happens during boot up when exception handlers are enabled in kernel
>>> before switching to user space. This patch adds a workaround to handle
>>> this once during boot. Many customers are already using this
>>> with out any issues and is required to workaround the above issue.
>>>
>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>> ---
>>> arch/arm/mach-keystone/keystone.c | 26 ++++++++++++++++++++++++++
>>> 1 file changed, 26 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-keystone/keystone.c b/arch/arm/mach-keystone/keystone.c
>>> index e2880105..c1d0fe5 100644
>>> --- a/arch/arm/mach-keystone/keystone.c
>>> +++ b/arch/arm/mach-keystone/keystone.c
>>> @@ -15,6 +15,7 @@
>>> #include <linux/of_platform.h>
>>> #include <linux/of_address.h>
>>> #include <linux/memblock.h>
>>> +#include <linux/signal.h>
>>>
>>> #include <asm/setup.h>
>>> #include <asm/mach/map.h>
>>> @@ -52,6 +53,24 @@ static struct notifier_block platform_nb = {
>>> .notifier_call = keystone_platform_notifier,
>>> };
>>>
>>> +static bool ignore_first = true;
>>> +static int keystone_async_ext_abort_fault(unsigned long addr, unsigned int fsr,
>>> + struct pt_regs *regs)
>>> +{
>>> + /*
>>> + * if first time, ignore this as this is a asynchronous external abort
>>> + * happening only some devices that couldn't be root caused and we add
>>> + * this work around to handle this first time.
>>> + */
>>> + if (ignore_first) {
>>> + ignore_first = false;
>>> + return 0;
>>> + }
>>> +
>>> + /* Subsequent ones should be handled as fault */
>>> + return 1;
>>> +}
>>> +
>>> static void __init keystone_init(void)
>>> {
>>> if (PHYS_OFFSET >= KEYSTONE_HIGH_PHYS_START) {
>>> @@ -61,6 +80,13 @@ static void __init keystone_init(void)
>>> }
>>> keystone_pm_runtime_init();
>>> of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
>>> +
>>> + /*
>>> + * Add a one time exception handler to catch asynchronous external
>>> + * abort
>>> + */
>>> + hook_fault_code(17, keystone_async_ext_abort_fault, SIGBUS, 0,
>>> + "async external abort handler");
>>> }
>>>
>>> static phys_addr_t keystone_virt_to_idmap(unsigned long x)
>>>
>> Can this be applied if it looks good?
>>
> The keystone PCIe host driver already hooks the same fault code. Those
> hooks are no chain, but a simple pointer, so one of those handlers is
> going to loose out.
>
> This likely isn't what you intended.
You are right. I will try to debug this further based on your patch and
as per RMK's suggestion.
Thanks and regards,
Murali
>
> Regards,
> Lucas
>
--
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Page 2 of 2 — ← Prev page 1 [2]
Back to top | Article view | linux.kernel
csiph-web