Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1205012 > unrolled thread
| Started by | Krzysztof Kozlowski <k.kozlowski.k@gmail.com> |
|---|---|
| First post | 2015-08-11 12:20 +0200 |
| Last post | 2015-08-14 11:50 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2 0/3] mfd: EXYNOS: Properly shutdown Odroid XU3 Krzysztof Kozlowski <k.kozlowski.k@gmail.com> - 2015-08-11 12:20 +0200
[PATCH v2 3/3] ARM: dts: Fix power off method on exynos5422-odroidxu3 Krzysztof Kozlowski <k.kozlowski.k@gmail.com> - 2015-08-11 12:20 +0200
[PATCH v2 1/3] mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11 Krzysztof Kozlowski <k.kozlowski.k@gmail.com> - 2015-08-11 12:20 +0200
RE: [PATCH v2 1/3] mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11 Kukjin Kim <kgene@kernel.org> - 2015-08-14 11:50 +0200
| From | Krzysztof Kozlowski <k.kozlowski.k@gmail.com> |
|---|---|
| Date | 2015-08-11 12:20 +0200 |
| Subject | [PATCH v2 0/3] mfd: EXYNOS: Properly shutdown Odroid XU3 |
| Message-ID | <pWeP0-27X-11@gated-at.bofh.it> |
Hi, Changelog put in each patch message. This fixes shutdown of Odroid XU3 family. More details in patch 2. Patches are independent, please pick up freely. Best regards, Krzysztof Krzysztof Kozlowski (3): mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11 mfd: s2mps11: Add manual shutdown method for Odroid XU3 ARM: dts: Fix power off method on exynos5422-odroidxu3 Documentation/devicetree/bindings/mfd/s2mps11.txt | 4 +++ arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 + drivers/mfd/sec-core.c | 30 ++++++++++++++++++++++ include/linux/mfd/samsung/core.h | 2 ++ include/linux/mfd/samsung/s2mps11.h | 1 + 5 files changed, 38 insertions(+) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski.k@gmail.com> |
|---|---|
| Date | 2015-08-11 12:20 +0200 |
| Subject | [PATCH v2 3/3] ARM: dts: Fix power off method on exynos5422-odroidxu3 |
| Message-ID | <pWeP0-27X-9@gated-at.bofh.it> |
| In reply to | #1205012 |
The Odroid XU3 family boards have ACOKB pin of PMIC grounded, instead of pulled up as usual. This means that PMIC must manually set PWRHOLD field in its CTRL1 register to low before initiating power down. This fixes Odroid XU3 powering off: [ 25.966053] reboot: Power down [ 25.967679] Power down. [ 26.070174] Power down failed, please power off system manually. Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com> Reported-by: Anand Moon <linux.amoon@gmail.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> --- Changes since v1: 1. Add Javier's reviewed-by. --- arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi index 1565667e6f69..48cecc8cf26e 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi @@ -159,6 +159,7 @@ s2mps11,buck2-ramp-enable = <1>; s2mps11,buck3-ramp-enable = <1>; s2mps11,buck4-ramp-enable = <1>; + samsung,s2mps11-acokb-ground; interrupt-parent = <&gpx0>; interrupts = <4 IRQ_TYPE_EDGE_FALLING>; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski.k@gmail.com> |
|---|---|
| Date | 2015-08-11 12:20 +0200 |
| Subject | [PATCH v2 1/3] mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11 |
| Message-ID | <pWeP1-27X-55@gated-at.bofh.it> |
| In reply to | #1205012 |
Document a new Device Tree property 'samsung,s2mps11-acokb-ground' indicating that ACOKB pin of S2MPS11 PMIC is connected to the ground so the PMIC must manually set PWRHOLD bit in CTRL1 register to turn off the power. Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Acked-by: Lee Jones <lee.jones@linaro.org> --- Changes since v1: 1. Split bindings documentation to separate patch (suggested by Lee). 2. Add Javier's reviewed-by and Lee's acked-by. --- Documentation/devicetree/bindings/mfd/s2mps11.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt index 57a045016fca..90eaef393325 100644 --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt @@ -15,6 +15,10 @@ Optional properties: - interrupt-parent: Specifies the phandle of the interrupt controller to which the interrupts from s2mps11 are delivered to. - interrupts: Interrupt specifiers for interrupt sources. +- samsung,s2mps11-acokb-ground: Indicates that ACOKB pin of S2MPS11 PMIC is + connected to the ground so the PMIC must manually set PWRHOLD bit in CTRL1 + register to turn off the power. Usually the ACOKB is pulled up to VBATT so + when PWRHOLD pin goes low, the rising ACOKB will trigger power off. Optional nodes: - clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768 -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Kukjin Kim <kgene@kernel.org> |
|---|---|
| Date | 2015-08-14 11:50 +0200 |
| Subject | RE: [PATCH v2 1/3] mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11 |
| Message-ID | <pXjMC-6Km-1@gated-at.bofh.it> |
| In reply to | #1205016 |
Krzysztof Kozlowski wrote: > > Document a new Device Tree property 'samsung,s2mps11-acokb-ground' > indicating that ACOKB pin of S2MPS11 PMIC is connected to the ground so > the PMIC must manually set PWRHOLD bit in CTRL1 register to turn off the > power. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > Acked-by: Lee Jones <lee.jones@linaro.org> > > --- > > Changes since v1: > 1. Split bindings documentation to separate patch (suggested by Lee). > 2. Add Javier's reviewed-by and Lee's acked-by. > --- > Documentation/devicetree/bindings/mfd/s2mps11.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt > b/Documentation/devicetree/bindings/mfd/s2mps11.txt > index 57a045016fca..90eaef393325 100644 > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt > @@ -15,6 +15,10 @@ Optional properties: > - interrupt-parent: Specifies the phandle of the interrupt controller to which > the interrupts from s2mps11 are delivered to. > - interrupts: Interrupt specifiers for interrupt sources. > +- samsung,s2mps11-acokb-ground: Indicates that ACOKB pin of S2MPS11 PMIC is > + connected to the ground so the PMIC must manually set PWRHOLD bit in CTRL1 > + register to turn off the power. Usually the ACOKB is pulled up to VBATT so > + when PWRHOLD pin goes low, the rising ACOKB will trigger power off. > > Optional nodes: > - clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768 > -- > 2.1.4 Applied 1/3 and 3/3. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web