Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1206469 > unrolled thread

[PATCH] power: align wakeup_sources format

Started by<check.kernel@gmail.com>
First post2015-08-13 04:30 +0200
Last post2015-08-14 11:00 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] power: align wakeup_sources format <check.kernel@gmail.com> - 2015-08-13 04:30 +0200
    Re: [PATCH] power: align wakeup_sources format "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-08-14 10:40 +0200
      Re: [PATCH] power: align wakeup_sources format 杜慧 <duhui@xiaomi.com> - 2015-08-14 11:00 +0200

#1206469 — [PATCH] power: align wakeup_sources format

From<check.kernel@gmail.com>
Date2015-08-13 04:30 +0200
Subject[PATCH] power: align wakeup_sources format
Message-ID<pWQrf-6Be-3@gated-at.bofh.it>
From: yangdongdong <yangdongdong@xiaomi.com>

This aligns every column of elements in wakeup_sources to
conveniently check any specific column for suspicious power
consumption wakeup source or for other easily readable purpose.

Signed-off-by: yangdongdong <yangdongdong@xiaomi.com>
---
 drivers/base/power/wakeup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
index 51f15bc..b6fe9e6 100644
--- a/drivers/base/power/wakeup.c
+++ b/drivers/base/power/wakeup.c
@@ -998,7 +998,7 @@ static int print_wakeup_source_stats(struct seq_file *m,
 		active_time = ktime_set(0, 0);
 	}
 
-	seq_printf(m, "%-12s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
+	seq_printf(m, "%-32s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
 		   ws->name, active_count, ws->event_count,
 		   ws->wakeup_count, ws->expire_count,
 		   ktime_to_ms(active_time), ktime_to_ms(total_time),
@@ -1018,7 +1018,7 @@ static int wakeup_sources_stats_show(struct seq_file *m, void *unused)
 {
 	struct wakeup_source *ws;
 
-	seq_puts(m, "name\t\tactive_count\tevent_count\twakeup_count\t"
+	seq_puts(m, "name\t\t\t\t\tactive_count\tevent_count\twakeup_count\t"
 		"expire_count\tactive_since\ttotal_time\tmax_time\t"
 		"last_change\tprevent_suspend_time\n");
 
-- 
2.5.0

The signed name has been updated.

Thanks,
yangdongdong

On Wed, Aug 12, 2015 at 02:12:38PM +0800, check.kernel@gmail.com wrote:
> From: yangdongdong <yangdongdong@xiaomi.com>

As mentioned before, please fix this.

The signed name is updated from "Andy Yang" to yangdongdong.

Best Regards,
Andy

On Wed, Aug 12, 2015 at 12:31:14PM +0800, check.kernel@gmail.com wrote:
> From: yangdongdong <yangdongdong@xiaomi.com>

Use the same name here as you used for the signed-off-by: line please.

Please fix and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1207405

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2015-08-14 10:40 +0200
Message-ID<pXiGR-5dY-13@gated-at.bofh.it>
In reply to#1206469
On Thursday, August 13, 2015 10:24:49 AM check.kernel@gmail.com wrote:
> From: yangdongdong <yangdongdong@xiaomi.com>
> 
> This aligns every column of elements in wakeup_sources to
> conveniently check any specific column for suspicious power
> consumption wakeup source or for other easily readable purpose.
> 
> Signed-off-by: yangdongdong <yangdongdong@xiaomi.com>

Is yangdongdong your real name, ie. one you would use when checking in
at a hotel etc.?  If not, it is not appropriate for signing off a patch.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1207425

From杜慧 <duhui@xiaomi.com>
Date2015-08-14 11:00 +0200
Message-ID<pXj0e-5AB-11@gated-at.bofh.it>
In reply to#1207405
VGhhdCBpcyBoZXIgZnVsbCBuYW1lOikKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fXwpGcm9tOiBSYWZhZWwgSi4gV3lzb2NraSA8cmp3QHJqd3lzb2NraS5uZXQ+ClNlbnQ6
IEZyaWRheSwgQXVndXN0IDE0LCAyMDE1IDE2OjU5ClRvOiBjaGVjay5rZXJuZWxAZ21haWwuY29t
CkNjOiBHcmVnIEtyb2FoLUhhcnRtYW47IExlbiBCcm93bjsgUGF2ZWwgTWFjaGVrOyC2xbvbOyC5
y8Hou6o7IGxpbnV4LXBtQHZnZXIua2VybmVsLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVs
Lm9yZzsg0e62rLarClN1YmplY3Q6IFJlOiBbUEFUQ0hdIHBvd2VyOiBhbGlnbiB3YWtldXBfc291
cmNlcyBmb3JtYXQKCk9uIFRodXJzZGF5LCBBdWd1c3QgMTMsIDIwMTUgMTA6MjQ6NDkgQU0gY2hl
Y2sua2VybmVsQGdtYWlsLmNvbSB3cm90ZToKPiBGcm9tOiB5YW5nZG9uZ2RvbmcgPHlhbmdkb25n
ZG9uZ0B4aWFvbWkuY29tPgo+Cj4gVGhpcyBhbGlnbnMgZXZlcnkgY29sdW1uIG9mIGVsZW1lbnRz
IGluIHdha2V1cF9zb3VyY2VzIHRvCj4gY29udmVuaWVudGx5IGNoZWNrIGFueSBzcGVjaWZpYyBj
b2x1bW4gZm9yIHN1c3BpY2lvdXMgcG93ZXIKPiBjb25zdW1wdGlvbiB3YWtldXAgc291cmNlIG9y
IGZvciBvdGhlciBlYXNpbHkgcmVhZGFibGUgcHVycG9zZS4KPgo+IFNpZ25lZC1vZmYtYnk6IHlh
bmdkb25nZG9uZyA8eWFuZ2Rvbmdkb25nQHhpYW9taS5jb20+CgpJcyB5YW5nZG9uZ2RvbmcgeW91
ciByZWFsIG5hbWUsIGllLiBvbmUgeW91IHdvdWxkIHVzZSB3aGVuIGNoZWNraW5nIGluCmF0IGEg
aG90ZWwgZXRjLj8gIElmIG5vdCwgaXQgaXMgbm90IGFwcHJvcHJpYXRlIGZvciBzaWduaW5nIG9m
ZiBhIHBhdGNoLgoKVGhhbmtzLApSYWZhZWwK
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web