Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1207160 > unrolled thread
| Started by | Li Yang <leoli@freescale.com> |
|---|---|
| First post | 2015-08-13 23:00 +0200 |
| Last post | 2015-08-17 21:20 +0200 |
| Articles | 7 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support Li Yang <leoli@freescale.com> - 2015-08-13 23:00 +0200
RE: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support Yao Yuan <yao.yuan@freescale.com> - 2015-08-14 08:30 +0200
Re: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support Li Yang <leoli@freescale.com> - 2015-08-15 01:50 +0200
RE: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support Yao Yuan <yao.yuan@freescale.com> - 2015-08-17 06:00 +0200
Re: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support Nigel Cunningham <nigel@nigelcunningham.com.au> - 2015-08-17 09:00 +0200
RE: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support Yao Yuan <yao.yuan@freescale.com> - 2015-08-17 09:30 +0200
Re: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support Li Yang <leoli@freescale.com> - 2015-08-17 21:20 +0200
| From | Li Yang <leoli@freescale.com> |
|---|---|
| Date | 2015-08-13 23:00 +0200 |
| Subject | Re: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support |
| Message-ID | <pX7Ls-6dP-11@gated-at.bofh.it> |
On Tue, Jul 21, 2015 at 3:56 AM, Yuan Yao <yao.yuan@freescale.com> wrote: > This add power management suspend/resume support for the fsl-edma > driver. > > eDMA acted as a basic function used by others. What it needs to do is > the two steps below to support power management. > > In fsl_edma_suspend_late: > Check whether the DMA chan is idle and if it is not idle, stop PM > operation. You should try to quiesce the device on suspend instead of depending on itself to be happen in idle and failing if it is not. Regards, Leo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Yao Yuan <yao.yuan@freescale.com> |
|---|---|
| Date | 2015-08-14 08:30 +0200 |
| Message-ID | <pXgF4-2ma-1@gated-at.bofh.it> |
| In reply to | #1207160 |
SGkgTGVvLA0KDQpUaGFua3MgZm9yIHlvdXIgcmV2aWV3Lg0KQWJvdXQgdGhvc2UgdHdvIG1ldGhv ZHMgZm9yIERNQSBzdXNwZW5kIHRoYXQgeW91IGhhdmUgbWVudGlvbmVkLiBXZSBoYXZlIGEgbG90 IG9mIHRoZSBkaXNjdXNzaW9ucyBpbiBvdGhlciBETUEgZHJpdmVyIGxpa2UgRE1BIGZvciBGcmVl c2NhbGUgUG93ZXJQQy4NCg0KRmluYWxseSwgd2UgdGhpbmsgdGhlIGRldmljZSB3aGljaCB1c2Vk IHRoZSBETUEgdHJhbnNtaXNzaW9uIHNlcnZpY2Ugc2hvdWxkIGNhbmNlbCB0aGUgdHJhbnNtaXNz aW9uIHNlcnZpY2UgaW4gaXRzIHN1c3BlbmQuIA0KU28gRE1BIGluIHN1c3BlbmQgc2hvdWxkIGJl IGlkbGUuDQoNCk9uY2UgdGhlIERNQSBpbiBsYXRlX3N1c3BlbmQgaXMgbm90IGJlIGlkbGUsIHdl IHRoaW5rIHNvbWUgZHJpdmVyIGhhdmVuJ3QgY2FuY2VsZWQgdGhlIERNQSB0cmFuc21pc3Npb24u IFNvIG1heWJlIHNvbWV0aGluZyBpcyBlcnJvciB3aGVuIG90aGVyIGRyaXZlciBpbiBzdXNwZW5k Lg0KDQpJbiB0aGUgY2FzZSwgd2Ugc2hvdWxkIHJldHVybiBmYWlsZWQgdG8gc3RvcCBQTS4gRE1B IHNob3VsZCBub3QgbWFrZSBhIGNob2ljZSBmb3Igb3RoZXIgZHJpdmVycyh3aGljaCB1c2VkIERN QSkgdG8gZm9yY2Ugc3RvcCBETUEgdHJhbnNtaXNzaW9uLg0KDQpUaGFua3MuDQoNCkJlc3QgUmVn YXJkcywNCll1YW4gWWFvDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTog cGt1Lmxlb0BnbWFpbC5jb20gW21haWx0bzpwa3UubGVvQGdtYWlsLmNvbV0gT24gQmVoYWxmIE9m IExpIFlhbmcNCj4gU2VudDogRnJpZGF5LCBBdWd1c3QgMTQsIDIwMTUgNDo1OCBBTQ0KPiBUbzog WXVhbiBZYW8tQjQ2NjgzDQo+IENjOiBWaW5vZCBLb3VsOyBzdGVmYW5AYWduZXIuY2g7IEFybmQg QmVyZ21hbm47IERhbiBXaWxsaWFtczsNCj4gZG1hZW5naW5lQHZnZXIua2VybmVsLm9yZzsgbGtt bDsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnOyBsaW51eC0NCj4gcG1Admdl ci5rZXJuZWwub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjJdIGRtYWVuZ2luZTogZnNsLWVk bWE6IGFkZCBQTSBzdXNwZW5kL3Jlc3VtZQ0KPiBzdXBwb3J0DQo+IA0KPiBPbiBUdWUsIEp1bCAy MSwgMjAxNSBhdCAzOjU2IEFNLCBZdWFuIFlhbyA8eWFvLnl1YW5AZnJlZXNjYWxlLmNvbT4gd3Jv dGU6DQo+ID4gVGhpcyBhZGQgcG93ZXIgbWFuYWdlbWVudCBzdXNwZW5kL3Jlc3VtZSBzdXBwb3J0 IGZvciB0aGUgZnNsLWVkbWENCj4gPiBkcml2ZXIuDQo+ID4NCj4gPiBlRE1BIGFjdGVkIGFzIGEg YmFzaWMgZnVuY3Rpb24gdXNlZCBieSBvdGhlcnMuIFdoYXQgaXQgbmVlZHMgdG8gZG8gaXMNCj4g PiB0aGUgdHdvIHN0ZXBzIGJlbG93IHRvIHN1cHBvcnQgcG93ZXIgbWFuYWdlbWVudC4NCj4gPg0K PiA+IEluIGZzbF9lZG1hX3N1c3BlbmRfbGF0ZToNCj4gPiBDaGVjayB3aGV0aGVyIHRoZSBETUEg Y2hhbiBpcyBpZGxlIGFuZCBpZiBpdCBpcyBub3QgaWRsZSwgc3RvcCBQTQ0KPiA+IG9wZXJhdGlv bi4NCj4gDQo+IFlvdSBzaG91bGQgdHJ5IHRvIHF1aWVzY2UgdGhlIGRldmljZSBvbiBzdXNwZW5k IGluc3RlYWQgb2YgZGVwZW5kaW5nIG9uIGl0c2VsZg0KPiB0byBiZSBoYXBwZW4gaW4gaWRsZSBh bmQgZmFpbGluZyBpZiBpdCBpcyBub3QuDQo+IA0KPiBSZWdhcmRzLA0KPiBMZW8NCg== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Li Yang <leoli@freescale.com> |
|---|---|
| Date | 2015-08-15 01:50 +0200 |
| Message-ID | <pXwTv-fI-3@gated-at.bofh.it> |
| In reply to | #1207347 |
On Fri, Aug 14, 2015 at 1:24 AM, Yao Yuan <yao.yuan@freescale.com> wrote: > Hi Leo, > > Thanks for your review. > About those two methods for DMA suspend that you have mentioned. We have a lot of the discussions in other DMA driver like DMA for Freescale PowerPC. > > Finally, we think the device which used the DMA transmission service should cancel the transmission service in its suspend. > So DMA in suspend should be idle. If that's the case you should clearly state this in the commit message and in code, although I don't know if it is safe to make such assumption. There could be user of the DMA that doesn't track the completion of transfers. > > Once the DMA in late_suspend is not be idle, we think some driver haven't canceled the DMA transmission. So maybe something is error when other driver in suspend. > > In the case, we should return failed to stop PM. DMA should not make a choice for other drivers(which used DMA) to force stop DMA transmission. The suspend entrance should be terminated by wakeup events and only critical issues. I don't think we should just terminate the suspend entrance just because having on-going I/O without even try to stop it. > > Thanks. > > Best Regards, > Yuan Yao > >> -----Original Message----- >> From: pku.leo@gmail.com [mailto:pku.leo@gmail.com] On Behalf Of Li Yang >> Sent: Friday, August 14, 2015 4:58 AM >> To: Yuan Yao-B46683 >> Cc: Vinod Koul; stefan@agner.ch; Arnd Bergmann; Dan Williams; >> dmaengine@vger.kernel.org; lkml; linux-arm-kernel@lists.infradead.org; linux- >> pm@vger.kernel.org >> Subject: Re: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume >> support >> >> On Tue, Jul 21, 2015 at 3:56 AM, Yuan Yao <yao.yuan@freescale.com> wrote: >> > This add power management suspend/resume support for the fsl-edma >> > driver. >> > >> > eDMA acted as a basic function used by others. What it needs to do is >> > the two steps below to support power management. >> > >> > In fsl_edma_suspend_late: >> > Check whether the DMA chan is idle and if it is not idle, stop PM >> > operation. >> >> You should try to quiesce the device on suspend instead of depending on itself >> to be happen in idle and failing if it is not. >> >> Regards, >> Leo -- - Leo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Yao Yuan <yao.yuan@freescale.com> |
|---|---|
| Date | 2015-08-17 06:00 +0200 |
| Message-ID | <pYjKy-44M-3@gated-at.bofh.it> |
| In reply to | #1207943 |
T24gU2F0LCBBdWcgMTUsIDIwMTUgYXQgNzo0OCBBTSwgcGt1LmxlbyA8IHBrdS5sZW9AZ21haWwu Y29tID4gd3JvdGU6DQo+IE9uIEZyaSwgQXVnIDE0LCAyMDE1IGF0IDE6MjQgQU0sIFlhbyBZdWFu IDx5YW8ueXVhbkBmcmVlc2NhbGUuY29tPiB3cm90ZToNCj4gPiBIaSBMZW8sDQo+ID4NCj4gPiBU aGFua3MgZm9yIHlvdXIgcmV2aWV3Lg0KPiA+IEFib3V0IHRob3NlIHR3byBtZXRob2RzIGZvciBE TUEgc3VzcGVuZCB0aGF0IHlvdSBoYXZlIG1lbnRpb25lZC4gV2UNCj4gaGF2ZSBhIGxvdCBvZiB0 aGUgZGlzY3Vzc2lvbnMgaW4gb3RoZXIgRE1BIGRyaXZlciBsaWtlIERNQSBmb3IgRnJlZXNjYWxl DQo+IFBvd2VyUEMuDQo+ID4NCj4gPiBGaW5hbGx5LCB3ZSB0aGluayB0aGUgZGV2aWNlIHdoaWNo IHVzZWQgdGhlIERNQSB0cmFuc21pc3Npb24gc2VydmljZSBzaG91bGQNCj4gY2FuY2VsIHRoZSB0 cmFuc21pc3Npb24gc2VydmljZSBpbiBpdHMgc3VzcGVuZC4NCj4gPiBTbyBETUEgaW4gc3VzcGVu ZCBzaG91bGQgYmUgaWRsZS4NCj4gDQo+IElmIHRoYXQncyB0aGUgY2FzZSB5b3Ugc2hvdWxkIGNs ZWFybHkgc3RhdGUgdGhpcyBpbiB0aGUgY29tbWl0IG1lc3NhZ2UgYW5kIGluDQo+IGNvZGUsIGFs dGhvdWdoIEkgZG9uJ3Qga25vdyBpZiBpdCBpcyBzYWZlIHRvIG1ha2Ugc3VjaCBhc3N1bXB0aW9u LiAgVGhlcmUgY291bGQNCj4gYmUgdXNlciBvZiB0aGUgRE1BIHRoYXQgZG9lc24ndCB0cmFjayB0 aGUgY29tcGxldGlvbiBvZiB0cmFuc2ZlcnMuDQoNCkkgdGhpbmsgaXQgc2hvdWxkIGJlIHNhZmUu IEluIG15IG9waW5pb24sIGV2ZW4gc29tZSBjbGllbnQodGhlIHVzZXIgb2YgdGhlIERNQSkgZm9y Z2V0IHRvIGNhbmNlbCBpdHMgRE1BIHRyYW5zbWlzc2lvbiwNCkl0IHdpbGwganVzdCBsZWFkIHRv IFBNIGZhaWxlZCBidXQgbm8gb3RoZXIgc3lzdGVtIGFuZCBkYXRhIHJpc2suDQpBbHRob3VnaCB3 ZSBzaG91bGQgZmlyc3QgZml4IHRoZSBiZWhhdmlvciBvZiB0aGUgY2xpZW50Lg0KT25jZSB5b3Ug YXJlIG5vIG5lZWQgdGhlIERNQSB0cmFuc21pc3Npb24sIHdoeSBub3Qgc3RvcCBpdD8NCg0KSXMg aXQgcmlnaHQ/DQoNCj4gPg0KPiA+IE9uY2UgdGhlIERNQSBpbiBsYXRlX3N1c3BlbmQgaXMgbm90 IGJlIGlkbGUsIHdlIHRoaW5rIHNvbWUgZHJpdmVyIGhhdmVuJ3QNCj4gY2FuY2VsZWQgdGhlIERN QSB0cmFuc21pc3Npb24uIFNvIG1heWJlIHNvbWV0aGluZyBpcyBlcnJvciB3aGVuIG90aGVyDQo+ IGRyaXZlciBpbiBzdXNwZW5kLg0KPiA+DQo+ID4gSW4gdGhlIGNhc2UsIHdlIHNob3VsZCByZXR1 cm4gZmFpbGVkIHRvIHN0b3AgUE0uIERNQSBzaG91bGQgbm90IG1ha2UgYQ0KPiBjaG9pY2UgZm9y IG90aGVyIGRyaXZlcnMod2hpY2ggdXNlZCBETUEpIHRvIGZvcmNlIHN0b3AgRE1BIHRyYW5zbWlz c2lvbi4NCj4gDQo+IFRoZSBzdXNwZW5kIGVudHJhbmNlIHNob3VsZCBiZSB0ZXJtaW5hdGVkIGJ5 IHdha2V1cCBldmVudHMgYW5kIG9ubHkgY3JpdGljYWwNCj4gaXNzdWVzLiAgSSBkb24ndCB0aGlu ayB3ZSBzaG91bGQganVzdCB0ZXJtaW5hdGUgdGhlIHN1c3BlbmQgZW50cmFuY2UganVzdA0KPiBi ZWNhdXNlIGhhdmluZyBvbi1nb2luZyBJL08gd2l0aG91dCBldmVuIHRyeSB0byBzdG9wIGl0Lg0K DQpUaGUgZ3JhY2VmdWwgYmVoYXZpb3Igd291bGQgYmUgdG8gZm9yIGNsaWVudCB0byBQQVVTRSBv ciB0ZXJtaW5hdGUgYW5kIHRoZW4gc3VzcGVuZA0KZm9sbG93ZWQgYnkgRE1BIHN1c3BlbmQuDQpX ZSBuZWVkIHRvIHJlbHkgb24gY2xpZW50IGRvaW5nIHRoZSByaWdodCB0aGluZyBoZXJlLiANClRo ZSBETUEgc2hvdWxkIG5vdCBtYWtlIGEgZGVjaXNpb24gaW5zdGVhZCBvZiBjbGllbnQuDQpJZiB0 aGUgRE1BIGlzIG5vdCBpZGxlIGluIERNQSBzdXNwZW5kLCBpdCBzaG91bGQgYmUgdGhlIGNsaWVu dCdzIGlzc3VlLg0KV2UgZG9uJ3Qga25vdyB3aGF0IHRoZSBjbGllbnQgcmVhbGx5IHdhbnQgdG8g ZG8sIHNvIGp1c3QgcmV0dXJuIHRoZSBub24tc3VjY2VzcyB2YWx1ZS4NCg0KSSdtIG5vdCBzdXJl IG15IGRlc2NyaXB0aW9uIGlzIGNsZWFyLiAgU28gd2UgbWF5IHJlZmVyIHRoZSBkaXNjdXNzaW9u IGFib3V0IHRoZSBETUEgUE0gc3VwcG9ydCBiZWZvcmUuDQpTdWNoIGFzICJETUE6IEZyZWVzY2Fs ZTogYWRkIHN1c3BlbmQgcmVzdW1lIGZ1bmN0aW9ucyBmb3IgRE1BIGRyaXZlciINCg0KTGlrZTpo dHRwczovL2xrbWwub3JnL2xrbWwvMjAxNC81LzIxLzENCg0KPiA+DQo+ID4gVGhhbmtzLg0KPiA+ DQo+ID4gQmVzdCBSZWdhcmRzLA0KPiA+IFl1YW4gWWFvDQo+ID4NCj4gPj4gLS0tLS1PcmlnaW5h bCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogcGt1Lmxlb0BnbWFpbC5jb20gW21haWx0bzpwa3Uu bGVvQGdtYWlsLmNvbV0gT24gQmVoYWxmIE9mIExpDQo+ID4+IFlhbmcNCj4gPj4gU2VudDogRnJp ZGF5LCBBdWd1c3QgMTQsIDIwMTUgNDo1OCBBTQ0KPiA+PiBUbzogWXVhbiBZYW8tQjQ2NjgzDQo+ ID4+IENjOiBWaW5vZCBLb3VsOyBzdGVmYW5AYWduZXIuY2g7IEFybmQgQmVyZ21hbm47IERhbiBX aWxsaWFtczsNCj4gPj4gZG1hZW5naW5lQHZnZXIua2VybmVsLm9yZzsgbGttbDsNCj4gPj4gbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnOyBsaW51eC0gcG1Admdlci5rZXJuZWwu b3JnDQo+ID4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjJdIGRtYWVuZ2luZTogZnNsLWVkbWE6IGFk ZCBQTSBzdXNwZW5kL3Jlc3VtZQ0KPiA+PiBzdXBwb3J0DQo+ID4+DQo+ID4+IE9uIFR1ZSwgSnVs IDIxLCAyMDE1IGF0IDM6NTYgQU0sIFl1YW4gWWFvIDx5YW8ueXVhbkBmcmVlc2NhbGUuY29tPiB3 cm90ZToNCj4gPj4gPiBUaGlzIGFkZCBwb3dlciBtYW5hZ2VtZW50IHN1c3BlbmQvcmVzdW1lIHN1 cHBvcnQgZm9yIHRoZSBmc2wtZWRtYQ0KPiA+PiA+IGRyaXZlci4NCj4gPj4gPg0KPiA+PiA+IGVE TUEgYWN0ZWQgYXMgYSBiYXNpYyBmdW5jdGlvbiB1c2VkIGJ5IG90aGVycy4gV2hhdCBpdCBuZWVk cyB0byBkbw0KPiA+PiA+IGlzIHRoZSB0d28gc3RlcHMgYmVsb3cgdG8gc3VwcG9ydCBwb3dlciBt YW5hZ2VtZW50Lg0KPiA+PiA+DQo+ID4+ID4gSW4gZnNsX2VkbWFfc3VzcGVuZF9sYXRlOg0KPiA+ PiA+IENoZWNrIHdoZXRoZXIgdGhlIERNQSBjaGFuIGlzIGlkbGUgYW5kIGlmIGl0IGlzIG5vdCBp ZGxlLCBzdG9wIFBNDQo+ID4+ID4gb3BlcmF0aW9uLg0KPiA+Pg0KPiA+PiBZb3Ugc2hvdWxkIHRy eSB0byBxdWllc2NlIHRoZSBkZXZpY2Ugb24gc3VzcGVuZCBpbnN0ZWFkIG9mIGRlcGVuZGluZw0K PiA+PiBvbiBpdHNlbGYgdG8gYmUgaGFwcGVuIGluIGlkbGUgYW5kIGZhaWxpbmcgaWYgaXQgaXMg bm90Lg0KPiA+Pg0KPiA+PiBSZWdhcmRzLA0KPiA+PiBMZW8NCj4gDQo+IA0KPiANCj4gLS0NCj4g LSBMZW8NCg== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Nigel Cunningham <nigel@nigelcunningham.com.au> |
|---|---|
| Date | 2015-08-17 09:00 +0200 |
| Message-ID | <pYmyK-87J-13@gated-at.bofh.it> |
| In reply to | #1208349 |
Hi Yao. On 17/08/15 13:59, Yao Yuan wrote: > On Sat, Aug 15, 2015 at 7:48 AM, pku.leo < pku.leo@gmail.com > wrote: >> On Fri, Aug 14, 2015 at 1:24 AM, Yao Yuan <yao.yuan@freescale.com> wrote: >>> Hi Leo, >>> >>> Thanks for your review. >>> About those two methods for DMA suspend that you have mentioned. We >> have a lot of the discussions in other DMA driver like DMA for Freescale >> PowerPC. >>> Finally, we think the device which used the DMA transmission service should >> cancel the transmission service in its suspend. >>> So DMA in suspend should be idle. >> If that's the case you should clearly state this in the commit message and in >> code, although I don't know if it is safe to make such assumption. There could >> be user of the DMA that doesn't track the completion of transfers. > I think it should be safe. In my opinion, even some client(the user of the DMA) forget to cancel its DMA transmission, > It will just lead to PM failed but no other system and data risk. > Although we should first fix the behavior of the client. > Once you are no need the DMA transmission, why not stop it? > > Is it right? Think of it from the end user perspective. Would you like your laptop (or whatever) to refuse to suspend because of this condition? The user may well expect that closing the lid on their laptop will reliably lead to it suspending to ram. Returning a failure here could result in a loss of data if the condition is not detected and the machine subsequently runs out of power. I do agree that whatever is submitting DMA should be stopped first; ideally this driver would always be idle because whatever producers of work exist would already have been quiesced and output flushed. Regards, Nigel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Yao Yuan <yao.yuan@freescale.com> |
|---|---|
| Date | 2015-08-17 09:30 +0200 |
| Message-ID | <pYn1L-tt-11@gated-at.bofh.it> |
| In reply to | #1208405 |
SGkgTmlnZWwsDQoNCk9uIE1vbiwgQXVnIDE3LCAyMDE1IGF0IDI6NDkgUE0sIE5pZ2VsIEN1bm5p bmdoYW0gPCBuaWdlbEBuaWdlbGN1bm5pbmdoYW0uY29tLmF1ID4gd3JvdGU6DQo+IE9uIDE3LzA4 LzE1IDEzOjU5LCBZYW8gWXVhbiB3cm90ZToNCj4gPiBPbiBTYXQsIEF1ZyAxNSwgMjAxNSBhdCA3 OjQ4IEFNLCBwa3UubGVvIDwgcGt1Lmxlb0BnbWFpbC5jb20gPiB3cm90ZToNCj4gPj4gT24gRnJp LCBBdWcgMTQsIDIwMTUgYXQgMToyNCBBTSwgWWFvIFl1YW4gPHlhby55dWFuQGZyZWVzY2FsZS5j b20+IHdyb3RlOg0KPiA+Pj4gSGkgTGVvLA0KPiA+Pj4NCj4gPj4+IFRoYW5rcyBmb3IgeW91ciBy ZXZpZXcuDQo+ID4+PiBBYm91dCB0aG9zZSB0d28gbWV0aG9kcyBmb3IgRE1BIHN1c3BlbmQgdGhh dCB5b3UgaGF2ZSBtZW50aW9uZWQuDQo+IFdlDQo+ID4+IGhhdmUgYSBsb3Qgb2YgdGhlIGRpc2N1 c3Npb25zIGluIG90aGVyIERNQSBkcml2ZXIgbGlrZSBETUEgZm9yDQo+ID4+IEZyZWVzY2FsZSBQ b3dlclBDLg0KPiA+Pj4gRmluYWxseSwgd2UgdGhpbmsgdGhlIGRldmljZSB3aGljaCB1c2VkIHRo ZSBETUEgdHJhbnNtaXNzaW9uIHNlcnZpY2UNCj4gPj4+IHNob3VsZA0KPiA+PiBjYW5jZWwgdGhl IHRyYW5zbWlzc2lvbiBzZXJ2aWNlIGluIGl0cyBzdXNwZW5kLg0KPiA+Pj4gU28gRE1BIGluIHN1 c3BlbmQgc2hvdWxkIGJlIGlkbGUuDQo+ID4+IElmIHRoYXQncyB0aGUgY2FzZSB5b3Ugc2hvdWxk IGNsZWFybHkgc3RhdGUgdGhpcyBpbiB0aGUgY29tbWl0DQo+ID4+IG1lc3NhZ2UgYW5kIGluIGNv ZGUsIGFsdGhvdWdoIEkgZG9uJ3Qga25vdyBpZiBpdCBpcyBzYWZlIHRvIG1ha2Ugc3VjaA0KPiA+ PiBhc3N1bXB0aW9uLiAgVGhlcmUgY291bGQgYmUgdXNlciBvZiB0aGUgRE1BIHRoYXQgZG9lc24n dCB0cmFjayB0aGUNCj4gY29tcGxldGlvbiBvZiB0cmFuc2ZlcnMuDQo+ID4gSSB0aGluayBpdCBz aG91bGQgYmUgc2FmZS4gSW4gbXkgb3BpbmlvbiwgZXZlbiBzb21lIGNsaWVudCh0aGUgdXNlciBv Zg0KPiA+IHRoZSBETUEpIGZvcmdldCB0byBjYW5jZWwgaXRzIERNQSB0cmFuc21pc3Npb24sIEl0 IHdpbGwganVzdCBsZWFkIHRvIFBNIGZhaWxlZA0KPiBidXQgbm8gb3RoZXIgc3lzdGVtIGFuZCBk YXRhIHJpc2suDQo+ID4gQWx0aG91Z2ggd2Ugc2hvdWxkIGZpcnN0IGZpeCB0aGUgYmVoYXZpb3Ig b2YgdGhlIGNsaWVudC4NCj4gPiBPbmNlIHlvdSBhcmUgbm8gbmVlZCB0aGUgRE1BIHRyYW5zbWlz c2lvbiwgd2h5IG5vdCBzdG9wIGl0Pw0KPiA+DQo+ID4gSXMgaXQgcmlnaHQ/DQo+IFRoaW5rIG9m IGl0IGZyb20gdGhlIGVuZCB1c2VyIHBlcnNwZWN0aXZlLiBXb3VsZCB5b3UgbGlrZSB5b3VyIGxh cHRvcCAob3INCj4gd2hhdGV2ZXIpIHRvIHJlZnVzZSB0byBzdXNwZW5kIGJlY2F1c2Ugb2YgdGhp cyBjb25kaXRpb24/IFRoZSB1c2VyIG1heSB3ZWxsDQo+IGV4cGVjdCB0aGF0IGNsb3NpbmcgdGhl IGxpZCBvbiB0aGVpciBsYXB0b3Agd2lsbCByZWxpYWJseSBsZWFkIHRvIGl0IHN1c3BlbmRpbmcg dG8NCj4gcmFtLiBSZXR1cm5pbmcgYSBmYWlsdXJlIGhlcmUgY291bGQgcmVzdWx0IGluIGEgbG9z cyBvZiBkYXRhIGlmIHRoZSBjb25kaXRpb24gaXMgbm90DQo+IGRldGVjdGVkIGFuZCB0aGUgbWFj aGluZSBzdWJzZXF1ZW50bHkgcnVucyBvdXQgb2YgcG93ZXIuDQo+IA0KDQpZZXMsIHRoZSB1c2Vy IG1heSB3ZWxsIGV4cGVjdCB0aGF0IGNsb3NpbmcgdGhlIGxpZCBvbiB0aGVpciBsYXB0b3Agd2ls bCByZWxpYWJseSBsZWFkIHRvIGl0IHN1c3BlbmRpbmcgdG8gcmFtLg0KU28gdGhlIGNsaWVudCh0 aGUgdXNlciBvZiB0aGUgRE1BKSBtdXN0ICB0byBQQVVTRSBvciB0ZXJtaW5hdGUgdGhlIERNQSB0 cmFuc21pc3Npb24uDQoNCldlIG5lZWQgdG8gcmVseSBvbiBjbGllbnQgZG9pbmcgdGhlIHJpZ2h0 IHRoaW5nIGhlcmUuIA0KVGhlIERNQSBzaG91bGQgbm90IG1ha2UgYSBkZWNpc2lvbiBpbnN0ZWFk IG9mIGNsaWVudC4NCklmIHRoZSBETUEgaXMgbm90IGlkbGUgaW4gRE1BIHN1c3BlbmQsIGl0IHNo b3VsZCBiZSB0aGUgY2xpZW50J3MgaXNzdWUuDQpXZSBkb24ndCBrbm93IHdoYXQgdGhlIGNsaWVu dCByZWFsbHkgd2FudCB0byBkbywgc28ganVzdCByZXR1cm4gdGhlIG5vbi1zdWNjZXNzIHZhbHVl Lg0KDQo+IEkgZG8gYWdyZWUgdGhhdCB3aGF0ZXZlciBpcyBzdWJtaXR0aW5nIERNQSBzaG91bGQg YmUgc3RvcHBlZCBmaXJzdDsgaWRlYWxseSB0aGlzDQo+IGRyaXZlciB3b3VsZCBhbHdheXMgYmUg aWRsZSBiZWNhdXNlIHdoYXRldmVyIHByb2R1Y2VycyBvZiB3b3JrIGV4aXN0IHdvdWxkDQo+IGFs cmVhZHkgaGF2ZSBiZWVuIHF1aWVzY2VkIGFuZCBvdXRwdXQgZmx1c2hlZC4NCj4gDQo= -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Li Yang <leoli@freescale.com> |
|---|---|
| Date | 2015-08-17 21:20 +0200 |
| Message-ID | <pYy6T-83E-61@gated-at.bofh.it> |
| In reply to | #1208428 |
On Mon, Aug 17, 2015 at 2:22 AM, Yao Yuan <yao.yuan@freescale.com> wrote: > Hi Nigel, > > On Mon, Aug 17, 2015 at 2:49 PM, Nigel Cunningham < nigel@nigelcunningham.com.au > wrote: >> On 17/08/15 13:59, Yao Yuan wrote: >> > On Sat, Aug 15, 2015 at 7:48 AM, pku.leo < pku.leo@gmail.com > wrote: >> >> On Fri, Aug 14, 2015 at 1:24 AM, Yao Yuan <yao.yuan@freescale.com> wrote: >> >>> Hi Leo, >> >>> >> >>> Thanks for your review. >> >>> About those two methods for DMA suspend that you have mentioned. >> We >> >> have a lot of the discussions in other DMA driver like DMA for >> >> Freescale PowerPC. >> >>> Finally, we think the device which used the DMA transmission service >> >>> should >> >> cancel the transmission service in its suspend. >> >>> So DMA in suspend should be idle. >> >> If that's the case you should clearly state this in the commit >> >> message and in code, although I don't know if it is safe to make such >> >> assumption. There could be user of the DMA that doesn't track the >> completion of transfers. >> > I think it should be safe. In my opinion, even some client(the user of >> > the DMA) forget to cancel its DMA transmission, It will just lead to PM failed >> but no other system and data risk. >> > Although we should first fix the behavior of the client. >> > Once you are no need the DMA transmission, why not stop it? >> > >> > Is it right? >> Think of it from the end user perspective. Would you like your laptop (or >> whatever) to refuse to suspend because of this condition? The user may well >> expect that closing the lid on their laptop will reliably lead to it suspending to >> ram. Returning a failure here could result in a loss of data if the condition is not >> detected and the machine subsequently runs out of power. >> > > Yes, the user may well expect that closing the lid on their laptop will reliably lead to it suspending to ram. > So the client(the user of the DMA) must to PAUSE or terminate the DMA transmission. > > We need to rely on client doing the right thing here. > The DMA should not make a decision instead of client. > If the DMA is not idle in DMA suspend, it should be the client's issue. > We don't know what the client really want to do, so just return the non-success value. The problem here is that neither the client nor the DMA controller driver should easily decide to stop the suspend entrance and rollback. I don't think the non-idle situation is serious enough to cause a rollback. You should do whatever can be done with the DMA controller(such as stop the controller and leave whatever to be done to the wake up) and continue with the suspend. Regards, Leo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web