Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1205461 > unrolled thread
| Started by | Jamie Lentin <jm@lentin.co.uk> |
|---|---|
| First post | 2015-08-12 00:20 +0200 |
| Last post | 2015-08-12 14:40 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/3] HID: lenovo: Improve wheel emulation Jamie Lentin <jm@lentin.co.uk> - 2015-08-12 00:20 +0200
[PATCH 2/3] HID: lenovo: Add missing return-value check Jamie Lentin <jm@lentin.co.uk> - 2015-08-12 00:30 +0200
[PATCH 1/3] HID: lenovo: Use constants for axes names Jamie Lentin <jm@lentin.co.uk> - 2015-08-12 00:30 +0200
Re: [PATCH 0/3] HID: lenovo: Improve wheel emulation Jiri Kosina <jikos@kernel.org> - 2015-08-12 14:40 +0200
| From | Jamie Lentin <jm@lentin.co.uk> |
|---|---|
| Date | 2015-08-12 00:20 +0200 |
| Subject | [PATCH 0/3] HID: lenovo: Improve wheel emulation |
| Message-ID | <pWq3L-1AD-3@gated-at.bofh.it> |
A collection of unrelated patches to improve support for the Thinkpad compact keyboards. The first 2 are just cleanup patches. The final patch alters the behaviour of the middle button so userspace either gets wheel events or a button click, not both. This stops browsers opening a link in a new tab as well as scrolling, for example. This means you can no longer long-middle-click, but I don't think this is likely to upset users as much as the current behaviour. Tested against 4.1.2 with both Bluetooth and USB compact keyboards. Cheers, Jamie Lentin (3): HID: lenovo: Use constants for axes names HID: lenovo: Add missing return-value check HID: lenovo: Hide middle-button press until release drivers/hid/hid-lenovo.c | 59 +++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 56 insertions(+), 3 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jamie Lentin <jm@lentin.co.uk> |
|---|---|
| Date | 2015-08-12 00:30 +0200 |
| Subject | [PATCH 2/3] HID: lenovo: Add missing return-value check |
| Message-ID | <pWqds-1LO-11@gated-at.bofh.it> |
| In reply to | #1205461 |
Signed-off-by: Jamie Lentin <jm@lentin.co.uk> --- drivers/hid/hid-lenovo.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index 65df414..265bfe2 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -178,9 +178,12 @@ static void lenovo_features_set_cptkbd(struct hid_device *hdev) struct lenovo_drvdata_cptkbd *cptkbd_data = hid_get_drvdata(hdev); ret = lenovo_send_cmd_cptkbd(hdev, 0x05, cptkbd_data->fn_lock); - ret = lenovo_send_cmd_cptkbd(hdev, 0x02, cptkbd_data->sensitivity); if (ret) hid_err(hdev, "Fn-lock setting failed: %d\n", ret); + + ret = lenovo_send_cmd_cptkbd(hdev, 0x02, cptkbd_data->sensitivity); + if (ret) + hid_err(hdev, "Sensitivity setting failed: %d\n", ret); } static ssize_t attr_fn_lock_show_cptkbd(struct device *dev, -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jamie Lentin <jm@lentin.co.uk> |
|---|---|
| Date | 2015-08-12 00:30 +0200 |
| Subject | [PATCH 1/3] HID: lenovo: Use constants for axes names |
| Message-ID | <pWqds-1LO-21@gated-at.bofh.it> |
| In reply to | #1205461 |
Signed-off-by: Jamie Lentin <jm@lentin.co.uk>
---
drivers/hid/hid-lenovo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c
index c4c3f09..65df414 100644
--- a/drivers/hid/hid-lenovo.c
+++ b/drivers/hid/hid-lenovo.c
@@ -117,10 +117,10 @@ static int lenovo_input_mapping_cptkbd(struct hid_device *hdev,
switch (usage->hid & HID_USAGE) {
case 0x0000:
- hid_map_usage(hi, usage, bit, max, EV_REL, 0x06);
+ hid_map_usage(hi, usage, bit, max, EV_REL, REL_HWHEEL);
return 1;
case 0x0001:
- hid_map_usage(hi, usage, bit, max, EV_REL, 0x08);
+ hid_map_usage(hi, usage, bit, max, EV_REL, REL_WHEEL);
return 1;
default:
return -1;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2015-08-12 14:40 +0200 |
| Message-ID | <pWDu4-4ta-61@gated-at.bofh.it> |
| In reply to | #1205461 |
On Tue, 11 Aug 2015, Jamie Lentin wrote: > A collection of unrelated patches to improve support for the Thinkpad > compact keyboards. The first 2 are just cleanup patches. > > The final patch alters the behaviour of the middle button so userspace > either gets wheel events or a button click, not both. This stops > browsers opening a link in a new tab as well as scrolling, for example. > > This means you can no longer long-middle-click, but I don't think this > is likely to upset users as much as the current behaviour. Makes sense. Let's see whether we receive any complaints about it (I don't expect that). Applied to for-4.3/lenovo. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web