Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1205430 > unrolled thread

Re: [PATCH v5 0/3] dra7xx: Add PM support to PCIe

Started byBjorn Helgaas <bhelgaas@google.com>
First post2015-08-11 23:00 +0200
Last post2015-08-12 07:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v5 0/3] dra7xx: Add PM support to PCIe Bjorn Helgaas <bhelgaas@google.com> - 2015-08-11 23:00 +0200
    Re: [PATCH v5 0/3] dra7xx: Add PM support to PCIe Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-12 07:50 +0200

#1205430 — Re: [PATCH v5 0/3] dra7xx: Add PM support to PCIe

FromBjorn Helgaas <bhelgaas@google.com>
Date2015-08-11 23:00 +0200
SubjectRe: [PATCH v5 0/3] dra7xx: Add PM support to PCIe
Message-ID<pWoOn-85g-17@gated-at.bofh.it>
On Fri, Jul 31, 2015 at 05:55:09PM +0530, Kishon Vijay Abraham I wrote:
> This series adds PM support to pci-dra7xx so that PCI clocks can be disabled
> during suspend and enabled back during resume without affecting
> PCI functionality.
> 
> Changes from v4:
> *) Fixed a bug caused by sending incomplete patch.
> 
> Changes from v3:
> *) Fix compilation errors when individual patches are applied
> 
> Changes from v2:
> *) Used SET_SYSTEM_SLEEP_PM_OPS and SET_NOIRQ_SYSTEM_SLEEP_PM_OPS for
>    populating PM ops.
> 
> Changes from v1:
> *) Moved resetting and setting of MSE bit to pci-dra7xx.
> 
> The comment to reset and set ISE is not done now since I don't have a card
> with IO space. Once I get to test that, I'll post a separate patch for
> handling that.
> 
> Kishon Vijay Abraham I (3):
>   PCI: host: pci-dra7xx: Disable pm_runtime on get_sync failure
>   PCI: host: pci-dra7xx: add pm support to pci dra7xx
>   PCI: host: pci-dra7xx: Idle the module by disabling MSE bit
> 
>  drivers/pci/host/pci-dra7xx.c |   95 ++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 94 insertions(+), 1 deletion(-)

Applied with Jingoo's Reviewed-by to pci/host-dra7xx for v4.3, thanks!

I tweaked the changelogs as follows:


commit 0e2bdb0e7abf4b5170874e415ec42df547916dd3
Author: Kishon Vijay Abraham I <kishon@ti.com>
Date:   Fri Jul 31 17:55:10 2015 +0530

    PCI: dra7xx: Disable pm_runtime on get_sync failure
    
    Fix the error handling when pm_runtime_get_sync() fails.
    
    If pm_runtime_get_sync() fails, call pm_runtime_disable() so there are no
    unbalanced pm_runtime_enable() calls.
    
    Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    Reviewed-by: Jingoo Han <jingoohan1@gmail.com>

commit e52eb445ea1d97bf7fb92d2297e487a305392136
Author: Kishon Vijay Abraham I <kishon@ti.com>
Date:   Fri Jul 31 17:55:11 2015 +0530

    PCI: dra7xx: Add PM support
    
    Add PM support to pci-dra7xx so PCI clocks can be disabled during suspend
    and enabled during resume without affecting PCI functionality.
    
    Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    Reviewed-by: Jingoo Han <jingoohan1@gmail.com>

commit 389c7094ec241ee8ebe358ba10fe392018692c8c
Author: Kishon Vijay Abraham I <kishon@ti.com>
Date:   Fri Jul 31 17:55:12 2015 +0530

    PCI: dra7xx: Clear MSE bit during suspend so clocks will idle
    
    DRA7xx requires the MSE bit to be cleared to set the master in standby
    mode.  (In DRA7xx TRM_vE, section 24.9.4.5.2.2.1 PCIe Controller Master
    Standby Behavior advises to use the clearing of the local MSE bit to set
    the master in standby.  Without this some of the clocks do not idle).
    
    Clear the MSE bit on suspend and enable it on resume.  Clearing MSE bit is
    required to get clocks to be idled after suspend.
    
    Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    Signed-off-by: Sekhar Nori <nsekhar@ti.com>
    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    Reviewed-by: Jingoo Han <jingoohan1@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1205599

FromKishon Vijay Abraham I <kishon@ti.com>
Date2015-08-12 07:50 +0200
Message-ID<pWx5h-3D9-15@gated-at.bofh.it>
In reply to#1205430

On Wednesday 12 August 2015 02:22 AM, Bjorn Helgaas wrote:
> On Fri, Jul 31, 2015 at 05:55:09PM +0530, Kishon Vijay Abraham I wrote:
>> This series adds PM support to pci-dra7xx so that PCI clocks can be disabled
>> during suspend and enabled back during resume without affecting
>> PCI functionality.
>>
>> Changes from v4:
>> *) Fixed a bug caused by sending incomplete patch.
>>
>> Changes from v3:
>> *) Fix compilation errors when individual patches are applied
>>
>> Changes from v2:
>> *) Used SET_SYSTEM_SLEEP_PM_OPS and SET_NOIRQ_SYSTEM_SLEEP_PM_OPS for
>>    populating PM ops.
>>
>> Changes from v1:
>> *) Moved resetting and setting of MSE bit to pci-dra7xx.
>>
>> The comment to reset and set ISE is not done now since I don't have a card
>> with IO space. Once I get to test that, I'll post a separate patch for
>> handling that.
>>
>> Kishon Vijay Abraham I (3):
>>   PCI: host: pci-dra7xx: Disable pm_runtime on get_sync failure
>>   PCI: host: pci-dra7xx: add pm support to pci dra7xx
>>   PCI: host: pci-dra7xx: Idle the module by disabling MSE bit
>>
>>  drivers/pci/host/pci-dra7xx.c |   95 ++++++++++++++++++++++++++++++++++++++++-
>>  1 file changed, 94 insertions(+), 1 deletion(-)
> 
> Applied with Jingoo's Reviewed-by to pci/host-dra7xx for v4.3, thanks!
> 
> I tweaked the changelogs as follows:
> 
> 
> commit 0e2bdb0e7abf4b5170874e415ec42df547916dd3
> Author: Kishon Vijay Abraham I <kishon@ti.com>
> Date:   Fri Jul 31 17:55:10 2015 +0530
> 
>     PCI: dra7xx: Disable pm_runtime on get_sync failure
>     
>     Fix the error handling when pm_runtime_get_sync() fails.
>     
>     If pm_runtime_get_sync() fails, call pm_runtime_disable() so there are no
>     unbalanced pm_runtime_enable() calls.
>     
>     Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>     Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>     Reviewed-by: Jingoo Han <jingoohan1@gmail.com>
> 
> commit e52eb445ea1d97bf7fb92d2297e487a305392136
> Author: Kishon Vijay Abraham I <kishon@ti.com>
> Date:   Fri Jul 31 17:55:11 2015 +0530
> 
>     PCI: dra7xx: Add PM support
>     
>     Add PM support to pci-dra7xx so PCI clocks can be disabled during suspend
>     and enabled during resume without affecting PCI functionality.
>     
>     Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>     Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>     Reviewed-by: Jingoo Han <jingoohan1@gmail.com>
> 
> commit 389c7094ec241ee8ebe358ba10fe392018692c8c
> Author: Kishon Vijay Abraham I <kishon@ti.com>
> Date:   Fri Jul 31 17:55:12 2015 +0530
> 
>     PCI: dra7xx: Clear MSE bit during suspend so clocks will idle
>     
>     DRA7xx requires the MSE bit to be cleared to set the master in standby
>     mode.  (In DRA7xx TRM_vE, section 24.9.4.5.2.2.1 PCIe Controller Master
>     Standby Behavior advises to use the clearing of the local MSE bit to set
>     the master in standby.  Without this some of the clocks do not idle).
>     
>     Clear the MSE bit on suspend and enable it on resume.  Clearing MSE bit is
>     required to get clocks to be idled after suspend.
>     
>     Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>     Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>     Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>     Reviewed-by: Jingoo Han <jingoohan1@gmail.com>

Thanks Bjorn!

-Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web