Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1205082 > unrolled thread
| Started by | Lee Jones <lee.jones@linaro.org> |
|---|---|
| First post | 2015-08-11 13:50 +0200 |
| Last post | 2015-08-11 17:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 3/4] mfd: Add DT binding for Maxim MAX77802 IC Lee Jones <lee.jones@linaro.org> - 2015-08-11 13:50 +0200
Re: [PATCH v3 3/4] mfd: Add DT binding for Maxim MAX77802 IC Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-11 17:30 +0200
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-08-11 13:50 +0200 |
| Subject | Re: [PATCH v3 3/4] mfd: Add DT binding for Maxim MAX77802 IC |
| Message-ID | <pWge5-413-13@gated-at.bofh.it> |
On Thu, 30 Jul 2015, Javier Martinez Canillas wrote:
> The MAX77802 is a chip that contains regulators, 2 32kHz clocks,
> a RTC and an I2C interface to program the individual components.
>
> The are already DT bindings for the regulators and clocks and
> these reference to a bindings/mfd/max77802.txt file, that didn't
> exist, for the details about the PMIC.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> Changes in v3:
> - Add Krzysztof Kozlowski Reviewed-by tag to patch #3.
> - Capitalise all acronyms. Suggested by Lee Jones.
> - Use relative path to refer other bindings. Suggested by Lee Jones.
> - Use IRQ_TYPE_NONE instead of 0 in example. Suggested by Lee Jones.
>
> Changes in v2:
> - Use the correct "maxim,max77802" compatible string.
> Suggested by Krzysztof Kozlowski
> - Use a pmic generic node name for the max77802 node example.
> Suggested by Sergei Shtylyov.
>
> Documentation/devicetree/bindings/mfd/max77802.txt | 26 ++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/max77802.txt b/Documentation/devicetree/bindings/mfd/max77802.txt
> new file mode 100644
> index 000000000000..911ec5fcaefd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/max77802.txt
> @@ -0,0 +1,26 @@
> +Maxim MAX77802 multi-function device
> +
> +The Maxim MAX77802 is a Power Management IC (PMIC) that contains 10 high
> +efficiency Buck regulators, 32 Low-DropOut (LDO) regulators used to power
> +up application processors and peripherals, a 2-channel 32kHz clock outputs,
> +a Real-Time-Clock (RTC) and a I2C interface to program the individual
> +regulators, clocks outputs and the RTC.
> +
> +Binding for the built-in 32k clock generator block is defined separately
> +in the ../clk/maxim,max77802.txt file and binding for the regulators
> +is defined in the ../regulator/max77802.txt file.
"Bindings for the built-in 32k clock generator block and
regulators are defined in ../clk/maxim,max77802.txt and
../regulator/max77802.txt respectively."
> +Required properties:
> +- compatible : Must be "maxim,max77802";
';' ?
> +- reg : Specifies the I2C slave address of PMIC block.
> +- interrupts : This I2C device has an IRQ line connected to the main SoC.
> +- interrupt-parent : The parent interrupt controller.
I always find this easier on the eye when you:
Required properties:
- compatible : Must be "maxim,max77802"
- reg : Specifies the I2C slave address of PMIC block.
- interrupts : This I2C device has an IRQ line connected to the main SoC.
- interrupt-parent : The parent interrupt controller.
> +Example:
> +
> + max77802: pmic@09 {
> + compatible = "maxim,max77802";
> + interrupt-parent = <&intc>;
> + interrupts = <26 IRQ_TYPE_NONE>;
> + reg = <0x09>;
> + };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2015-08-11 17:30 +0200 |
| Message-ID | <pWjEZ-DK-5@gated-at.bofh.it> |
| In reply to | #1205082 |
Hello Lee,
On 08/11/2015 01:47 PM, Lee Jones wrote:
> On Thu, 30 Jul 2015, Javier Martinez Canillas wrote:
>
>> The MAX77802 is a chip that contains regulators, 2 32kHz clocks,
>> a RTC and an I2C interface to program the individual components.
>>
>> The are already DT bindings for the regulators and clocks and
>> these reference to a bindings/mfd/max77802.txt file, that didn't
>> exist, for the details about the PMIC.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> ---
>>
>> Changes in v3:
>> - Add Krzysztof Kozlowski Reviewed-by tag to patch #3.
>> - Capitalise all acronyms. Suggested by Lee Jones.
>> - Use relative path to refer other bindings. Suggested by Lee Jones.
>> - Use IRQ_TYPE_NONE instead of 0 in example. Suggested by Lee Jones.
>>
>> Changes in v2:
>> - Use the correct "maxim,max77802" compatible string.
>> Suggested by Krzysztof Kozlowski
>> - Use a pmic generic node name for the max77802 node example.
>> Suggested by Sergei Shtylyov.
>>
>> Documentation/devicetree/bindings/mfd/max77802.txt | 26 ++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/max77802.txt b/Documentation/devicetree/bindings/mfd/max77802.txt
>> new file mode 100644
>> index 000000000000..911ec5fcaefd
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/max77802.txt
>> @@ -0,0 +1,26 @@
>> +Maxim MAX77802 multi-function device
>> +
>> +The Maxim MAX77802 is a Power Management IC (PMIC) that contains 10 high
>> +efficiency Buck regulators, 32 Low-DropOut (LDO) regulators used to power
>> +up application processors and peripherals, a 2-channel 32kHz clock outputs,
>> +a Real-Time-Clock (RTC) and a I2C interface to program the individual
>> +regulators, clocks outputs and the RTC.
>> +
>> +Binding for the built-in 32k clock generator block is defined separately
>> +in the ../clk/maxim,max77802.txt file and binding for the regulators
>> +is defined in the ../regulator/max77802.txt file.
>
> "Bindings for the built-in 32k clock generator block and
> regulators are defined in ../clk/maxim,max77802.txt and
> ../regulator/max77802.txt respectively."
>
>> +Required properties:
>> +- compatible : Must be "maxim,max77802";
>
> ';' ?
>
err... I've no idea how that ended there. It seems I didn't completely
context switch from coding :-)
>> +- reg : Specifies the I2C slave address of PMIC block.
>> +- interrupts : This I2C device has an IRQ line connected to the main SoC.
>> +- interrupt-parent : The parent interrupt controller.
>
> I always find this easier on the eye when you:
>
> Required properties:
> - compatible : Must be "maxim,max77802"
> - reg : Specifies the I2C slave address of PMIC block.
> - interrupts : This I2C device has an IRQ line connected to the main SoC.
> - interrupt-parent : The parent interrupt controller.
>
Ok, I'll wait for Mark's feedback and repost with your suggestions. Thanks!
>> +Example:
>> +
>> + max77802: pmic@09 {
>> + compatible = "maxim,max77802";
>> + interrupt-parent = <&intc>;
>> + interrupts = <26 IRQ_TYPE_NONE>;
>> + reg = <0x09>;
>> + };
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web