Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1205084 > unrolled thread

[xen-tip:linux-next 18/23] drivers/xen/sys-hypervisor.c:380:17: sparse: symbol 'pmu_modes' was not declared. Should it be static?

Back to article view | Back to linux.kernel

Contents

  [xen-tip:linux-next 18/23] drivers/xen/sys-hypervisor.c:380:17:  sparse: symbol 'pmu_modes' was not declared. Should it be static? kbuild test robot <fengguang.wu@intel.com> - 2015-08-11 14:00 +0200
    [PATCH xen-tip] xen/PMU: pmu_modes[] can be static kbuild test robot <fengguang.wu@intel.com> - 2015-08-11 14:00 +0200

#1205084 — [xen-tip:linux-next 18/23] drivers/xen/sys-hypervisor.c:380:17: sparse: symbol 'pmu_modes' was not declared. Should it be static?

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip linux-next
head:   0d26d72cab825a0227c8d8e0e42161125b3116fd
commit: 3ad90fe1671a12522e3360aa4c39094360a10b38 [18/23] xen/PMU: Sysfs interface for setting Xen PMU mode
reproduce:
  # apt-get install sparse
  git checkout 3ad90fe1671a12522e3360aa4c39094360a10b38
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/xen/sys-hypervisor.c:380:17: sparse: symbol 'pmu_modes' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1205086 — [PATCH xen-tip] xen/PMU: pmu_modes[] can be static

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 sys-hypervisor.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
index 0907275..b5a7342 100644
--- a/drivers/xen/sys-hypervisor.c
+++ b/drivers/xen/sys-hypervisor.c
@@ -377,7 +377,7 @@ struct pmu_mode {
 	uint32_t mode;
 };
 
-struct pmu_mode pmu_modes[] = {
+static struct pmu_mode pmu_modes[] = {
 	{"off", XENPMU_MODE_OFF},
 	{"self", XENPMU_MODE_SELF},
 	{"hv", XENPMU_MODE_HV},
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web