Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1204411 > unrolled thread

[PATCH] net/fddi:change HWM_REVERSE() macro

Started byyalin wang <yalin.wang2010@gmail.com>
First post2015-08-10 18:20 +0200
Last post2015-08-11 09:00 +0200
Articles 10 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] net/fddi:change HWM_REVERSE() macro yalin wang <yalin.wang2010@gmail.com> - 2015-08-10 18:20 +0200
    Re: [PATCH] net/fddi:change HWM_REVERSE() macro Joe Perches <joe@perches.com> - 2015-08-10 18:40 +0200
      Re: [PATCH] net/fddi:change HWM_REVERSE() macro yalin wang <yalin.wang2010@gmail.com> - 2015-08-11 03:50 +0200
        [PATCH v2] net/fddi: remove HWM_REVERSE() macro yalin wang <yalin.wang2010@gmail.com> - 2015-08-11 04:00 +0200
          Re: [PATCH v2] net/fddi: remove HWM_REVERSE() macro David Miller <davem@davemloft.net> - 2015-08-11 06:30 +0200
            Re: [PATCH v2] net/fddi: remove HWM_REVERSE() macro yalin wang <yalin.wang2010@gmail.com> - 2015-08-11 07:10 +0200
          [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro yalin wang <yalin.wang2010@gmail.com> - 2015-08-11 07:20 +0200
            Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro David Miller <davem@davemloft.net> - 2015-08-11 07:40 +0200
              Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro yalin wang <yalin.wang2010@gmail.com> - 2015-08-11 08:00 +0200
                Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro yalin wang <yalin.wang2010@gmail.com> - 2015-08-11 09:00 +0200

#1204411 — [PATCH] net/fddi:change HWM_REVERSE() macro

Fromyalin wang <yalin.wang2010@gmail.com>
Date2015-08-10 18:20 +0200
Subject[PATCH] net/fddi:change HWM_REVERSE() macro
Message-ID<pVXXQ-30p-27@gated-at.bofh.it>
change HWM_REVERSE() macro to generic le32_to_cpu()

Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
 drivers/net/fddi/skfp/h/hwmtm.h | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/net/fddi/skfp/h/hwmtm.h b/drivers/net/fddi/skfp/h/hwmtm.h
index 5924d42..72701ef 100644
--- a/drivers/net/fddi/skfp/h/hwmtm.h
+++ b/drivers/net/fddi/skfp/h/hwmtm.h
@@ -14,7 +14,7 @@
 
 #ifndef	_HWM_
 #define	_HWM_
-
+#include <linux/byteorder/generic.h>
 #include "mbuf.h"
 
 /*
@@ -74,14 +74,7 @@
 #define NULL 		0
 #endif
 
-#ifdef	LITTLE_ENDIAN
-#define HWM_REVERSE(x)	(x)
-#else
-#define	HWM_REVERSE(x)		((((x)<<24L)&0xff000000L)	+	\
-				 (((x)<< 8L)&0x00ff0000L)	+	\
-				 (((x)>> 8L)&0x0000ff00L)	+	\
-				 (((x)>>24L)&0x000000ffL))
-#endif
+#define HWM_REVERSE(x) le32_to_cpu(x)
 
 #define C_INDIC		(1L<<25)
 #define A_INDIC		(1L<<26)
-- 
1.9.1



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1204421

FromJoe Perches <joe@perches.com>
Date2015-08-10 18:40 +0200
Message-ID<pVYhc-3mY-15@gated-at.bofh.it>
In reply to#1204411
On Tue, 2015-08-11 at 00:14 +0800, yalin wang wrote:
> HWM_REVERSE

Is unused and it would be better if removed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1204685

Fromyalin wang <yalin.wang2010@gmail.com>
Date2015-08-11 03:50 +0200
Message-ID<pW6Rt-7gE-1@gated-at.bofh.it>
In reply to#1204421
> On Aug 11, 2015, at 00:36, Joe Perches <joe@perches.com> wrote:
> 
> On Tue, 2015-08-11 at 00:14 +0800, yalin wang wrote:
>> HWM_REVERSE
> 
> Is unused and it would be better if removed.
> 
ok,  i will send V2 patch .
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1204687 — [PATCH v2] net/fddi: remove HWM_REVERSE() macro

Fromyalin wang <yalin.wang2010@gmail.com>
Date2015-08-11 04:00 +0200
Subject[PATCH v2] net/fddi: remove HWM_REVERSE() macro
Message-ID<pW718-7rY-3@gated-at.bofh.it>
In reply to#1204685
 HWM_REVERSE() macro is unused, remove it.

Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
 drivers/net/fddi/skfp/h/hwmtm.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/net/fddi/skfp/h/hwmtm.h b/drivers/net/fddi/skfp/h/hwmtm.h
index 5924d42..4ca2341 100644
--- a/drivers/net/fddi/skfp/h/hwmtm.h
+++ b/drivers/net/fddi/skfp/h/hwmtm.h
@@ -74,15 +74,6 @@
 #define NULL           0
 #endif
 
-#ifdef LITTLE_ENDIAN
-#define HWM_REVERSE(x) (x)
-#else
-#define        HWM_REVERSE(x)          ((((x)<<24L)&0xff000000L)       +       \
-                                (((x)<< 8L)&0x00ff0000L)       +       \
-                                (((x)>> 8L)&0x0000ff00L)       +       \
-                                (((x)>>24L)&0x000000ffL))
-#endif
-
 #define C_INDIC                (1L<<25)
 #define A_INDIC                (1L<<26)
 #define        RD_FS_LOCAL     0x80
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1204744 — Re: [PATCH v2] net/fddi: remove HWM_REVERSE() macro

FromDavid Miller <davem@davemloft.net>
Date2015-08-11 06:30 +0200
SubjectRe: [PATCH v2] net/fddi: remove HWM_REVERSE() macro
Message-ID<pW9mi-2Cq-3@gated-at.bofh.it>
In reply to#1204687
From: yalin wang <yalin.wang2010@gmail.com>
Date: Tue, 11 Aug 2015 09:57:21 +0800

>  HWM_REVERSE() macro is unused, remove it.
> 
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>

Your email client has corrupted this patch.

Please read Documentation/email-clients.txt, send a test patch to yourself,
and only resubmit this change once you are able to successfully apply the
patch you receive in that test email.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1204752 — Re: [PATCH v2] net/fddi: remove HWM_REVERSE() macro

Fromyalin wang <yalin.wang2010@gmail.com>
Date2015-08-11 07:10 +0200
SubjectRe: [PATCH v2] net/fddi: remove HWM_REVERSE() macro
Message-ID<pW9Z0-3Ax-5@gated-at.bofh.it>
In reply to#1204744
> On Aug 11, 2015, at 12:24, David Miller <davem@davemloft.net> wrote:
> 
> From: yalin wang <yalin.wang2010@gmail.com>
> Date: Tue, 11 Aug 2015 09:57:21 +0800
> 
>> HWM_REVERSE() macro is unused, remove it.
>> 
>> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> 
> Your email client has corrupted this patch.
> 
> Please read Documentation/email-clients.txt, send a test patch to yourself,
> and only resubmit this change once you are able to successfully apply the
> patch you receive in that test email.
> 
> Thanks.
ok, Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1204753 — [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

Fromyalin wang <yalin.wang2010@gmail.com>
Date2015-08-11 07:20 +0200
Subject[PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro
Message-ID<pWa8F-3LY-1@gated-at.bofh.it>
In reply to#1204687
HWM_REVERSE() macro is unused, remove it.

Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
drivers/net/fddi/skfp/h/hwmtm.h | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/net/fddi/skfp/h/hwmtm.h b/drivers/net/fddi/skfp/h/hwmtm.h
index 5924d42..4ca2341 100644
--- a/drivers/net/fddi/skfp/h/hwmtm.h
+++ b/drivers/net/fddi/skfp/h/hwmtm.h
@@ -74,15 +74,6 @@
#define NULL           0
#endif

-#ifdef LITTLE_ENDIAN
-#define HWM_REVERSE(x) (x)
-#else
-#define        HWM_REVERSE(x)          ((((x)<<24L)&0xff000000L)       +       \
-                                (((x)<< 8L)&0x00ff0000L)       +       \
-                                (((x)>> 8L)&0x0000ff00L)       +       \
-                                (((x)>>24L)&0x000000ffL))
-#endif
-
#define C_INDIC                (1L<<25)
#define A_INDIC                (1L<<26)
#define        RD_FS_LOCAL     0x80
-- 
1.9.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1204761 — Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

FromDavid Miller <davem@davemloft.net>
Date2015-08-11 07:40 +0200
SubjectRe: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro
Message-ID<pWas2-48U-15@gated-at.bofh.it>
In reply to#1204753
From: yalin wang <yalin.wang2010@gmail.com>
Date: Tue, 11 Aug 2015 13:11:22 +0800

> HWM_REVERSE() macro is unused, remove it.
> 
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>

You did not do as I asked you to, this patch is still corrupted
and there is no way you successfully applied what is in this patch.

> -#define        HWM_REVERSE(x)          ((((x)<<24L)&0xff000000L)       +       \
> -                                (((x)<< 8L)&0x00ff0000L)       +       \
> -                                (((x)>> 8L)&0x0000ff00L)       +       \
> -                                (((x)>>24L)&0x000000ffL))

This indentation here is spaces, whereas in the source files they
are TABS.

Your email client did this.

If you fail to properly verify that your outgoing patches are not
corrupted before submitting them here, I will stop reviewing and
considering your changes.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1204763 — Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

Fromyalin wang <yalin.wang2010@gmail.com>
Date2015-08-11 08:00 +0200
SubjectRe: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro
Message-ID<pWaLn-4v5-1@gated-at.bofh.it>
In reply to#1204761
> On Aug 11, 2015, at 13:37, David Miller <davem@davemloft.net> wrote:
> 
> From: yalin wang <yalin.wang2010@gmail.com>
> Date: Tue, 11 Aug 2015 13:11:22 +0800
> 
>> HWM_REVERSE() macro is unused, remove it.
>> 
>> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> 
> You did not do as I asked you to, this patch is still corrupted
> and there is no way you successfully applied what is in this patch.
> 
>> -#define        HWM_REVERSE(x)          ((((x)<<24L)&0xff000000L)       +       \
>> -                                (((x)<< 8L)&0x00ff0000L)       +       \
>> -                                (((x)>> 8L)&0x0000ff00L)       +       \
>> -                                (((x)>>24L)&0x000000ffL))
> 
> This indentation here is spaces, whereas in the source files they
> are TABS.
> 
> Your email client did this.
> 
> If you fail to properly verify that your outgoing patches are not
> corrupted before submitting them here, I will stop reviewing and
> considering your changes.
> 
> Thank you.
ouch,  i am sorry that i am sending from windows PC,
let me check that .
Sorry for that .--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1204828 — Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

Fromyalin wang <yalin.wang2010@gmail.com>
Date2015-08-11 09:00 +0200
SubjectRe: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro
Message-ID<pWbHs-5QC-17@gated-at.bofh.it>
In reply to#1204763
HWM_REVERSE() macro is unused, remove it.

Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
 drivers/net/fddi/skfp/h/hwmtm.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/net/fddi/skfp/h/hwmtm.h b/drivers/net/fddi/skfp/h/hwmtm.h
index 5924d42..4ca2341 100644
--- a/drivers/net/fddi/skfp/h/hwmtm.h
+++ b/drivers/net/fddi/skfp/h/hwmtm.h
@@ -74,15 +74,6 @@
 #define NULL 		0
 #endif
 
-#ifdef	LITTLE_ENDIAN
-#define HWM_REVERSE(x)	(x)
-#else
-#define	HWM_REVERSE(x)		((((x)<<24L)&0xff000000L)	+	\
-				 (((x)<< 8L)&0x00ff0000L)	+	\
-				 (((x)>> 8L)&0x0000ff00L)	+	\
-				 (((x)>>24L)&0x000000ffL))
-#endif
-
 #define C_INDIC		(1L<<25)
 #define A_INDIC		(1L<<26)
 #define	RD_FS_LOCAL	0x80
-- 
1.9.1















--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web